Skip to content

680 fix position playbacksession #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 7 commits into from
Aug 22, 2024
Merged

680 fix position playbacksession #683

StaehliJ merged 7 commits into from
Aug 22, 2024

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Aug 20, 2024 •
edited
Loading

Pull request

Description

The goal of this PR is to send the position of the player before item transition.

Changes made

  • Changes PlaybackSession.Listener to have more information during session transition.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@github-actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

Code Coverage

Overall Project 53.39% -0.06% 🟢
Files changed 95.82% 🟢

Module Coverage
:pillarbox-player 60.55% -0.11% 🟢
Files
Module File Coverage
:pillarbox-player PlaybackSessionManager.kt 97.19% -1.69% 🟢
QoSCoordinator.kt 90.86% 🟢
MetricsCollector.kt 70.64% -0.89% 🟢

MGaetan89
MGaetan89 reviewed Aug 21, 2024
View reviewed changes
@MGaetan89 MGaetan89 linked an issue Aug 21, 2024 that may be closed by this pull request
Provide correct position when session finished #680
Closed
1 task
@StaehliJ StaehliJ merged commit 9312102 into qos Aug 22, 2024
@StaehliJ StaehliJ deleted the 680-fix-position-playbacksession branch August 22, 2024 06:51
StaehliJ added a commit that referenced this pull request Aug 28, 2024
@StaehliJ @MGaetan89
680 fix position playbacksession (#683)
7e7b515 
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
StaehliJ added a commit that referenced this pull request Sep 11, 2024
@StaehliJ @MGaetan89
680 fix position playbacksession (#683)
0d57405 
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
MGaetan89 added a commit that referenced this pull request Sep 12, 2024
@StaehliJ @MGaetan89
680 fix position playbacksession (#683)
a0863b7 
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide correct position when session finished

2 participants

@StaehliJ @MGaetan89