Skip to content

Update models for QoS #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 18 commits into from
Jul 30, 2024
Merged

Update models for QoS #654

StaehliJ merged 18 commits into from
Jul 30, 2024

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Jul 25, 2024 •
edited
Loading

Pull request

Description

Following recent discussions, I've updated the models related to QoS.

Changes made

  • Update the existing models for QoS to match the latest agreement.
  • Move all QoS-related models into a dedicated models package.
  • Update the Context.getDeviceType() extension in QoSSession to support DESKTOP, and return UNKNOWN by default (instead of PHONE).

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 self-assigned this Jul 25, 2024
@MGaetan89 MGaetan89 added this to the QoS milestone Jul 25, 2024
@github-actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Code Coverage

Overall Project 53.98% -0.02% 🟢
Files changed 98.89% 🟢

Module Coverage
:pillarbox-player 60.25% -0.04% 🟢
Files
Module File Coverage
:pillarbox-player QoSMessageHandler.kt 100% 🟢
QoSEvent.kt 100% 🟢
QoSScreen.kt 100% 🟢
QoSSessionTimings.kt 100% 🟢
QoSMedia.kt 100% 🟢
QoSSession.kt 100% 🟢
QoSMessage.kt 100% 🟢
QoSOS.kt 100% 🟢
QoSPlayer.kt 100% 🟢
QoSDevice.kt 100% 🟢
QoSStall.kt 100% 🟢
QoSError.kt 97.18% -2.82% 🟢
QoSCoordinator.kt 86.01% -0.93% 🟢

MGaetan89 and others added 11 commits July 29, 2024 13:50
@MGaetan89 @StaehliJ
Add models for QoS and an AnalyticsListener to gather session load …
24f0378 
…times (#596)

Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
@StaehliJ @MGaetan89
592 playback session manager (#597)
2f2618d 
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
@MGaetan89
Link PlaybackSessionManager with QoSSessionAnalyticsListener (#609)
cf04c2d
@StaehliJ @MGaetan89
604 collect stalls metrics (#610)
b8be3f7 
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
@MGaetan89
Enable CI on the qos branch (#615)
e3f057b
@StaehliJ @MGaetan89
619 enhance sessionmanager with perioduid (#627)
620f5a5
@StaehliJ @MGaetan89
625 consolidate metrics management (#632)
1cbe994 
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
@MGaetan89
Extract session management out of QoSEventsDispatcher (#635)
b0bc5b2
@StaehliJ @MGaetan89
631 metrics collector (#638)
62b0ec7 
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
@StaehliJ @MGaetan89
Improve metrics collector (#644)
f957313 
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
@MGaetan89
Create line and bar chart components for the demo (#645)
b24b69f
@MGaetan89 MGaetan89 force-pushed the update_qos_models branch from d3e6575 to d6a0091 Compare July 29, 2024 11:53
@MGaetan89 MGaetan89 force-pushed the update_qos_models branch from d6a0091 to 467b57e Compare July 29, 2024 13:03
@StaehliJ @MGaetan89
Metrics collector UI (#655)
09eb787 
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
@MGaetan89 MGaetan89 force-pushed the update_qos_models branch from 467b57e to 1d90c3e Compare July 30, 2024 07:26
MGaetan89 and others added 2 commits July 30, 2024 10:00
@MGaetan89 @StaehliJ
Update heartbeat behavior (#656)
4c8be12 
Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
@MGaetan89
Move QoS models into a dedicated models package
2ebab7a
@MGaetan89 MGaetan89 force-pushed the update_qos_models branch from 1d90c3e to aa4a8f9 Compare July 30, 2024 08:07
@StaehliJ StaehliJ merged commit 1b62395 into qos Jul 30, 2024
@StaehliJ StaehliJ deleted the update_qos_models branch July 30, 2024 09:23
MGaetan89 added a commit that referenced this pull request Aug 12, 2024
@MGaetan89 @StaehliJ
Update models for QoS (#654)
8703c23 
Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
MGaetan89 added a commit that referenced this pull request Aug 13, 2024
@MGaetan89 @StaehliJ
Update models for QoS (#654)
ab1dafe 
Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
MGaetan89 added a commit that referenced this pull request Aug 20, 2024
@MGaetan89 @StaehliJ
Update models for QoS (#654)
2e6da87 
Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
StaehliJ added a commit that referenced this pull request Aug 28, 2024
@MGaetan89 @StaehliJ
Update models for QoS (#654)
1689b92 
Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
StaehliJ added a commit that referenced this pull request Sep 11, 2024
@MGaetan89 @StaehliJ
Update models for QoS (#654)
faf0751 
Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
MGaetan89 added a commit that referenced this pull request Sep 12, 2024
@MGaetan89 @StaehliJ
Update models for QoS (#654)
9c83018 
Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

@MGaetan89 MGaetan89

Labels

None yet

Projects

Pillarbox
Archived in project

Milestone

QoS

Development

Successfully merging this pull request may close these issues.

2 participants

@MGaetan89 @StaehliJ