Skip to content

619 enhance sessionmanager with perioduid #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 2 commits into from
Jul 2, 2024
Merged

619 enhance sessionmanager with perioduid #627

StaehliJ merged 2 commits into from
Jul 2, 2024

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Jul 2, 2024

Pull request

Description

The goal of this PR is to provide a better way to make each item in the playlist unique.

Changes made

  • Use PeriodUid to make session with MediaItem unique

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@github-actions
Copy link

github-actions bot commented Jul 2, 2024

Code Coverage

Overall Project 53.03% -0.16% 🟢
Files changed 82.63% 🟢

Module Coverage
:pillarbox-player 54.52% -0.32% 🟢
Files
Module File Coverage
:pillarbox-player PlaybackSessionManager.kt 90.66% -8.24% 🟢
QoSSessionAnalyticsListener.kt 67.8% -2.17% 🟢

@MGaetan89 MGaetan89 linked an issue Jul 2, 2024 that may be closed by this pull request
Enhance SessionManager with PeriodUid #619
Closed
1 task
@StaehliJ StaehliJ merged commit 5ed2ca3 into qos Jul 2, 2024
@StaehliJ StaehliJ deleted the 619-enhance-sessionmanager-with-perioduid branch July 2, 2024 09:20
MGaetan89
MGaetan89 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!
I just updated the documentation, and remove some duplicated code.

MGaetan89 pushed a commit that referenced this pull request Jul 9, 2024
@StaehliJ @MGaetan89
619 enhance sessionmanager with perioduid (#627)
ad3eb89
MGaetan89 pushed a commit that referenced this pull request Jul 11, 2024
@StaehliJ @MGaetan89
619 enhance sessionmanager with perioduid (#627)
1ac1570
MGaetan89 pushed a commit that referenced this pull request Jul 17, 2024
@StaehliJ @MGaetan89
619 enhance sessionmanager with perioduid (#627)
563c1ee
MGaetan89 pushed a commit that referenced this pull request Jul 29, 2024
@StaehliJ @MGaetan89
619 enhance sessionmanager with perioduid (#627)
620f5a5
MGaetan89 pushed a commit that referenced this pull request Jul 30, 2024
@StaehliJ @MGaetan89
619 enhance sessionmanager with perioduid (#627)
ea1d2b0
MGaetan89 pushed a commit that referenced this pull request Aug 12, 2024
@StaehliJ @MGaetan89
619 enhance sessionmanager with perioduid (#627)
437732b
MGaetan89 pushed a commit that referenced this pull request Aug 13, 2024
@StaehliJ @MGaetan89
619 enhance sessionmanager with perioduid (#627)
5e2e5b1
MGaetan89 pushed a commit that referenced this pull request Aug 20, 2024
@StaehliJ @MGaetan89
619 enhance sessionmanager with perioduid (#627)
3a9bb37
StaehliJ added a commit that referenced this pull request Aug 28, 2024
@StaehliJ
619 enhance sessionmanager with perioduid (#627)
dbdce77
StaehliJ added a commit that referenced this pull request Sep 11, 2024
@StaehliJ
619 enhance sessionmanager with perioduid (#627)
bd459f9
MGaetan89 pushed a commit that referenced this pull request Sep 12, 2024
@StaehliJ @MGaetan89
619 enhance sessionmanager with perioduid (#627)
de51c7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhance SessionManager with PeriodUid

2 participants

@StaehliJ @MGaetan89