Improve metrics collector #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
Files
|
MGaetan89
approved these changes
Jul 19, 2024
Contributor
MGaetan89
left a comment
There was a problem hiding this comment.
Some minor comments/questions, but looks good otherwise.
From a quick testing, it seems to be working fine 👍🏻
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/analytics/metrics/PlaybackMetrics.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/analytics/metrics/MetricsCollector.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/analytics/metrics/SessionMetrics.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/analytics/metrics/SessionMetrics.kt
Outdated
Show resolved
Hide resolved
…ytics/metrics/PlaybackMetrics.kt Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
MGaetan89
approved these changes
Jul 23, 2024
MGaetan89
added a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
MGaetan89
added a commit
that referenced
this pull request
Jul 30, 2024
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
MGaetan89
added a commit
that referenced
this pull request
Aug 12, 2024
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
MGaetan89
added a commit
that referenced
this pull request
Aug 13, 2024
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
MGaetan89
added a commit
that referenced
this pull request
Aug 20, 2024
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
StaehliJ
added a commit
that referenced
this pull request
Aug 28, 2024
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
StaehliJ
added a commit
that referenced
this pull request
Sep 11, 2024
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
MGaetan89
added a commit
that referenced
this pull request
Sep 12, 2024
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The goal of this PR is to measure metric for each session for consistency.
Changes made
Checklist
mainbranch.