Skip to content

Extract session management out of QoSEventsDispatcher #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 1 commit into from
Jul 12, 2024
Merged

Extract session management out of QoSEventsDispatcher #635

StaehliJ merged 1 commit into from
Jul 12, 2024

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Jul 11, 2024 •
edited
Loading

Pull request

Description

This PR extracts the session management from QoSEventsDispatcher into its own PlaybackSessionManager class.

Changes made

  • Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Jul 11, 2024 that may be closed by this pull request
Extract session manager from PillarboxEventsDispatcher #634
Closed
@github-actions
Copy link

github-actions bot commented Jul 11, 2024

Code Coverage

Overall Project 52.88% -0.31% 🟢
Files changed 88.16% 🟢

Module Coverage
:pillarbox-player 58.11% -0.61% 🟢
Files
Module File Coverage
:pillarbox-player QoSEventsDispatcher.kt 100% 🟢
PlaybackSessionManager.kt 94.79% -5.21% 🟢
StartupTimesTracker.kt 91.3% 🟢
PillarboxExoPlayer.kt 83.77% 🟢
QoSCoordinator.kt 76.54% -1.66% 🟢
PillarboxEventsDispatcher.kt 67.58% -20.55% 🟢

@MGaetan89 MGaetan89 requested a review from StaehliJ July 11, 2024 15:57
@StaehliJ StaehliJ merged commit b4f4a26 into qos Jul 12, 2024
@StaehliJ StaehliJ deleted the 634-extract-session-manager-from-pillarboxeventsdispatcher branch July 12, 2024 08:17
MGaetan89 added a commit that referenced this pull request Jul 17, 2024
@MGaetan89
Extract session management out of QoSEventsDispatcher (#635)
9d606eb
MGaetan89 added a commit that referenced this pull request Jul 29, 2024
@MGaetan89
Extract session management out of QoSEventsDispatcher (#635)
b0bc5b2
MGaetan89 added a commit that referenced this pull request Jul 30, 2024
@MGaetan89
Extract session management out of QoSEventsDispatcher (#635)
1ce0b97
MGaetan89 added a commit that referenced this pull request Aug 12, 2024
@MGaetan89
Extract session management out of QoSEventsDispatcher (#635)
7f7ce65
MGaetan89 added a commit that referenced this pull request Aug 13, 2024
@MGaetan89
Extract session management out of QoSEventsDispatcher (#635)
cd357ab
MGaetan89 added a commit that referenced this pull request Aug 20, 2024
@MGaetan89
Extract session management out of QoSEventsDispatcher (#635)
76dbedd
StaehliJ pushed a commit that referenced this pull request Aug 28, 2024
@MGaetan89 @StaehliJ
Extract session management out of QoSEventsDispatcher (#635)
962bfb9
StaehliJ pushed a commit that referenced this pull request Sep 11, 2024
@MGaetan89 @StaehliJ
Extract session management out of QoSEventsDispatcher (#635)
702d7cb
MGaetan89 added a commit that referenced this pull request Sep 12, 2024
@MGaetan89
Extract session management out of QoSEventsDispatcher (#635)
f1f8ebe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extract session manager from PillarboxEventsDispatcher

2 participants

@MGaetan89 @StaehliJ