Skip to content

Remove usage of List.removeIf #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MGaetan89 merged 1 commit into from
Jul 29, 2024
Merged

Remove usage of List.removeIf #657

MGaetan89 merged 1 commit into from
Jul 29, 2024

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Jul 29, 2024 •
edited
Loading

Pull request

Description

The List.removeIf() method was introduced in API 24 and our min is API 21.
This PR removes its usage in Charts in favor of an other approach to address the warning that Android Lint started to report.

Changes made

  • Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 self-assigned this Jul 29, 2024
@MGaetan89 MGaetan89 added the bug Something isn't working label Jul 29, 2024
@MGaetan89 MGaetan89 added this to the QoS milestone Jul 29, 2024
@github-actions
Copy link

github-actions bot commented Jul 29, 2024

Code Coverage

Overall Project 53.3% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 merged commit 89a87bc into qos Jul 29, 2024
@MGaetan89 MGaetan89 deleted the remove_removeIf_usage branch July 29, 2024 13:02
MGaetan89 added a commit that referenced this pull request Jul 30, 2024
@MGaetan89
Remove usage of List.removeIf (#657)
4a59ed3
MGaetan89 added a commit that referenced this pull request Aug 12, 2024
@MGaetan89
Remove usage of List.removeIf (#657)
4f55fc4
MGaetan89 added a commit that referenced this pull request Aug 13, 2024
@MGaetan89
Remove usage of List.removeIf (#657)
1c92835
MGaetan89 added a commit that referenced this pull request Aug 20, 2024
@MGaetan89
Remove usage of List.removeIf (#657)
a1491aa
StaehliJ pushed a commit that referenced this pull request Aug 28, 2024
@MGaetan89 @StaehliJ
Remove usage of List.removeIf (#657)
7badd70
StaehliJ pushed a commit that referenced this pull request Sep 11, 2024
@MGaetan89 @StaehliJ
Remove usage of List.removeIf (#657)
1ecded6
MGaetan89 added a commit that referenced this pull request Sep 12, 2024
@MGaetan89
Remove usage of List.removeIf (#657)
1a9e06b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

@MGaetan89 MGaetan89

Labels

bug Something isn't working

Projects

Pillarbox
Archived in project

Milestone

QoS

Development

Successfully merging this pull request may close these issues.

2 participants

@MGaetan89 @StaehliJ