Skip to content

Link PlaybackSessionManager with QoSSessionAnalyticsListener #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 3 commits into from
Jun 27, 2024
Merged

Link PlaybackSessionManager with QoSSessionAnalyticsListener #609

StaehliJ merged 3 commits into from
Jun 27, 2024

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Jun 26, 2024 •
edited
Loading

Pull request

Description

This PR puts together #596 and #597, so the former uses the session manager provided by #597.

Changes made

  • Link QoSSessionAnalyticsListener with PlaybackSessionManager.
  • Move the listener property of PlaybackSessionManager to its constructor.
  • Replace QoSSessionTimings.total with QoSSessionTimings.currentToStart and implement its logic.
  • Add some tests to PlaybackSessionManager.

Note

The tests on QoSSessionAnalyticsListener have been disabled for now, because they require a SurfaceView, which is not set supported by Robolectric.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Jun 26, 2024 that may be closed by this pull request
Link QoSSession with PlaybackSessionManager #600
Closed
@github-actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

Code Coverage

Overall Project 52.91% -0.49% 🟢
Files changed 68.82% 🟢

Module Coverage
:pillarbox-player 54.29% -0.97% 🟢
Files
Module File Coverage
:pillarbox-player QoSSessionTimings.kt 100% 🟢
PlaybackSessionManager.kt 93.21% -1.17% 🟢
PillarboxExoPlayer.kt 83.77% 🟢
QoSSessionAnalyticsListener.kt 64.6% -31.27% 🟢

@StaehliJ StaehliJ merged commit 1a41bf2 into qos Jun 27, 2024
@StaehliJ StaehliJ deleted the 600-link-qossession-with-playbacksessionmanager branch June 27, 2024 07:36
MGaetan89 added a commit that referenced this pull request Jul 9, 2024
@MGaetan89
Link PlaybackSessionManager with QoSSessionAnalyticsListener (#609)
81950a8
MGaetan89 added a commit that referenced this pull request Jul 11, 2024
@MGaetan89
Link PlaybackSessionManager with QoSSessionAnalyticsListener (#609)
4627e16
MGaetan89 added a commit that referenced this pull request Jul 17, 2024
@MGaetan89
Link PlaybackSessionManager with QoSSessionAnalyticsListener (#609)
92898a5
MGaetan89 added a commit that referenced this pull request Jul 29, 2024
@MGaetan89
Link PlaybackSessionManager with QoSSessionAnalyticsListener (#609)
cf04c2d
MGaetan89 added a commit that referenced this pull request Jul 30, 2024
@MGaetan89
Link PlaybackSessionManager with QoSSessionAnalyticsListener (#609)
2902a14
MGaetan89 added a commit that referenced this pull request Aug 12, 2024
@MGaetan89
Link PlaybackSessionManager with QoSSessionAnalyticsListener (#609)
59c7aa5
MGaetan89 added a commit that referenced this pull request Aug 13, 2024
@MGaetan89
Link PlaybackSessionManager with QoSSessionAnalyticsListener (#609)
b9676c9
MGaetan89 added a commit that referenced this pull request Aug 20, 2024
@MGaetan89
Link PlaybackSessionManager with QoSSessionAnalyticsListener (#609)
20b157c
StaehliJ pushed a commit that referenced this pull request Aug 28, 2024
@MGaetan89 @StaehliJ
Link PlaybackSessionManager with QoSSessionAnalyticsListener (#609)
9d6d7fc
StaehliJ pushed a commit that referenced this pull request Sep 11, 2024
@MGaetan89 @StaehliJ
Link PlaybackSessionManager with QoSSessionAnalyticsListener (#609)
1491ad3
MGaetan89 added a commit that referenced this pull request Sep 12, 2024
@MGaetan89
Link PlaybackSessionManager with QoSSessionAnalyticsListener (#609)
31cfb5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Link QoSSession with PlaybackSessionManager

2 participants

@MGaetan89 @StaehliJ