Create mobile screen for QoS #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

StaehliJ merged 6 commits into qos from 664-display-metrics-chart-inside-the-demo

Aug 12, 2024

Contributor

MGaetan89 commented Aug 8, 2024 •

edited

Loading

Pull request

Description

This PR adds a new section in the player settings to display the collected metrics about the currently playing media.

Changes made

Created StatsForNerdsViewModel in pillarbox-demo-shared to share data between pillarbox-demo and pillarbox-demo-tv.
Created the StatsForNerds screens in pillarbox-demo and pillarbox-demo-tv.
Added a new entry in the player settings to access the metrics screen.
Added a new DemoListItemView variant, where the title and value are displayed on one line.
Improved DemoPlayerView landscape support when displaying the player settings.
Improved demo and Media3 versions display in the app settings.

Screenshots

Mobile screenshots

Description	Screenshot
Player setting
Metrics view (info)
Metrics view (charts)
Player settings (landscape)
Metrics view (landscape)

TV screenshots

Description	Screenshot
Player setting
Metrics view (info)
Metric view (charts)

Checklist

Your branch has been rebased onto the main branch.
APIs have been properly documented (if relevant).
The documentation has been updated (if relevant).
New unit tests have been written (if relevant).
The demo has been updated (if relevant).
All pull request status checks pass.

MGaetan89 linked an issue

that may be closed by this pull request

Display metrics chart inside the demo #664

Closed

1 task

github-advanced-security bot found potential problems

View reviewed changes

pillarbox-demo-shared/src/main/res/values/strings.xml

    
                  <string name="audio_track">Audio tracks</string>

                  <string name="video_tracks">Video tracks</string>

                  <string name="stats_for_nerds">Stats for nerds</string>

                  <string name="startup_times">Startup times</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.startup_times appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

    
                  <string name="resource_loading">Resource loading</string>

                  <string name="drm_loading">DRM loading</string>

                  <string name="total_load_time">Total load time</string>

                  <string name="media_information">Information</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.media_information appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

    
                  <string name="media_uri">URI</string>

                  <string name="playback_duration">Playback duration</string>

                  <string name="data_volume">Data volume</string>

                  <string name="stalls">Stalls</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.stalls appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

    
                  <string name="stalls">Stalls</string>

                  <string name="buffering">Buffering</string>

                  <string name="video_size">Video size</string>

                  <string name="indicated_bitrate">Indicated bitrate</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.indicated_bitrate appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

    
                  <string name="buffering">Buffering</string>

                  <string name="video_size">Video size</string>

                  <string name="indicated_bitrate">Indicated bitrate</string>

                  <string name="minimum_value">Min. %s</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.minimum_value appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

    
                  <string name="video_size">Video size</string>

                  <string name="indicated_bitrate">Indicated bitrate</string>

                  <string name="minimum_value">Min. %s</string>

                  <string name="current_value">Cur. %s</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.current_value appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

    
                  <string name="indicated_bitrate">Indicated bitrate</string>

                  <string name="minimum_value">Min. %s</string>

                  <string name="current_value">Cur. %s</string>

                  <string name="maximum_value">Max. %s</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.maximum_value appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

    
                  <string name="minimum_value">Min. %s</string>

                  <string name="current_value">Cur. %s</string>

                  <string name="maximum_value">Max. %s</string>

                  <string name="observed_bitrate">Observed bitrate</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.observed_bitrate appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

    
                  <string name="current_value">Cur. %s</string>

                  <string name="maximum_value">Max. %s</string>

                  <string name="observed_bitrate">Observed bitrate</string>

                  <string name="total_volume">Total %s</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.total_volume appears to be unused

pillarbox-demo-shared/src/main/res/values/strings.xml

    
                  <string name="maximum_value">Max. %s</string>

                  <string name="observed_bitrate">Observed bitrate</string>

                  <string name="total_volume">Total %s</string>

                  <string name="total_stalls">Total %s</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.total_stalls appears to be unused

github-actions bot commented Aug 8, 2024 •

edited

Loading

Code Coverage

Overall Project	53.46%	🟢

There is no coverage information present for the Files changed

MGaetan89 force-pushed the 664-display-metrics-chart-inside-the-demo branch from cca67a2 to d61245b Compare

August 9, 2024 13:59

github-advanced-security bot found potential problems

View reviewed changes

pillarbox-demo-tv/src/main/java/ch/srgssr/pillarbox/demo/tv/ui/player/metrics/StatsForNerds.kt Fixed Show fixed Hide fixed

pillarbox-demo-tv/src/main/java/ch/srgssr/pillarbox/demo/tv/ui/player/metrics/StatsForNerds.kt Fixed Show fixed Hide fixed

pillarbox-demo-tv/src/main/java/ch/srgssr/pillarbox/demo/tv/ui/player/metrics/StatsForNerds.kt Fixed Show fixed Hide fixed

pillarbox-demo-tv/src/main/java/ch/srgssr/pillarbox/demo/tv/ui/player/metrics/StatsForNerds.kt Fixed Show fixed Hide fixed

pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/metrics/StatsForNerds.kt Fixed Show fixed Hide fixed

pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/metrics/StatsForNerds.kt Fixed Show fixed Hide fixed

MGaetan89 marked this pull request as ready for review

August 9, 2024 14:35

StaehliJ reviewed

View reviewed changes

...ed/src/main/java/ch/srgssr/pillarbox/demo/shared/ui/player/metrics/StatsForNerdsViewModel.kt Outdated Show resolved Hide resolved

...ed/src/main/java/ch/srgssr/pillarbox/demo/shared/ui/player/metrics/StatsForNerdsViewModel.kt Show resolved Hide resolved

...ed/src/main/java/ch/srgssr/pillarbox/demo/shared/ui/player/metrics/StatsForNerdsViewModel.kt Outdated Show resolved Hide resolved

MGaetan89 added 6 commits

August 12, 2024 14:25


          Dispaly metrics inside the demo apps

9ec3ba6


          Address Lint warnings

54e52b8


          Make sure to only store at most CHART_MAX_POINTS points for each chart

0906ed2


          Properly format the playback duration

07c4b5e


          Fix unit conversion


          Update charts color

e64536d

MGaetan89 force-pushed the 664-display-metrics-chart-inside-the-demo branch from 7465df6 to e64536d Compare

August 12, 2024 12:27

StaehliJ approved these changes

View reviewed changes

StaehliJ merged commit 5e3b275 into qos

StaehliJ deleted the 664-display-metrics-chart-inside-the-demo branch

August 12, 2024 14:34

MGaetan89 added a commit that referenced this pull request


          Create mobile screen for QoS (#670)

44590af

MGaetan89 added a commit that referenced this pull request


          Create mobile screen for QoS (#670)

c11d1be

MGaetan89 added a commit that referenced this pull request


          Create mobile screen for QoS (#670)

f6812b1

StaehliJ pushed a commit that referenced this pull request


          Create mobile screen for QoS (#670)

e0bb884

StaehliJ pushed a commit that referenced this pull request


          Create mobile screen for QoS (#670)

3fe4852

MGaetan89 added a commit that referenced this pull request


          Create mobile screen for QoS (#670)

f587721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet