Improve qos coordinator #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edec2a0 to
97338ca
Compare
97338ca to
f553433
Compare
Code Coverage
Files
|
MGaetan89
reviewed
Aug 15, 2024
pillarbox-player/src/test/java/ch/srgssr/pillarbox/player/qos/QosCoordinatorTest.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
The player position of the stop event after a item transition is wrong. The player position is the position of the next item (near 0ms). |
MGaetan89
approved these changes
Aug 16, 2024
Contributor
MGaetan89
left a comment
There was a problem hiding this comment.
Just a small question, otherwise good for me
Comment on lines
95
to
97
| override fun onSessionFinished(session: PlaybackSessionManager.Session) { | ||
| // Already handled by onMetricSessionFinished | ||
| } |
Contributor
There was a problem hiding this comment.
Why override it, then, since it has a default implementation?
Contributor
Author
There was a problem hiding this comment.
Because I like to write a lot of things, and to keep in mind that it is handled elsewhere. But I agree we could remove that.
MGaetan89
added a commit
that referenced
this pull request
Aug 20, 2024
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
StaehliJ
added a commit
that referenced
this pull request
Aug 28, 2024
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
StaehliJ
added a commit
that referenced
this pull request
Sep 11, 2024
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
MGaetan89
added a commit
that referenced
this pull request
Sep 12, 2024
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The goal of this PR is to improve
QoSCoordinator.Changes made
QoSEventDispatcheras it does nothing special.MetrcisCollectorcollect durations when an error occurs during loading.Checklist
mainbranch.