Release v1.17 by hypest · Pull Request #1566 · wordpress-mobile/gutenberg-mobile

hypest · 2019-11-11T10:00:48Z

Release for Gutenberg Mobile v1.17.0

Related PRs:

Gutenberg: [RNMobile] Native mobile release v1.17.0 WordPress/gutenberg#18426
WPAndroid: Gutenberg: Update to v1.17.0 WordPress-Android#10769
WPiOS: Gutenberg: Update to v1.17.0 WordPress-iOS#12917

Changes:

Add mobile Spacer component (in DEV mode) Add mobile Spacer component #1436
Activate Preformatted block 1264 - Activate Preformatted block #1442
Refactor: BottomSheet.RangeCell markup Refactor: BottomSheet.RangeCell markup #1471
Fix Aztec Android "SetSpan" ends beyond length on merging blocks Fix Aztec Android "SetSpan" ends beyond length on merging blocks #1507
Send backspace event to JS in more scenarios Send backspace event to JS in more scenarios #1517
Generate i18n files for WPAndroid and WPiOS to use Generate i18n files for WPAndroid and WPiOS to use #1520
shouldInteractWithURL will return always false to avoid crashes [Aztec iOS]: shouldInteractWithURL will return always false to avoid crashes #1523
Include the block title in unsupported blocks Include the block title in unsupported blocks #1533
Support copy of url in clipboard. Update GB reference to support copy of url in clipboard. #1537
Remove custom paragraph options for media-text Remove custom paragraph options for media-text #1538
Implement client-defined media options. [iOS] Implement client-defined media options. #1539
Show new block indicator in default appender too Show new block indicator in default appender too #1542
Media & Text alignment options Media & Text alignment options #1546
Update to latest version of GB master. Update to latest version of GB master. #1548
Update debug configuration for VSCode Update debug configuration for VSCode #1550
Prevents selection after ZWSP character Prevents selection after ZWSP character #1552
Fix paste in title Issue/fix paste in title #1575
Separate options for capturing photo and video Add separate options for capturing photo and video #1579
Fix Android crash when deleting some blocks Fix crash which occurs after deleting image or page break block #1582

Test plan

Please use the main WP apps to test the changes above. See WPAndroid and WPiOS PRs for a tests checklist.
Smoke test the main WP apps for general writing flow

Update release notes:

If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

Increment gb-mobile version to 1.14.0 Update bundle files

# Conflicts: # package.json

# Conflicts: # gutenberg

…pens_safari Don't allow interactions with URL in Aztec text blocks. # Conflicts: # gutenberg

…gutenberg-mobile into release/1.14.0

…witching to HTML mode

…issing-on-long-posts-in-html-mode

…Content-is-missing-on-long-posts-in-html-mode Fix/1268 content is missing on long posts in html mode

# Conflicts: # gutenberg

# Conflicts: # bundle/android/App.js # bundle/android/App.js.map # bundle/ios/App.js # bundle/ios/App.js.map # gutenberg # react-native-aztec/ios/Cartfile # react-native-aztec/ios/Cartfile.resolved # react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java

# Conflicts: # gutenberg

…ment_to_paragraphs Add content alignment options to paragraph block

…android-media-preview-activity

…image-preview-android-media-preview-activity Add native fullscreen image preview

…ordpress-mobile/gutenberg-mobile into fix/media-text-capture-options

…-options Add separate options for capturing photo and video

marecar3 · 2019-11-15T13:19:39Z

Let's make sure that this PR: #1582
gets merged.

hypest · 2019-11-15T18:28:04Z

I've tested the WPAndroid and WPiOS PRs and this looks good to me 👍!

marecar3 · 2019-11-15T19:14:47Z

Hey, @hypest @mchowning and @cameronvoell WPAndroid look nice, but I have found some regressions.

Image upload (visual) regression - when a placeholder is presented on the end of upload (when the progress is 100%), the progress bar is on the bottom of the placeholder and it should be on top of the placeholder.

Video upload (visual) regression - when the upload is in progress placeholder isn't good as a background is missing and also image in the center should be bigger (similar to the image placeholder)

It seems that they aren't blockers for a merge 🤔

mchowning · 2019-11-15T19:23:27Z

Nice catches @marecar3 !

Image upload (visual) regression - when a placeholder is presented on the end of upload (when the progress is 100%), the progress bar is on the bottom of the placeholder and it should be on top of the placeholder.

I see this as well on both platforms. It does look like a regression.

Video upload (visual) regression - when the upload is in progress placeholder isn't good as a background is missing and also image in the center should be bigger (similar to the image placeholder)

I'm not as certain about this one as @iamthomasbishop recently opened an issue saying that the image placeholder icon is too big and that it looks like the video block has the proper styling. We should probably get his feedback before doing any changes on this (for the next release).

It seems that they aren't blockers for a merge 🤔

I think that's right. I don't see any reason either of these should block the release.

iamthomasbishop · 2019-11-15T20:42:03Z

I'm not as certain about this one as @iamthomasbishop recently opened an issue saying that the image placeholder icon is too big and that it looks like the video block has the proper styling. We should probably get his feedback before doing any changes on this (for the next release).

Yes, you're right, the image block's placeholder icon is incorrect – video uses the proper style.

mchowning

Tested via both WPAndroid and WPiOS and everything looks good.

mchowning · 2019-11-15T22:54:43Z

Updated from 9c19f9c to bd25fb8 because I was getting a different bundle when building it locally. Looks like that was just because bundles include references to the local environment, so reverted back to 9c19f9c.

marecar3 and others added 30 commits September 30, 2019 13:14

Point to gutenberg master

3182479

Increment gb-mobile version to 1.14.0 Update bundle files

Point to the latest well known gb master ref

fca1431

Update bundle

11299f2

Merge branch 'develop' into release/1.14.0

e8d7a93

# Conflicts: # package.json

Update gutenberg ref to the latest rnmobile/release-1.14.0

0444ba3

Update GB reference.

b006c72

Merge branch 'develop' into release/1.14.0

c74358f

# Conflicts: # gutenberg

Merge pull request #1375 from wordpress-mobile/issue/1373_tap_links_o…

7a6dd6c

…pens_safari Don't allow interactions with URL in Aztec text blocks. # Conflicts: # gutenberg

Merge branch 'release/1.14.0' of https://github.com/wordpress-mobile/…

7a412c8

…gutenberg-mobile into release/1.14.0

Update bundle

27274dd

Update GB reference.

1696ab5

Update bundle

67c433e

Update GB reference to fix Header issues.

b84453d

Update bundle

b01446d

Android 8 only: Set View.LAYER_TYPE_SOFTWARE on mReactRootView when s…

93540d0

…witching to HTML mode

Update release note

d049940

Increment aztec versio to 1.3.31

bb24d3f

Merge branch 'release/1.14.0' into issue/wp-android-1268_Content-is-m…

7c98591

…issing-on-long-posts-in-html-mode

Merge pull request #1401 from wordpress-mobile/issue/wp-android-1268_…

9dd2b2b

…Content-is-missing-on-long-posts-in-html-mode Fix/1268 content is missing on long posts in html mode

Update gutenberg ref

37a0c73

Update bundle

ad1ad78

Update gb reference

9afdaad

Update bundle

4aadd63

Update Aztec iOS to v1.10.1

ba606df

Update GB reference.

9113230

Merge branch 'release/1.14.0' into issue/1264_activate_pre_format_block

a3a25d4

# Conflicts: # gutenberg

Update Aztec.

62ba15e

Use new functionality in Aztec to replace/update fonts

c6116a0

Merge branch 'develop' into issue/1264_activate_pre_format_block

906ea9b

# Conflicts: # gutenberg

hypest and others added 18 commits November 14, 2019 16:27

Update Gutenberg ref to the merged one

75c0d4e

Merge pull request #1489 from wordpress-mobile/1266_add_content_align…

e1cf16c

…ment_to_paragraphs Add content alignment options to paragraph block

Update Gutenberg to the merged ref

53743da

Update gutenberg reference

03f4537

Merge branch 'release/1.17' into add/mobile-fullscreen-image-preview-…

cbad167

…android-media-preview-activity

Restore the Gutenberg repo ref

c8cee10

Revert JS bundles, we'll build them on the release branch

9ef651b

Merge pull request #1577 from wordpress-mobile/add/mobile-fullscreen-…

1c0bfce

…image-preview-android-media-preview-activity Add native fullscreen image preview

Update JS bundles

58dd33e

Update gutenberg ref

4d91b76

Update gutenberg ref

13153da

Update gutenberg reference

8b23e3b

Merge branch 'release/1.17' into fix/media-text-capture-options

bb2bec3

Update gutenberg ref

058fea9

Merge branch 'fix/media-text-capture-options' of https://github.com/w…

a6ffdbb

…ordpress-mobile/gutenberg-mobile into fix/media-text-capture-options

Merge pull request #1579 from wordpress-mobile/fix/media-text-capture…

6c9d52e

…-options Add separate options for capturing photo and video

Update Gutenberg hash

85a7365

Update JS bundles

2a80ab2

marecar3 added 2 commits November 15, 2019 16:38

Fix crash which occurs after deleting image or page break block (#1582)

77ffeea

Update bundle files

9c19f9c

mchowning approved these changes Nov 15, 2019

View reviewed changes

mchowning force-pushed the release/1.17 branch from bd25fb8 to 9c19f9c Compare November 15, 2019 22:51

mchowning merged commit c6d095e into master Nov 15, 2019

marecar3 deleted the release/1.17 branch March 20, 2020 09:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v1.17#1566

Release v1.17#1566
mchowning merged 239 commits intomasterfrom
release/1.17

hypest commented Nov 11, 2019 •

edited

Loading

Uh oh!

marecar3 commented Nov 15, 2019

Uh oh!

hypest commented Nov 15, 2019

Uh oh!

marecar3 commented Nov 15, 2019 •

edited

Loading

Uh oh!

mchowning commented Nov 15, 2019 •

edited

Loading

Uh oh!

iamthomasbishop commented Nov 15, 2019

Uh oh!

mchowning left a comment

Uh oh!

mchowning commented Nov 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Conversation

hypest commented Nov 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related PRs:

Changes:

Test plan

Uh oh!

marecar3 commented Nov 15, 2019

Uh oh!

hypest commented Nov 15, 2019

Uh oh!

marecar3 commented Nov 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mchowning commented Nov 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamthomasbishop commented Nov 15, 2019

Uh oh!

mchowning left a comment

Choose a reason for hiding this comment

Uh oh!

mchowning commented Nov 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

hypest commented Nov 11, 2019 •

edited

Loading

marecar3 commented Nov 15, 2019 •

edited

Loading

mchowning commented Nov 15, 2019 •

edited

Loading