Skip to content

Update GB reference to support copy of url in clipboard.#1537

Merged
hypest merged 9 commits intodevelopfrom
issue/680_link_prefill_url_from_clipboard
Nov 6, 2019
Merged

Update GB reference to support copy of url in clipboard.#1537
hypest merged 9 commits intodevelopfrom
issue/680_link_prefill_url_from_clipboard

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Nov 4, 2019 •
edited
Loading

Fixes #680

GB PR: WordPress/gutenberg#18279

To test:

  • Start the demo app
  • Switch to Safari and copy a link from the url bar
  • Switch to GB demo app
  • Select a text block
  • Select a bit of text
  • Tap on the link button
  • Check that the URL that you copied from Safari is added to the URL field in the link modal
  • Edit an already existing link and check that the link in the clipboard does not override the one already existing.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@SergioEstevao SergioEstevao added the Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile label Nov 4, 2019
@SergioEstevao SergioEstevao added this to the 1.17 milestone Nov 4, 2019
@SergioEstevao SergioEstevao requested review from hypest and koke November 4, 2019 21:42
@SergioEstevao SergioEstevao mentioned this pull request Nov 4, 2019
Merged
5 tasks
hypest
hypest reviewed Nov 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm, both on Android and iOS!

Let's make sure the checkbox in the PR descriptions are considered and marked before merging these PRs, thanks!

@SergioEstevao
Copy link
Copy Markdown
Contributor Author

SergioEstevao commented Nov 5, 2019

@hypest PR update with release notes, do you mind give it another look.

hypest
hypest approved these changes Nov 6, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hypest hypest merged commit e49f509 into develop Nov 6, 2019
@hypest hypest deleted the issue/680_link_prefill_url_from_clipboard branch November 6, 2019 11:46
This was referenced Nov 11, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koke koke Awaiting requested review from koke

1 more reviewer

@hypest hypest hypest approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile

Projects

None yet

Milestone

1.17

Development

Successfully merging this pull request may close these issues.

Proposal: Autofill link URL field with link in clipboard

2 participants

@SergioEstevao @hypest