Fix Aztec Android "SetSpan" ends beyond length on merging blocks#1507
Merged
daniloercoli merged 4 commits intodevelopfrom Nov 5, 2019
Merged
Conversation
5 tasks
…rg-mobile into issue/AztecAndroid-IndexOutOfBoundsException-setSpan * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (50 commits) Update issue templates Update gutenberg ref Update gutenberg ref Update issue templates Update GB ref to point to official 1.16.0 tag Update RELEASE-NOTES.txt Update JS bundles Update GB ref Update app bundles Update GB reference. [Aztec iOS]: `shouldInteractWith` will return always true to avoid crashes [Aztec iOS] Cleanup white spaces. Update bundles. Update version to 1.6.0 Updated bundles Force translation update when generating new bundles Update gutenberg ref 720-Add support for giphy and pexel images (#1469) Update bundles Update gutenberg ref ... # Conflicts: # gutenberg
Contributor
|
While this PR solves some problems after this was merge I'm seeing the following issues:
|
1 task
This was referenced Nov 11, 2019
Merged
6 tasks
6 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does fix a sub-case of #872 and wordpress-mobile/WordPress-Android#9832 where the editor crashes on merging 2 blocks when the first block does have BR tag(s) at the end of its content.
GB side PR: WordPress/gutenberg#18138
To test:
Note, we should test this PR with tons of input since the changes in Aztec may break other part of the GB-Editor.
Plussymbol to add a new block below the paraAlso try many other testing scenarios.
cc @SergioEstevao
Update release notes:
RELEASE-NOTES.txt.