Send backspace event to JS in more scenarios#1517
Merged
SergioEstevao merged 2 commits intodevelopfrom Nov 5, 2019
Merged
Conversation
Sending the backspace when the last character is being deleted and when all the text is being deleted.
# Conflicts: # react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
This was referenced Nov 11, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1519
On this PR we are sending the backspace when the last character is being deleted and
when all the text is being deleted.
This improves our handling of list blocks when all content is deleted.
To test:
Update release notes:
RELEASE-NOTES.txt.