Skip to content

Send backspace event to JS in more scenarios#1517

Merged
SergioEstevao merged 2 commits intodevelopfrom
issue/fix_full_content_deletion
Nov 5, 2019
Merged

Send backspace event to JS in more scenarios#1517
SergioEstevao merged 2 commits intodevelopfrom
issue/fix_full_content_deletion

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Oct 30, 2019

Fixes: #1519

On this PR we are sending the backspace when the last character is being deleted and
when all the text is being deleted.

This improves our handling of list blocks when all content is deleted.

To test:

  • Add a new list block
  • Insert some lines
  • Delete all content by selecting all the content
  • Check that the placeholder content shows properly
  • Write some characters
  • Delete them one by one
  • Check that when all are deleted the placeholder shows properly.
  • Check the same behaviour on the other text blocks( paragraph, heading, blockquote)

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

Sending the backspace when the last character is being deleted and
when all the text is being deleted.
@SergioEstevao SergioEstevao added this to the 1.16 milestone Oct 30, 2019
@hypest hypest modified the milestones: 1.16, 1.17 Nov 1, 2019
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested #1519 and the testing steps provided and it works well 🎉

Also tested many block merges and text deletion scenarios ✅

# Conflicts:
#	react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS] Merging two paragraphs needs two backspaces to complete

3 participants