Add native fullscreen image preview#1577
Merged
hypest merged 13 commits intorelease/1.17from Nov 14, 2019
Merged
Conversation
…y for fullscreen preview on Android
… Android Native side.
…android-media-preview-activity
6 tasks
… while image is uploading or failed to upload.
hypest
approved these changes
Nov 14, 2019
Contributor
hypest
left a comment
There was a problem hiding this comment.
LGTM!
Tested it on WPAndroid (works great!) and WPiOS (not bringing up any fullscreen image preview there, as expected)
I will start updating and merging the PRs.
cameronvoell
commented
Nov 14, 2019
| [submodule "gutenberg"] | ||
| path = gutenberg | ||
| url = ../../cameronvoell/gutenberg.git | ||
| url = ../../WordPress/gutenberg.git |
Contributor
Author
There was a problem hiding this comment.
thanks for updating this!
Contributor
There was a problem hiding this comment.
The failing CI jobs helped me remember it 😆
This was referenced Nov 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1286
This PR adds a native method call for fullscreen image previews, for now Android only.
Related PRs:
To test:
To test on Android refer to WPAndroid PR: wordpress-mobile/WordPress-Android#10714
*Note this branch is pointing to cameronvoell gutenberg repo until WordPress/gutenberg#18493 is merged. ✅ Done c8cee10.
Update release notes:
RELEASE-NOTES.txt.