Skip to content

Gutenberg: Update to v1.17.0#12917

Merged
cameronvoell merged 37 commits intodevelopfrom
gutenberg/release-1.17.0
Nov 15, 2019
Merged

Gutenberg: Update to v1.17.0#12917
cameronvoell merged 37 commits intodevelopfrom
gutenberg/release-1.17.0

Conversation

@hypest
Copy link
Copy Markdown
Contributor

@hypest hypest commented Nov 11, 2019

This PR updates Gutenberg to v1.15.0
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1566

To test:

Please copy the following checklist into a new comment and mark each test with ✅, ⚠️ or ❌ based on your test result. Check the individual PR for testing steps.

⏳ Activate Preformatted block wordpress-mobile/gutenberg-mobile#1442
⏳ Send backspace event to JS in more scenarios wordpress-mobile/gutenberg-mobile#1517
⏳ Generate i18n files for WPAndroid and WPiOS to use wordpress-mobile/gutenberg-mobile#1520
shouldInteractWithURL will return always false to avoid crashes wordpress-mobile/gutenberg-mobile#1523
⏳ Include the block title in unsupported blocks wordpress-mobile/gutenberg-mobile#1533
⏳ Support copy of url in clipboard. wordpress-mobile/gutenberg-mobile#1537
⏳ Remove custom paragraph options for media-text wordpress-mobile/gutenberg-mobile#1538
⏳ Implement client-defined media options. wordpress-mobile/gutenberg-mobile#1539
⏳ Show new block indicator in default appender too wordpress-mobile/gutenberg-mobile#1542
⏳ Media & Text alignment options wordpress-mobile/gutenberg-mobile#1546
⏳ Prevents selection after ZWSP character wordpress-mobile/gutenberg-mobile#1552
⏳ Fix paste in title wordpress-mobile/gutenberg-mobile#1575

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hypest hypest added the Gutenberg Editing and display of Gutenberg blocks. label Nov 11, 2019
@hypest hypest added this to the 13.7 milestone Nov 11, 2019
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Nov 11, 2019

You can trigger an installable build for these changes by visiting CircleCI here.

@hypest hypest added Gutenberg Editing and display of Gutenberg blocks. and removed Gutenberg Editing and display of Gutenberg blocks. labels Nov 11, 2019
@hypest hypest marked this pull request as ready for review November 12, 2019 08:10
@hypest hypest requested review from Tug and daniloercoli November 12, 2019 08:10
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Nov 12, 2019

Warnings
⚠️ Localizable.strings should only be updated on release branches because it is generated automatically.

Generated by 🚫 dangerJS

@hypest hypest added Gutenberg Editing and display of Gutenberg blocks. and removed Gutenberg Editing and display of Gutenberg blocks. labels Nov 13, 2019
…ormated_block

Enable Preformatted block in Gutenberg.
@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Nov 15, 2019

Tested:

✅ Send backspace event to JS in more scenarios wordpress-mobile/gutenberg-mobile#1517
✅ Include the block title in unsupported blocks wordpress-mobile/gutenberg-mobile#1533
✅ Support copy of url in clipboard. wordpress-mobile/gutenberg-mobile#1537
✅ Implement client-defined media options. wordpress-mobile/gutenberg-mobile#1539
✅ Show new block indicator in default appender too wordpress-mobile/gutenberg-mobile#1542
✅ Media & Text alignment options wordpress-mobile/gutenberg-mobile#1546
✅ Prevents selection after ZWSP character wordpress-mobile/gutenberg-mobile#1552
✅ Fix paste in title wordpress-mobile/gutenberg-mobile#1575

Copy link
Copy Markdown
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all the changes and did some general smoke testing. Everything looks good!

@etoledom
Copy link
Copy Markdown
Contributor

✅ Activate Preformatted block wordpress-mobile/gutenberg-mobile#1442

  • Found an edge case: Merging a para block into a preformatted block, the new lines on the preformatted block are lost. This also happens on Web.

✅ Send backspace event to JS in more scenarios wordpress-mobile/gutenberg-mobile#1517
shouldInteractWithURL will return always false to avoid crashes wordpress-mobile/gutenberg-mobile#1523
✅ Include the block title in unsupported blocks wordpress-mobile/gutenberg-mobile#1533
✅ Support copy of url in clipboard. wordpress-mobile/gutenberg-mobile#1537
✅ Remove custom paragraph options for media-text wordpress-mobile/gutenberg-mobile#1538
✅ Implement client-defined media options. wordpress-mobile/gutenberg-mobile#1539
✅ Show new block indicator in default appender too wordpress-mobile/gutenberg-mobile#1542
✅ Media & Text alignment options wordpress-mobile/gutenberg-mobile#1546
✅ Prevents selection after ZWSP character wordpress-mobile/gutenberg-mobile#1552
✅ Fix paste in title wordpress-mobile/gutenberg-mobile#1575

Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cameronvoell cameronvoell merged commit 9bdcc4d into develop Nov 15, 2019
@SergioEstevao SergioEstevao deleted the gutenberg/release-1.17.0 branch May 11, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants