Skip to content

Update Aztec-Editor to 1.12 and add block editor paragraph alignment#12929

Merged
hypest merged 10 commits intogutenberg/release-1.17.0from
update_aztec_editor
Nov 14, 2019
Merged

Update Aztec-Editor to 1.12 and add block editor paragraph alignment#12929
hypest merged 10 commits intogutenberg/release-1.17.0from
update_aztec_editor

Conversation

@mchowning
Copy link
Copy Markdown
Contributor

@mchowning mchowning commented Nov 12, 2019

This updates the AztecEditor to version 1.12 and brings in the changes for paragraph alignment that needed that update.

To test:

  • Smoke test of Aztec Editor
  • Check paragraph alignment behavior in gutenberg editor (previously this issue was observed and filed, but I'm actually not seeing that issue anymore, cc: @SergioEstevao )
  • Check background color appearance in quote blocks

TODO

Update release notes

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Adds paragraph alignment for block editor
@mchowning mchowning added Aztec Gutenberg Editing and display of Gutenberg blocks. labels Nov 12, 2019
@mchowning mchowning added this to the 13.7 milestone Nov 12, 2019
@mchowning mchowning self-assigned this Nov 12, 2019
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Nov 12, 2019

You can trigger an installable build for these changes by visiting CircleCI here.

@mchowning
Copy link
Copy Markdown
Contributor Author

mchowning commented Nov 12, 2019

With @SergioEstevao 's update to the AztecEditor, I needed to add a default color for the blockquote background color. Although my change looked fine to me, I'm not especially confident that the color I picked is the best option. It's worth having a particularly skeptical look at those changes.

@SergioEstevao
Copy link
Copy Markdown
Contributor

SergioEstevao commented Nov 12, 2019

@mchowning I hope you don't mind but I updated the colors values in your PR to set the quote and pre backgrounds. Here is how it looks now:

AztecPreQuote

cc @iamthomasbishop

@iamthomasbishop
Copy link
Copy Markdown

@SergioEstevao Are we using system grays in Aztec? I would probably use a lighter gray on light mode, but I think dark mode looks fine.

I'm curious which specific colors we are using here for blockquote/pre – in light mode and dark mode?

@SergioEstevao
Copy link
Copy Markdown
Contributor

I'm curious which specific colors we are using here for blockquote/pre – in light mode and dark mode?

We are using the new Muriel pallete
so for quote we are using .shade(5)/.shade(90) - gray5 and gray90
and fore pre we are using .shade(10)/.shade(80)- gray10 and gray80

@iamthomasbishop
Copy link
Copy Markdown

Ah, ok – the screenshot's colors looked slightly different from the current values on Color Studio, so maybe it's just a color profile thing in the screenshot.

We can just use the same backgound color for both pre and quote. So in other words, gray 5 in light mode and gray 90 in dark mode.

image

# Conflicts:
#	Podfile
#	Podfile.lock
#	WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift
#	WordPress/WordPressShareExtension/ShareExtensionEditorViewController.swift
@SergioEstevao
Copy link
Copy Markdown
Contributor

@iamthomasbishop update the color in pre to be the same in quote.

The issue with the screenshots it's because I have True Tone activated on my laptop. It messes the colors a bit.

Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go.

@hypest hypest added Gutenberg Editing and display of Gutenberg blocks. and removed Gutenberg Editing and display of Gutenberg blocks. labels Nov 14, 2019
@hypest hypest merged commit a2e6327 into gutenberg/release-1.17.0 Nov 14, 2019
@hypest hypest deleted the update_aztec_editor branch November 14, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Aztec Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants