Add content alignment options to paragraph block#1489
Conversation
|
This is working pretty good but I found two edge cases were it's failing:
|
|
Thanks for the review @SergioEstevao !
This doesn't seem to be happening for me. 🤔 I thought it might be a device/os-specific issue, but I've tried on a few different devices (physical iPhone Xr w/iOS 13, and simulators with iOS 12 & 11). What device and os are you using? Any unusual steps to reproduce?
Good catch! I didn't notice the missing third period, but I see it now that you've pointed it out. I'll look into it. |
I've pushed a fix for this in the latest commit. Would be great if @etoledom could give that commit a look since it is tweaking some code he wrote for handling RTL. For that reason, any testing of my changes should be sure to check that RTL is handled appropriately (I tested RTL on iOS with Run Options -> Application Language: Right-To-Left Pseudolanguage). In particular, keep an eye out that when an empty paragraph block is selected the cursor is appropriately positioned relative to the placeholder text. |
marecar3
left a comment
There was a problem hiding this comment.
Nice work @mchowning!
LGTM!
|
@mchowning here is a video of the first bug I mentioned: |
|
Thanks for the video @SergioEstevao ! Here are the steps to reproduce I'm seeing and some notes. I've spent some time digging into this and I am stumped so far. I'm not that familiar with Aztec-iOS, so please let me know if you have any suggestions on what I might want to investigate @SergioEstevao . As an alternative, what would you think about opening a new issue for this and merging this as-is since it seems like this probably will not occur very often, and when it does occur it is not too difficult to recover alignment by just updating the alignment once text has been added?
|
SergioEstevao
left a comment
There was a problem hiding this comment.
@mchowning ok lets approve this to move it forward.
Please open a ticket for the issue I found, in order for us to fix/track in the near future.
|
Remember to update the release notes to say this change is landing on release 1.17.0 |
b0e9307 to
fb5c799
Compare
Insures the placeholder is properly positioned when "end" alignment (i.e., right in LTR languages and left in RTL languages) is applied.
0825708 to
4cb36ac
Compare
hypest
left a comment
There was a problem hiding this comment.
LGTM!
Tested both on WPAndroid an WPiOS and is working nicely! 😍



Fixes #1266 . Further details available in the related gutenberg PR. Newer Gutenberg PR that targets the 1.17 release: WordPress/gutenberg#18433
Because this includes an update to the AztecEditor-iOS version, merging this also needs to be coordinated with merging that update into WPiOS: wordpress-mobile/WordPress-iOS#12929
Release Notes
RELEASE-NOTES.txt.