Skip to content

[Aztec iOS]: shouldInteractWithURL will return always false to avoid crashes#1523

Merged
etoledom merged 2 commits intodevelopfrom
issue/interact-with-url-crash
Nov 4, 2019
Merged

[Aztec iOS]: shouldInteractWithURL will return always false to avoid crashes#1523
etoledom merged 2 commits intodevelopfrom
issue/interact-with-url-crash

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

Fixes wordpress-mobile/WordPress-iOS#12730

Gutenberg counterpart of wordpress-mobile/WordPress-iOS#12798

Since iOS 13.0 is so low on adoption, I believe is better to keep the simpler fix, regardless of the UX issue on 13.0, avoiding possible crashes.

  • Took the chance to clean up some extra white-spaces on RCTAztecView.swift

To test:

  • Tap/select text with links.
  • Check that the links are not open in a browser and the text selection works.
  • Check that the app doesn't crash.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@etoledom etoledom added [Type] Enhancement Improves a current area of the editor [OS] iOS labels Oct 31, 2019
@etoledom etoledom added this to the 1.17 milestone Oct 31, 2019
@etoledom etoledom self-assigned this Oct 31, 2019
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[OS] iOS [Type] Enhancement Improves a current area of the editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EXC_BREAKPOINT: textView:shouldInteractWithURL:inRange:interaction:

2 participants