Aztec: shouldInteractWithURL will return always false to avoid crashes#12798
Merged
Aztec: shouldInteractWithURL will return always false to avoid crashes#12798
shouldInteractWithURL will return always false to avoid crashes#12798Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
0580e21 to
888a516
Compare
Contributor
Author
|
Thank you @SergioEstevao ! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12730
Following up from #12772.
I agree with @koke on #12772 (comment).
Since iOS 13.0 is so low on adoption, I believe is better to keep the simpler fix, regardless of the UX issue on 13.0, avoiding possible crashes.
I will do the gutenberg side changes next, but will probably go live on WPiOS 13.6.
To test:
Update release notes:
RELEASE-NOTES.txtif necessary.