Do full link selection fix only on 13.0#12772
Merged
SergioEstevao merged 1 commit intorelease/13.5from Oct 28, 2019
Merged
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
etoledom
approved these changes
Oct 28, 2019
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Works well on iOS 13.1 🎉
Note: Couldn't test on 13.0.
Contributor
|
I tested with |
Member
|
Sorry I got to this one late, but I'm still not sure about this fix. The original crash was also happening on 13.0, so this won't fix the crash for those users. I still think it's better to avoid the crash (which could lead to content loss in an editor context) rather than avoid a link UX bug. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12626
To test:
Update release notes:
RELEASE-NOTES.txtif necessary.