Show new block indicator in default appender too#1542
Merged
Conversation
mchowning
approved these changes
Nov 5, 2019
This was referenced Nov 11, 2019
Merged
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #632
Addresses the subcase in #632 where the new-block indicator wasn't shown when the block list was empty and not interacted with yet.
Also, showing the indicator when at the last block of the list.
Gutenberg PR: WordPress/gutenberg#18289
To test:
initial-html.jsfile to have an empty block listTo test 2:
initial-html.jsfile to have an empty block listUpdate release notes:
RELEASE-NOTES.txt.