Show new block indicator in default appender too#18289
Merged
Conversation
1 task
mchowning
reviewed
Nov 5, 2019
mchowning
reviewed
Nov 5, 2019
mchowning
approved these changes
Nov 5, 2019
Contributor
mchowning
left a comment
There was a problem hiding this comment.
Looks good and works well! I really like the explanatory comments you added. 🎉
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Showing the "ADD BLOCK HERE" block insertion point indicator when the block list is fully empty too. Also, at the end of the list when not empty
Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1542
How has this been tested?
Using the gutenberg-mobile PR.
Types of changes
Checklist: