Skip to content

[Gutenberg] Implement "Other Apps" media source option#12883

Merged
etoledom merged 7 commits intogutenberg/release-1.17.0from
gutenberg/other-apps-media-option
Nov 14, 2019
Merged

[Gutenberg] Implement "Other Apps" media source option#12883
etoledom merged 7 commits intogutenberg/release-1.17.0from
gutenberg/other-apps-media-option

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Nov 6, 2019

Fixes wordpress-mobile/gutenberg-mobile#1265

This PR adds the option to select media items from the iOS Files App via "Other Apps" option.

This works for all media related blocks, and the user should be allowed to pick just the corresponding media types for the blocks.

For this to work, the filters property was needed from JS, but it wasn't given via requestOtherMediaPick methods. The gutenberg side changes are meant to allow this property to be passed on any requestMediaPick for any source.

gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1547
gutenberg PR: WordPress/gutenberg#18303

other_apps

Note:

  • As shown in the GIF, there seems to be a bug on iOS 13 where the bar buttons on the Documents Picker are not visible. This is also the case for Aztec and WPMediaLibrary instances.
    I have decided to not fix this on this particular PR.

To Test:

Image Block:

  • Add an Image block.
  • Check that the "Other Apps" option is there.
  • Open the "Other Apps" picker.
  • Check that only images are selectable.
  • Choose one image.
  • Check that the selected image is added to the block.
  • Smoke-test other source options.

Video Block:

  • Add a Video block.
  • Check that the "Other Apps" option is there.
  • Open the "Other Apps" picker.
  • Check that only videos are selectable.
  • Choose one video.
  • Check that the selected video is added to the block.
  • Smoke-test other source options.

Media&Text:

  • Add an Media&Text block.
  • Check that the "Other Apps" option is there.
  • Open the "Other Apps" picker.
  • Check that you can select only images and videos.
  • Choose one image or video.
  • Check that the image or video selected was added.
  • Smoke-test other source options.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Nov 6, 2019
@etoledom etoledom added this to the 13.7 milestone Nov 6, 2019
@etoledom etoledom self-assigned this Nov 6, 2019
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Nov 6, 2019

You can trigger an installable build for these changes by visiting CircleCI here.

@etoledom etoledom added Gutenberg Editing and display of Gutenberg blocks. and removed Gutenberg Editing and display of Gutenberg blocks. labels Nov 6, 2019
@etoledom etoledom marked this pull request as ready for review November 6, 2019 10:40
@etoledom etoledom force-pushed the gutenberg/other-apps-media-option branch from d062ed3 to c112e77 Compare November 8, 2019 08:06
@etoledom etoledom changed the base branch from gutenberg/free-media-library to develop November 8, 2019 08:07
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all scenarios and working great.

@etoledom etoledom force-pushed the gutenberg/other-apps-media-option branch from a82f78e to f996fc0 Compare November 14, 2019 09:46
@etoledom etoledom changed the base branch from develop to gutenberg/release-1.17.0 November 14, 2019 09:46
@etoledom etoledom added Gutenberg Editing and display of Gutenberg blocks. and removed Gutenberg Editing and display of Gutenberg blocks. labels Nov 14, 2019
@SergioEstevao SergioEstevao self-requested a review November 14, 2019 10:43
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants