[Gutenberg] Implement "Other Apps" media source option#12883
Merged
etoledom merged 7 commits intogutenberg/release-1.17.0from Nov 14, 2019
Merged
[Gutenberg] Implement "Other Apps" media source option#12883etoledom merged 7 commits intogutenberg/release-1.17.0from
etoledom merged 7 commits intogutenberg/release-1.17.0from
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
This was referenced Nov 6, 2019
d062ed3 to
c112e77
Compare
SergioEstevao
approved these changes
Nov 8, 2019
Contributor
SergioEstevao
left a comment
There was a problem hiding this comment.
Tested all scenarios and working great.
a82f78e to
f996fc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#1265
This PR adds the option to select media items from the iOS Files App via "Other Apps" option.
This works for all media related blocks, and the user should be allowed to pick just the corresponding media types for the blocks.
For this to work, the
filtersproperty was needed from JS, but it wasn't given viarequestOtherMediaPickmethods. Thegutenbergside changes are meant to allow this property to be passed on anyrequestMediaPickfor any source.gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#1547gutenbergPR: WordPress/gutenberg#18303Note:
I have decided to not fix this on this particular PR.
To Test:
gutenberg-mobilePR and Run Metro server.Image Block:
Video Block:
Media&Text:
Update release notes:
RELEASE-NOTES.txtif necessary.