Simplify bridge requestMediaPick methods#1547
Merged
etoledom merged 13 commits intorelease/1.17from Nov 14, 2019
Merged
Conversation
1 task
Update gutenberg ref.
587a51b to
af001b9
Compare
…-media-pick-methods-from-bridge
…extra-media-pick-methods-from-bridge
etoledom
commented
Nov 13, 2019
Comment on lines
+13
to
+17
| export const mediaSources = { | ||
| deviceLibrary: 'DEVICE_MEDIA_LIBRARY', | ||
| deviceCamera: 'DEVICE_CAMERA', | ||
| siteMediaLibrary: 'SITE_MEDIA_LIBRARY', | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
@SergioEstevao - I decided to declare the media source constants bundled in an object.
Anyway, at some point we will probably move all this to the parent apps.
Contributor
|
@etoledom tested it again in iOS and Android all looks good! |
marecar3
approved these changes
Nov 14, 2019
Contributor
marecar3
left a comment
There was a problem hiding this comment.
Tested all scenarios on Android device, nice work!
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies and merges all
requestMediaPick...methods into onerequestMediaPick, including the newrequestOtherMediaPickFrommethod.This allow us to handle media pick request from any source in the same way, and giving the same parameters.
Passing the filter parameter to
requestOtherMediaPickFromwas needed for wordpress-mobile/WordPress-iOS#12883 to work properly, so I decided to do this extra enhancement.This will probably break the WPAndroid integration of
Free Photo Library. (cc @marecar3 )This is also a good step forward to move all media source definitions to the client side.
gutenbergside PR: WordPress/gutenberg#18303WPiOSPR: wordpress-mobile/WordPress-iOS#12883cc @pinarol
To test:
WPiOSPR.Update release notes:
RELEASE-NOTES.txt.