Skip to content

Refactor: BottomSheet.RangeCell markup #1471

Merged
jbinda merged 13 commits intodevelopfrom
callstack/range-control-markup
Nov 6, 2019
Merged

Refactor: BottomSheet.RangeCell markup #1471
jbinda merged 13 commits intodevelopfrom
callstack/range-control-markup

Conversation

@jbinda
Copy link
Copy Markdown
Contributor

@jbinda jbinda commented Oct 20, 2019

Fixes #1449

Please also refer to:
Related gutenberg PR
Related gutenberg-mobile issue

It presents:
New layer on top of BottomSheet.RangeCell to use slider in the same way as in web version.

To test:

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@jbinda jbinda added [Type] Enhancement Improves a current area of the editor [Status] Not Ready For Review labels Oct 20, 2019
@jbinda jbinda self-assigned this Oct 20, 2019
Copy link
Copy Markdown
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested as described here

@jbinda jbinda merged commit ab61350 into develop Nov 6, 2019
@jbinda
Copy link
Copy Markdown
Contributor Author

jbinda commented Nov 6, 2019

merged ! 🎉

@hypest hypest mentioned this pull request Nov 11, 2019
4 tasks
@jbinda jbinda deleted the callstack/range-control-markup branch March 16, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make BottomSheet.RangeCell control markup consistent with web usage

2 participants