Skip to content

Update to latest version of GB master.#1548

Merged
hypest merged 1 commit intodevelopfrom
issue/update_to_latest_master_in_GB
Nov 6, 2019
Merged

Update to latest version of GB master.#1548
hypest merged 1 commit intodevelopfrom
issue/update_to_latest_master_in_GB

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Nov 6, 2019 •
edited by hypest
Loading

Update develop branch to have the latest version of GB master.

Includes #1507 too, for which the GB ref bump was missed somehow.
Also includes WordPress/gutenberg#17937, with which we hope we address wordpress-mobile/WordPress-iOS#11950.

To test:

  • Just smoke test the demo app to see if all is running.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@SergioEstevao SergioEstevao added this to the 1.17 milestone Nov 6, 2019
@SergioEstevao SergioEstevao requested a review from hypest November 6, 2019 12:54
@hypest
Copy link
Copy Markdown
Contributor

hypest commented Nov 6, 2019

👋 @SergioEstevao , do you perhaps have a scenario that we can trigger wordpress-mobile/WordPress-iOS#11950 (comment)? It'd be good to test it while in this PR since it includes the GB side fix (WordPress/gutenberg#17937).

@SergioEstevao
Copy link
Copy Markdown
Contributor Author

SergioEstevao commented Nov 6, 2019

So the one I detected was in my preformatted PR where a block used a RichText component and didn't set the 'identifier' prop to a correct value. When you tried to merge a block that didn't have the prop set you would get an exception.

But if all blocks have the identifier set properly I don't think you will be able to reproduce any longer.
Unless you remove the identifier in one of the blocks explicitly, for example in the paragraph block.

hypest
hypest approved these changes Nov 6, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

By the way, I updated the PR description to include a mention to Danilo's
PRand Ella's .multiline attribute fix, for future reference).

@hypest hypest merged commit 158ec72 into develop Nov 6, 2019
@hypest hypest deleted the issue/update_to_latest_master_in_GB branch November 6, 2019 13:25
This was referenced Nov 6, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hypest hypest hypest approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-process

Projects

None yet

Milestone

1.17

Development

Successfully merging this pull request may close these issues.

2 participants

@SergioEstevao @hypest