This repository was archived by the owner on Sep 30, 2024. It is now read-only.
remove many removed and unused fields from settings and site config schemas#46045
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 323638f...b082408.
|
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits b082408 and 45cd517 or learn more. Open explanation
|
5b790bd to
1df17d4
Compare
…chemas The intent of this commit is to only remove fields that are: - entirely ineffective (such as those documented with "REMOVED") - long-deprecated where the functionality is no longer present - deprecated and replaced with another property that has the same effect The intent is not to remove any fields that are in active use.
1df17d4 to
b082408
Compare
Contributor
|
Does this close the three issues mentioned here: https://github.com/sourcegraph/sourcegraph/discussions/45232#discussioncomment-4318274 ? |
Member
Author
Yes to the first 2, and I posted https://github.com/sourcegraph/sourcegraph/issues/44182#issuecomment-1369219243 on the 3rd. |
limitedmage
approved these changes
Jan 2, 2023
limitedmage
left a comment
Contributor
There was a problem hiding this comment.
This PR makes me soooo happy! Thank you!!
Member
Author
|
@limitedmage Yes, same here! 🎉 Thanks for the review! |
Contributor
|
ⓝⓘⓒⓔ! |
fkling
added a commit
that referenced
this pull request
Feb 22, 2023
…flags These flags have been removed in #46086 and #46045 but were accidentally(?) added back to the schema in (#46086). Furthermore the `showSearchContext` flag was still accessed in a couple of places, resulting in a broken experience if it was set to `false` (see screenshot). This PR removes the flags and removes all uses of `showSearchContext` flag.
fkling
added a commit
that referenced
this pull request
Feb 22, 2023
…flags (#47956) These flags have been removed in #46086 and #46045 but were accidentally (merge conflict?) added back to the schema in #46086. Furthermore the `showSearchContext` flag was still accessed in a couple of places, resulting in a broken experience if it was set to `false`. This PR removes the flags and removes all uses of `showSearchContext` flag. ## Test plan `grep`ed for the removed flags (`showSearchContext` is still used as props in various places though). Opened web app and verified that the context dropdown is properly populated.
fkling
added a commit
that referenced
this pull request
Feb 24, 2023
This flag had been removed in #46045 but (accidentally?) added back in #45705. The feature (search stats) itself been removed in #45996. Documentation about it has already been removed in #30564. The link removed in this PR has been dead since then. ## Test plan `grep`ped the code for references to the flag and used sourcegraph to find the commits that made changes to the related code and documentation.
fkling
added a commit
that referenced
this pull request
Mar 20, 2023
Originally I wanted to do properly pass in the `globbing` parameter but then I noticed that this feature had been removed for quite a while (#27886, #46045). But while working on this I noticed that the cursor is not properly scrolled into view when completing a long value. Adding `scrollIntoView` fixes that.
philipp-spiess
referenced
this pull request
Mar 20, 2023
As @fkling noticed in #49684, these option is no longer supported: - https://github.com/sourcegraph/sourcegraph/pull/27886 - https://github.com/sourcegraph/sourcegraph/pull/46045 Time to do some cleanup in the front end code!
fkling
added a commit
that referenced
this pull request
Mar 20, 2023
#49684) Originally I wanted to do properly pass in the `globbing` parameter but then I noticed that this feature had been removed for quite a while (#27886, #46045). But while working on this I noticed that the cursor is not properly scrolled into view when completing a long value. Adding `scrollIntoView` fixes that. ## Test plan Enter a long query into the input, type `file:` and select a long file suggestion. The input should scroll the cursor into view. ## App preview: - [Web](https://sg-web-fkling-search-input-globbing.onrender.com/search) Check out the [client app preview documentation](https://docs.sourcegraph.com/dev/how-to/client_pr_previews) to learn more.
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
#49684) Originally I wanted to do properly pass in the `globbing` parameter but then I noticed that this feature had been removed for quite a while (#27886, #46045). But while working on this I noticed that the cursor is not properly scrolled into view when completing a long value. Adding `scrollIntoView` fixes that. ## Test plan Enter a long query into the input, type `file:` and select a long file suggestion. The input should scroll the cursor into view. ## App preview: - [Web](https://sg-web-fkling-search-input-globbing.onrender.com/search) Check out the [client app preview documentation](https://docs.sourcegraph.com/dev/how-to/client_pr_previews) to learn more. (cherry picked from commit 87b738d)
fkling
added a commit
that referenced
this pull request
Mar 20, 2023
…after completion (#49689) Originally I wanted to do properly pass in the `globbing` parameter but then I noticed that this feature had been removed for quite a while (#27886, #46045). But while working on this I noticed that the cursor is not properly scrolled into view when completing a long value. Adding `scrollIntoView` fixes that. ## Test plan Enter a long query into the input, type `file:` and select a long file suggestion. The input should scroll the cursor into view. Co-authored-by: Felix Kling <felix@felix-kling.de>
philipp-spiess
referenced
this pull request
Mar 21, 2023
As @fkling noticed in #49684, these option is no longer supported: - https://github.com/sourcegraph/sourcegraph/pull/27886 - https://github.com/sourcegraph/sourcegraph/pull/46045 Time to do some cleanup in the front end code! Process: - Grep for `globbing` - Delete everything that is related to front end code ## Test plan - CI <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> ## App preview: - [Web](https://sg-web-ps-rm-globbing-from-frontend.onrender.com/search) Check out the [client app preview documentation](https://docs.sourcegraph.com/dev/how-to/client_pr_previews) to learn more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent of this commit is to only remove fields that are:
The intent is not to remove any fields that are in active use. As evidence of this, you can see that very little non-test, non-schema code was changed here.
This is a followup to https://github.com/sourcegraph/sourcegraph/pull/45995.
Test plan
The integration test suite will catch any issues.