This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search: clean up feature flags#46086
Merged
Merged
Conversation
camdencheek
approved these changes
Jan 3, 2023
5b16763 to
2841a2e
Compare
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff f178717...d1f2781.
|
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff f178717...d1f2781. No notifications. |
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits d1f2781 and 24297ed or learn more. Open explanation
|
0d41cfa to
396944b
Compare
fkling
referenced
this pull request
Feb 21, 2023
This PR consolidates notebook routes into a single component. I hope that doesn't interfere with the React router migration efforts. It makes it easier to integrate notebooks with the SvelteKit app and is also more in line with how other product areas are structured (e.g. insights, code monitors, ...). This also removes the use of `showSearchNotebooks`, which has been removed in https://github.com/sourcegraph/sourcegraph/pull/46086. (note: Adding people as reviewers who have better knowledge about react router than me) ## Test plan - When signed out I can see a list of public notebooks and open public notebooks - Going to `/notebooks/new` redirects to the notebooks list page - When signed in I see my own notebooks, can open my own notebooks and can create new notebooks.
fkling
added a commit
that referenced
this pull request
Feb 22, 2023
…flags These flags have been removed in #46086 and #46045 but were accidentally(?) added back to the schema in (#46086). Furthermore the `showSearchContext` flag was still accessed in a couple of places, resulting in a broken experience if it was set to `false` (see screenshot). This PR removes the flags and removes all uses of `showSearchContext` flag.
fkling
added a commit
that referenced
this pull request
Feb 22, 2023
…flags (#47956) These flags have been removed in #46086 and #46045 but were accidentally (merge conflict?) added back to the schema in #46086. Furthermore the `showSearchContext` flag was still accessed in a couple of places, resulting in a broken experience if it was set to `false`. This PR removes the flags and removes all uses of `showSearchContext` flag. ## Test plan `grep`ed for the removed flags (`showSearchContext` is still used as props in various places though). Opened web app and verified that the context dropdown is properly populated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove experimental feature flags for notebooks, code monitoring, and search contexts as these features have been enabled by default for a long time now.
Test plan
sg start oss.