This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feature flags: Clean up (and fix) deprectated search-related feature flags#47956
Merged
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 5f95a9b and d94a71c or learn more. Open explanation
|
79cb90d to
ea4fd57
Compare
…flags These flags have been removed in #46086 and #46045 but were accidentally(?) added back to the schema in (#46086). Furthermore the `showSearchContext` flag was still accessed in a couple of places, resulting in a broken experience if it was set to `false` (see screenshot). This PR removes the flags and removes all uses of `showSearchContext` flag.
ea4fd57 to
d4be11b
Compare
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff d94a71c...5f95a9b.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These flags have been removed in #46086 and #46045 but were accidentally(merge conflict?) added back to the schema in #46086.
Furthermore the
showSearchContextflag was still accessed in a couple of places, resulting in a broken experience if it was set tofalse:This PR removes the flags and removes all uses of
showSearchContextflag.Test plan
greppedfor the removed flags (showSearchContextis still used as props in various places though).Opened web app and verified that the context dropdown is properly populated.