Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Remove searchStats feature flag and update docs#47959

Merged
fkling merged 1 commit into
mainfrom
fkling/search-stats-flag
Feb 24, 2023
Merged

Remove searchStats feature flag and update docs#47959
fkling merged 1 commit into
mainfrom
fkling/search-stats-flag

Conversation

@fkling

@fkling fkling commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

This flag had been removed in #46045 but (accidentally?) added back in #45705. The feature (search stats) itself been removed in #45996. Documentation about it has already been removed in #30564. The link removed in this PR has been dead since then.

Test plan

grepped the code for references to the flag and used sourcegraph to find the commits that made changes to the related code and documentation.

@fkling fkling requested a review from a team February 21, 2023 14:28
@cla-bot cla-bot Bot added the cla-signed label Feb 21, 2023
@sourcegraph-bot

sourcegraph-bot commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 3b903e2...3cae672.

No notifications.

@limitedmage limitedmage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't affect the language stats chart in code insights, right?

This flag had been removed in #46045 but (accidentally?) added
back in #45705. The feature (search stats) itself been removed in
 #45996. Documentation about it has already been removed in #30564. The
link removed in this PR has been dead since then.
@fkling

fkling commented Feb 23, 2023

Copy link
Copy Markdown
Contributor Author

@limitedmage It doesn't seem to be used anywhere so I hope not :)

@fkling fkling force-pushed the fkling/search-stats-flag branch from 07efc9c to 3cae672 Compare February 23, 2023 10:02
@vovakulikov

Copy link
Copy Markdown
Contributor

@fkling fkling merged commit 0938078 into main Feb 24, 2023
@fkling fkling deleted the fkling/search-stats-flag branch February 24, 2023 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants