This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Add pagination to saved searches pages#45705
Merged
Merged
Conversation
aa127e4 to
be529f3
Compare
Contributor
Author
|
Blocked on decision from: https://sourcegraph.slack.com/archives/C03CSAER9LK/p1672317171091039 |
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 2028ef5...e93e59b.
|
be529f3 to
328ef63
Compare
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits e93e59b and 2028ef5 or learn more. Open explanation
|
328ef63 to
8e51629
Compare
Contributor
Author
Resolved! |
cae55b0 to
72eb723
Compare
limitedmage
approved these changes
Jan 2, 2023
limitedmage
left a comment
Contributor
There was a problem hiding this comment.
Frontend code looks good, left some comments to be addressed. Please have someone else review the backend Go code 😅
mrnugget
suggested changes
Jan 3, 2023
mrnugget
left a comment
Contributor
There was a problem hiding this comment.
Only looked at the Go code for now. Left some comments. I think some of them should be implemented, especially the org-membership test, etc.
limitedmage
reviewed
Jan 3, 2023
72eb723 to
cbf9ebc
Compare
cbf9ebc to
25b47e9
Compare
mrnugget
approved these changes
Jan 5, 2023
mrnugget
left a comment
Contributor
There was a problem hiding this comment.
Sweet! Left two comments. One is important: we need to check for both IDs being 0 in the GraphQL layer.
vdavid
approved these changes
Jan 5, 2023
vdavid
left a comment
Contributor
There was a problem hiding this comment.
The VS Code-related changes LGTM!
indradhanush
reviewed
Jan 9, 2023
Comment on lines
+8375
to
+8395
| """ | ||
| Pagination information. | ||
| """ | ||
| type ConnectionPageInfo { | ||
| """ | ||
| When paginating forwards, the cursor to continue. | ||
| """ | ||
| endCursor: String | ||
| """ | ||
| When paginating forwards, are there more items? | ||
| """ | ||
| hasNextPage: Boolean! | ||
| """ | ||
| When paginating backward, the cursor to continue. | ||
| """ | ||
| startCursor: String | ||
| """ | ||
| When paginating backward, are there more items? | ||
| """ | ||
| hasPreviousPage: Boolean! | ||
| } |
Contributor
There was a problem hiding this comment.
Why not use BidirectionalPageInfo instead of defining this?
Contributor
There was a problem hiding this comment.
Yeah, good point. @thenamankumar I think you can remov eyour ConnectionPageInfo and use BidirectionalPageInfo. Turns out we did have this before 😄 https://github.com/sourcegraph/sourcegraph/pull/45705#discussion_r1060451851
fkling
added a commit
that referenced
this pull request
Feb 24, 2023
This flag had been removed in #46045 but (accidentally?) added back in #45705. The feature (search stats) itself been removed in #45996. Documentation about it has already been removed in #30564. The link removed in this PR has been dead since then. ## Test plan `grep`ped the code for references to the flag and used sourcegraph to find the commits that made changes to the related code and documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/sourcegraph/sourcegraph/issues/43623
Use the new cursor-based pagination system to add pagination to Saved Searches pages.
In response to the new breaking changes to the API:
Unit tests are updated for the saved searches page.
Test plan