Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

remove experimental search stats page (/stats)#45996

Merged
sqs merged 1 commit into
mainfrom
sqs/rm-searchstats-page
Jan 2, 2023
Merged

remove experimental search stats page (/stats)#45996
sqs merged 1 commit into
mainfrom
sqs/rm-searchstats-page

Conversation

@sqs

@sqs sqs commented Dec 29, 2022

Copy link
Copy Markdown
Member

Code Insights language stats are a big improvement over this /stats "Search stats" page, which was hidden behind an experimental feature for its entire lifetime.

The GraphQL API still remains (and is used by Code Insights).

Test plan

Create a new language stats insight. Ensure that clicking on each pie chart segment takes you to a search scoped to just that language.

@cla-bot cla-bot Bot added the cla-signed label Dec 29, 2022
@sqs sqs requested a review from a team December 29, 2022 10:23
@sourcegraph-bot

sourcegraph-bot commented Dec 29, 2022

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 1892c8f...db7dd38.

Notify File(s)
@fkling client/web/src/search/stats/contributions.ts
@limitedmage client/web/src/search/stats/contributions.ts

@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Dec 29, 2022

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
-0.06% (-1.60 kb) -0.19% (-27.80 kb) 🔽 -0.23% (-26.20 kb) 🔽 0.00% (0)

Look at the Statoscope report for a full comparison between the commits db7dd38 and 1892c8f or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

Code Insights language stats are a big improvement over this `/stats` "Search stats" page, which was hidden behind an experimental feature for its entire lifetime.

The GraphQL API still remains (and is used by Code Insights).
@sqs sqs force-pushed the sqs/rm-searchstats-page branch from da77b76 to db7dd38 Compare December 29, 2022 10:38
@sqs sqs merged commit 1dae5d3 into main Jan 2, 2023
@sqs sqs deleted the sqs/rm-searchstats-page branch January 2, 2023 22:14
fkling added a commit that referenced this pull request Feb 23, 2023
This flag had been removed in #46045 but (accidentally?) added
back in #45705. The feature (search stats) itself been removed in
 #45996. Documentation about it has already been removed in #30564. The
link removed in this PR has been dead since then.
fkling added a commit that referenced this pull request Feb 24, 2023
This flag had been removed in #46045 but (accidentally?) added back in
#45705. The feature (search stats) itself been removed in #45996.
Documentation about it has already been removed in #30564. The link
removed in this PR has been dead since then.

## Test plan

`grep`ped the code for references to the flag and used sourcegraph to
find the commits that made changes to the related code and
documentation.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants