This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Remove globbing from all frontend code#49687
Merged
Merged
Conversation
As @fkling noticed in #49684, these option is no longer supported: - https://github.com/sourcegraph/sourcegraph/pull/27886 - https://github.com/sourcegraph/sourcegraph/pull/46045 Time to do some cleanup in the front end code!
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 299422e...877e163.
|
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 877e163 and b7d28f7 or learn more. Open explanation
|
vovakulikov
approved these changes
Mar 20, 2023
vovakulikov
left a comment
Contributor
There was a problem hiding this comment.
Tested locally, code insights pickers and core search functionality works as expected, left small comments
| */ | ||
| export const regexInsertText = (value: string, options: { globbing: boolean }): string => { | ||
| const insertText = options.globbing ? value : `^${escapeRegExp(value)}$` | ||
| export const regexInsertText = (value: string, _options: {}): string => { |
Contributor
There was a problem hiding this comment.
If option was only about globbing property can we delete this argument?
| } else { | ||
| aSettings.remoteUrlReplacements = mySettingsComponent.getRemoteUrlReplacements(); | ||
| } | ||
| //noinspection ReplaceNullCheck |
| async (token, type) => | ||
| (await fetchDynamicSuggestions(token, type)).flatMap(suggestion => | ||
| suggestionToCompletionItems(suggestion, { globbing }) | ||
| suggestionToCompletionItems(suggestion, {}) |
Contributor
There was a problem hiding this comment.
Can we remove empty object arguments?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @fkling noticed in #49684, these option is no longer supported:
Time to do some cleanup in the front end code!
Process:
globbingTest plan
App preview:
Check out the client app preview documentation to learn more.