Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Settings: Remove additionalFields json validation field #44180

@vovakulikov

Description

@vovakulikov

Related Slack thread

Problem

At the moment we have additionalFields: false in the experimentalFeatures section in the sourcegraph settings json file. This has two implications

  • You can't store any additional fields in the experimentalFeatures section (you see an error if you try to save settings with not allowed fields there)
  • Settings editor highlights these not allowed fields in the UI

Screenshot 2022-11-09 at 19 49 16

But this system forces us to have all experimental feature flags all time because we can just delete them because then our settings will become invalid (see point 1 above)

So in order to solve this problem for now we need to remove this additionalFields: false from the setting json schema (and also remove the deprecated features flags from the schema since it will become possible).

/cc @Joelkw @felixfbecker @vovakulikov

Metadata

Metadata

Assignees

Labels

code-insightsIssues related to the Code Insights productdebtTechnical debt.webapp

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions