This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search: remove experimental glob setting and logic in GQL layer#27886
Merged
Conversation
Contributor
|
Notifying subscribers in CODENOTIFY files for diff 69fd9c1...55876f5.
|
ae91b8c to
c88652a
Compare
keegancsmith
approved these changes
Nov 18, 2021
keegancsmith
left a comment
Member
There was a problem hiding this comment.
/me pours one out
changelog entry?
rvantonder
commented
Nov 18, 2021
c88652a to
55876f5
Compare
fkling
added a commit
that referenced
this pull request
Mar 20, 2023
Originally I wanted to do properly pass in the `globbing` parameter but then I noticed that this feature had been removed for quite a while (#27886, #46045). But while working on this I noticed that the cursor is not properly scrolled into view when completing a long value. Adding `scrollIntoView` fixes that.
philipp-spiess
referenced
this pull request
Mar 20, 2023
As @fkling noticed in #49684, these option is no longer supported: - https://github.com/sourcegraph/sourcegraph/pull/27886 - https://github.com/sourcegraph/sourcegraph/pull/46045 Time to do some cleanup in the front end code!
fkling
added a commit
that referenced
this pull request
Mar 20, 2023
#49684) Originally I wanted to do properly pass in the `globbing` parameter but then I noticed that this feature had been removed for quite a while (#27886, #46045). But while working on this I noticed that the cursor is not properly scrolled into view when completing a long value. Adding `scrollIntoView` fixes that. ## Test plan Enter a long query into the input, type `file:` and select a long file suggestion. The input should scroll the cursor into view. ## App preview: - [Web](https://sg-web-fkling-search-input-globbing.onrender.com/search) Check out the [client app preview documentation](https://docs.sourcegraph.com/dev/how-to/client_pr_previews) to learn more.
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
#49684) Originally I wanted to do properly pass in the `globbing` parameter but then I noticed that this feature had been removed for quite a while (#27886, #46045). But while working on this I noticed that the cursor is not properly scrolled into view when completing a long value. Adding `scrollIntoView` fixes that. ## Test plan Enter a long query into the input, type `file:` and select a long file suggestion. The input should scroll the cursor into view. ## App preview: - [Web](https://sg-web-fkling-search-input-globbing.onrender.com/search) Check out the [client app preview documentation](https://docs.sourcegraph.com/dev/how-to/client_pr_previews) to learn more. (cherry picked from commit 87b738d)
fkling
added a commit
that referenced
this pull request
Mar 20, 2023
…after completion (#49689) Originally I wanted to do properly pass in the `globbing` parameter but then I noticed that this feature had been removed for quite a while (#27886, #46045). But while working on this I noticed that the cursor is not properly scrolled into view when completing a long value. Adding `scrollIntoView` fixes that. ## Test plan Enter a long query into the input, type `file:` and select a long file suggestion. The input should scroll the cursor into view. Co-authored-by: Felix Kling <felix@felix-kling.de>
philipp-spiess
referenced
this pull request
Mar 21, 2023
As @fkling noticed in #49684, these option is no longer supported: - https://github.com/sourcegraph/sourcegraph/pull/27886 - https://github.com/sourcegraph/sourcegraph/pull/46045 Time to do some cleanup in the front end code! Process: - Grep for `globbing` - Delete everything that is related to front end code ## Test plan - CI <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> ## App preview: - [Web](https://sg-web-ps-rm-globbing-from-frontend.onrender.com/search) Check out the [client app preview documentation](https://docs.sourcegraph.com/dev/how-to/client_pr_previews) to learn more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in title. Frontend to be done separately later.