This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.0] experimental search input: Scroll selection into view after completion#49689
Merged
Conversation
#49684) Originally I wanted to do properly pass in the `globbing` parameter but then I noticed that this feature had been removed for quite a while (#27886, #46045). But while working on this I noticed that the cursor is not properly scrolled into view when completing a long value. Adding `scrollIntoView` fixes that. ## Test plan Enter a long query into the input, type `file:` and select a long file suggestion. The input should scroll the cursor into view. ## App preview: - [Web](https://sg-web-fkling-search-input-globbing.onrender.com/search) Check out the [client app preview documentation](https://docs.sourcegraph.com/dev/how-to/client_pr_previews) to learn more. (cherry picked from commit 87b738d)
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 96d6321 and 530863b or learn more. Open explanation
|
fkling
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally I wanted to do properly pass in the
globbingparameter but then I noticed that this feature had been removed for quite a while (#27886, #46045).But while working on this I noticed that the cursor is not properly scrolled into view when completing a long value. Adding
scrollIntoViewfixes that.Test plan
Enter a long query into the input, type
file:and select a long file suggestion. The input should scroll the cursor into view.App preview:
Check out the client app preview documentation to learn more.
Backport 87b738d from #49684