fix: parse .cjs / .cts / .js within "type": "commonjs" as CommonJS#8455
Conversation
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
ec1fc01 to
a077b55
Compare
There was a problem hiding this comment.
Pull request overview
This PR adjusts Rolldown’s JS/TS parsing mode so that modules identified as CommonJS (by extension or closest package.json "type": "commonjs") are parsed as CommonJS/script (sloppy-capable) instead of ESM/strict, addressing cases like assigning to arguments (Issue #7009).
Changes:
- Switch
parse_to_ecma_astto chooseoxc::SourceTypebased onResolvedId.module_def_format(CJS vs ESM). - Update/extend integration fixtures and snapshots to reflect
.cjsnow being treated as CommonJS (e.g., replacingimportwithrequirein.cjsfixtures) and add a newcjs_argumentsregression fixture. - Add documentation describing the strict-mode parsing limitation and workarounds.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/in-depth/bundling-cjs.md | Documents strict-mode parsing behavior for certain .js cases and a workaround. |
| crates/rolldown/src/utils/parse_to_ecma_ast.rs | Selects oxc SourceType based on ModuleDefFormat to parse CJS as CJS. |
| crates/rolldown/tests/rolldown/topics/deconflict/cjs_arguments/* | Adds a regression fixture covering sloppy-only syntax in CJS (arguments = 1). |
| crates/rolldown/tests/rolldown/topics/keep_names/issue_7507/src/* | Updates the fixture to avoid ESM import in .cjs now that it’s parsed as CJS. |
| crates/rolldown/tests/rolldown/issues/4289/* | Adjusts .cjs fixture + config for node platform; updates expected artifacts. |
| crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap | Updates hashed-filename expectations due to output changes/new fixture. |
crates/rolldown/tests/rolldown/topics/keep_names/issue_7507/src/index.cjs
Outdated
Show resolved
Hide resolved
Benchmarks Rust
|
a077b55 to
839a14d
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
crates/rolldown/tests/rolldown/issues/7009/js_type_commonjs/_config.json
Outdated
Show resolved
Hide resolved
Merge activity
|
839a14d to
d509445
Compare
d509445 to
8b05737
Compare
This PR partially reverts #8455. `.js` with the closest `package.json` with `"type": "commonjs"` will now be parsed as ESM for now as that caused tests in Vite repo to fail. For example: ``` [PARSE_ERROR] Error: Cannot use import statement outside a module ╭─[ node_modules/.pnpm/@babel+runtime@7.28.6/node_modules/@babel/runtime/helpers/esm/slicedToArray.js:1:1 ] │ 1 │ import arrayWithHoles from "./arrayWithHoles.js"; │ ───┬── │ ╰──── ───╯ ```
This PR partially reverts #8455. `.js` with the closest `package.json` with `"type": "commonjs"` will now be parsed as ESM for now as that caused tests in Vite repo to fail. For example: ``` [PARSE_ERROR] Error: Cannot use import statement outside a module ╭─[ node_modules/.pnpm/@babel+runtime@7.28.6/node_modules/@babel/runtime/helpers/esm/slicedToArray.js:1:1 ] │ 1 │ import arrayWithHoles from "./arrayWithHoles.js"; │ ───┬── │ ╰──── ───╯ ```
## [1.0.0-rc.6] - 2026-02-26 ### 💥 BREAKING CHANGES - css: remove `css_entry_filenames` , `css_chunk_filenames` and related code (#8402) by @hyf0 - css: drop builtin CSS bundling to explore alternative solutions (#8399) by @hyf0 ### 🚀 Features - rust/data-url: use hash as id for data url modules to prevent long string overhead (#8420) by @hyf0 - validate bundle stays within output dir (#8441) by @sapphi-red - rust: support `PluginOrder::PinPost` (#8417) by @hyf0 - support `ModuleType:Copy` (#8407) by @hyf0 - expose `ESTree` types from `rolldown/utils` (#8400) by @sapphi-red ### 🐛 Bug Fixes - incorrect sourcemap when postBanner/postFooter is used with shebang (#8459) by @Copilot - resolver: disable node_path option to align ESM resolver behavior (#8472) by @sapphi-red - parse `.js` within `"type": "commonjs"` as ESM for now (#8470) by @sapphi-red - case-insensitive filename conflict detection for chunk deduplication (#8458) by @Copilot - prevent inlining CJS exports that are mutated by importers (#8456) by @IWANABETHATGUY - parse `.cjs` / `.cts` / `.js` within `"type": "commonjs"` as CommonJS (#8455) by @sapphi-red - plugin/copy-module: correct hooks' priority (#8423) by @hyf0 - plugin/chunk-import-map: ensure `render_chunk_meta` run after users plugin (#8422) by @hyf0 - rust: correct hooks order of `DataUriPlugin` (#8418) by @hyf0 - `jsx.preserve` should also considering tsconfig json preserve (#8324) by @IWANABETHATGUY - `deferred_scan_data.rs "Should have resolved id: NotFound"` error (#8379) by @sapphi-red - cli: require value for `--dir`/`-d` and `--file`/`-o` (#8378) by @Copilot - dev: avoid mutex deadlock caused by inconsistent lock order (#8370) by @sapphi-red ### 🚜 Refactor - watch: rename TaskStart/TaskEnd to BundleStart/BundleEnd (#8463) by @hyf0 - rust: rename `rolldown_plugin_data_uri` to `rolldown_plugin_data_url` (#8421) by @hyf0 - bindingify-build-hook: extract helper for PluginContextImpl (#8438) by @ShroXd - give source loading a proper name (#8436) by @IWANABETHATGUY - ban holding DashMap refs across awaits (#8362) by @sapphi-red ### 📚 Documentation - add glob pattern usage example to input option (#8469) by @IWANABETHATGUY - remove `https://rolldown.rs` from links in reference docs (#8454) by @sapphi-red - mention execution order issue in `output.codeSplitting` docs (#8452) by @sapphi-red - clarify `output.comments` behavior a bit (#8451) by @sapphi-red - replace npmjs package links with npmx.dev (#8439) by @Boshen - reference: add `Exported from` for values / types exported from subpath exports (#8394) by @sapphi-red - add JSDocs for APIs exposed from subpath exports (#8393) by @sapphi-red - reference: generate reference pages for APIs exposed from subpath exports (#8392) by @sapphi-red - avoid pipe character in codeSplitting example to fix broken rendering (#8391) by @IWANABETHATGUY ### ⚡ Performance - avoid redundant PathBuf allocations in resolve paths (#8435) by @Brooooooklyn - bump to `sugar_path@2` (#8432) by @hyf0 - use flag-based convergence detection in include_statements (#8412) by @Brooooooklyn ### 🧪 Testing - execute `_test.mjs` even if `executeOutput` is false (#8398) by @sapphi-red - add retry to tree-shake/module-side-effects-proxy4 as it is flaky (#8397) by @sapphi-red - avoid `expect.assertions()` as it is not concurrent test friendly (#8383) by @sapphi-red - disable `mockReset` option (#8382) by @sapphi-red - fix flaky failure caused by concurrent resolveId calls (#8381) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency rollup to v4.59.0 [security] (#8471) by @renovate[bot] - ai/design: add design doc about watch mode (#8453) by @hyf0 - deps: update oxc resolver to v11.19.0 (#8461) by @renovate[bot] - ai: introduce progressive spec-driven development pattern (#8446) by @hyf0 - deprecate output.legalComments (#8450) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.15.0 (#8448) by @renovate[bot] - ai: make CLAUDE.md a symlink of AGENTS.md (#8445) by @hyf0 - deps: update rollup submodule for tests to v4.59.0 (#8433) by @sapphi-red - deps: update test262 submodule for tests (#8434) by @sapphi-red - deps: update oxc to v0.115.0 (#8430) by @renovate[bot] - deps: update oxc apps (#8429) by @renovate[bot] - deps: update npm packages (#8426) by @renovate[bot] - deps: update rust crate owo-colors to v4.3.0 (#8428) by @renovate[bot] - deps: update github-actions (#8424) by @renovate[bot] - deps: update rust crates (#8425) by @renovate[bot] - deps: update oxc resolver to v11.18.0 (#8406) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.14.2 (#8405) by @renovate[bot] - ban `expect.assertions` in all fixture tests (#8395) by @sapphi-red - deps: update oxc apps (#8389) by @renovate[bot] - ban `expect.assertions` in fixture tests (#8387) by @sapphi-red - enable lint for `_config.ts` files (#8386) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.14.1 (#8385) by @renovate[bot] Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

.cjs/.cts/.jswith the closestpackage.jsonwith"type": "commonjs"will now be parsed as CJS, which will allow non-strict syntaxes.Part of #7009.