Skip to content

fix(cli): require value for --dir/-d and --file/-o#8378

Merged
sapphi-red merged 6 commits intomainfrom
copilot/require-dir-value-option
Feb 19, 2026
Merged

fix(cli): require value for --dir/-d and --file/-o#8378
sapphi-red merged 6 commits intomainfrom
copilot/require-dir-value-option

Conversation

Copy link
Contributor

Copilot AI commented Feb 19, 2026

The -d/--dir and -o/--file options accepted no value, defaulting to empty string. This caused -d to silently target the current directory (dangerous with --clean-dir) and -o to panic.

Changes

  • Added requireValue flag to OptionConfig - Options can now enforce value requirement
  • Updated CLI parser - Errors with clear message when required values are missing: Option '--dir' requires a value but none was provided.
  • Applied to dangerous options - Both dir and file now require explicit values

Behavior

# Error cases
$ rolldown -d
[error] Option `--dir` requires a value but none was provided.

$ rolldown -o
[error] Option `--file` requires a value but none was provided.

# Explicit current directory still works
$ rolldown -d .
Original prompt

This section details on the original issue you should resolve

<issue_title>[Feature Request]: require a value for the --dir/-d option</issue_title>
<issue_description>### What problem does this feature solve?

Passing the -d option to Rolldown with no value seems to default to the current working directory, which can be dangerous when --clean-dir is enabled - very sneaky behavior when cleanDir is enabled in rolldown.config.js.

I suggest that this option should strictly require a value. If one really intends to use the current directory as the output dir, it could be done via -d . or perhaps -d "".

I managed to wipe a few uncommitted changes today after passing the -d option by mistake. I realize the error is mine, but I do think it'd be safer with the strict requirement. Thank you for considering!

What does the proposed API look like?

  • $ rolldown ... builds accordingly to rolldown.config.js or by default into ./dist
  • $ rolldown -d . ... builds into current directory
  • $ rolldown -d ... throws an error
  • same behavior when used in the long form: --dir</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@netlify
Copy link

netlify bot commented Feb 19, 2026

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit fe2a3d6
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69968765f030040008419aa0
😎 Deploy Preview https://deploy-preview-8378--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI and others added 5 commits February 19, 2026 03:40
Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Copilot AI changed the title [WIP] Require a value for the --dir/-d option in Rolldown Require value for --dir/-d and --file/-o CLI options Feb 19, 2026
Copilot AI requested a review from sapphi-red February 19, 2026 03:46
@sapphi-red sapphi-red changed the title Require value for --dir/-d and --file/-o CLI options fix: require value for --dir/-d and --file/-o CLI options Feb 19, 2026
@sapphi-red sapphi-red changed the title fix: require value for --dir/-d and --file/-o CLI options fix(cli): require value for --dir/-d and --file/-o Feb 19, 2026
@sapphi-red sapphi-red marked this pull request as ready for review February 19, 2026 04:10
@sapphi-red sapphi-red requested review from Copilot and removed request for sapphi-red February 19, 2026 04:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds value requirement enforcement for the --dir/-d and --file/-o CLI options to prevent dangerous behavior where -d without a value would silently target the current directory (especially hazardous with --clean-dir), and -o without a value would cause a panic.

Changes:

  • Added requireValue flag to OptionConfig interface for enforcing value requirements on options
  • Updated CLI parser to check for required values and emit clear error messages when missing
  • Applied requireValue: true to both dir and file options in the alias configuration

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/rolldown/src/cli/arguments/alias.ts Added requireValue field to OptionConfig interface and applied it to dir and file options
packages/rolldown/src/cli/arguments/index.ts Implemented validation logic to check for required values and error with clear messages
packages/rolldown/tests/cli/cli-e2e.test.ts Added comprehensive tests for both short and long forms of -d/--dir and -o/--file options
packages/rolldown/tests/cli/fixtures/.gitignore Added gitignore entries for test artifacts

@sapphi-red sapphi-red merged commit 6fe4f29 into main Feb 19, 2026
40 of 42 checks passed
@sapphi-red sapphi-red deleted the copilot/require-dir-value-option branch February 19, 2026 05:37
shulaoda added a commit that referenced this pull request Feb 26, 2026
## [1.0.0-rc.6] - 2026-02-26

### 💥 BREAKING CHANGES

- css: remove `css_entry_filenames` , `css_chunk_filenames` and related code (#8402) by @hyf0
- css: drop builtin CSS bundling to explore alternative solutions (#8399) by @hyf0

### 🚀 Features

- rust/data-url: use hash as id for data url modules to prevent long string overhead (#8420) by @hyf0
- validate bundle stays within output dir (#8441) by @sapphi-red
- rust: support `PluginOrder::PinPost` (#8417) by @hyf0
- support `ModuleType:Copy` (#8407) by @hyf0
- expose `ESTree` types from `rolldown/utils` (#8400) by @sapphi-red

### 🐛 Bug Fixes

- incorrect sourcemap when postBanner/postFooter is used with shebang (#8459) by @Copilot
- resolver: disable node_path option to align ESM resolver behavior (#8472) by @sapphi-red
- parse `.js` within `"type": "commonjs"` as ESM for now (#8470) by @sapphi-red
- case-insensitive filename conflict detection for chunk deduplication (#8458) by @Copilot
- prevent inlining CJS exports that are mutated by importers (#8456) by @IWANABETHATGUY
- parse `.cjs` / `.cts` / `.js` within `"type": "commonjs"` as CommonJS (#8455) by @sapphi-red
- plugin/copy-module: correct hooks' priority (#8423) by @hyf0
- plugin/chunk-import-map: ensure `render_chunk_meta` run after users plugin (#8422) by @hyf0
- rust: correct hooks order of `DataUriPlugin` (#8418) by @hyf0
- `jsx.preserve` should also considering tsconfig json preserve (#8324) by @IWANABETHATGUY
- `deferred_scan_data.rs "Should have resolved id: NotFound"` error (#8379) by @sapphi-red
- cli: require value for `--dir`/`-d` and `--file`/`-o` (#8378) by @Copilot
- dev: avoid mutex deadlock caused by inconsistent lock order (#8370) by @sapphi-red

### 🚜 Refactor

- watch: rename TaskStart/TaskEnd to BundleStart/BundleEnd (#8463) by @hyf0
- rust: rename `rolldown_plugin_data_uri` to `rolldown_plugin_data_url` (#8421) by @hyf0
- bindingify-build-hook: extract helper for PluginContextImpl (#8438) by @ShroXd
- give source loading a proper name (#8436) by @IWANABETHATGUY
- ban holding DashMap refs across awaits (#8362) by @sapphi-red

### 📚 Documentation

- add glob pattern usage example to input option (#8469) by @IWANABETHATGUY
- remove `https://rolldown.rs` from links in reference docs (#8454) by @sapphi-red
- mention execution order issue in `output.codeSplitting` docs (#8452) by @sapphi-red
- clarify `output.comments` behavior a bit (#8451) by @sapphi-red
- replace npmjs package links with npmx.dev (#8439) by @Boshen
- reference: add `Exported from` for values / types exported from subpath exports (#8394) by @sapphi-red
- add JSDocs for APIs exposed from subpath exports (#8393) by @sapphi-red
- reference: generate reference pages for APIs exposed from subpath exports (#8392) by @sapphi-red
- avoid pipe character in codeSplitting example to fix broken rendering (#8391) by @IWANABETHATGUY

### ⚡ Performance

- avoid redundant PathBuf allocations in resolve paths (#8435) by @Brooooooklyn
- bump to `sugar_path@2` (#8432) by @hyf0
- use flag-based convergence detection in include_statements (#8412) by @Brooooooklyn

### 🧪 Testing

- execute `_test.mjs` even if `executeOutput` is false (#8398) by @sapphi-red
- add retry to tree-shake/module-side-effects-proxy4 as it is flaky (#8397) by @sapphi-red
- avoid `expect.assertions()` as it is not concurrent test friendly (#8383) by @sapphi-red
- disable `mockReset` option (#8382) by @sapphi-red
- fix flaky failure caused by concurrent resolveId calls (#8381) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update dependency rollup to v4.59.0 [security] (#8471) by @renovate[bot]
- ai/design: add design doc about watch mode (#8453) by @hyf0
- deps: update oxc resolver to v11.19.0 (#8461) by @renovate[bot]
- ai: introduce progressive spec-driven development pattern (#8446) by @hyf0
- deprecate output.legalComments (#8450) by @sapphi-red
- deps: update dependency oxlint-tsgolint to v0.15.0 (#8448) by @renovate[bot]
- ai: make CLAUDE.md a symlink of AGENTS.md (#8445) by @hyf0
- deps: update rollup submodule for tests to v4.59.0 (#8433) by @sapphi-red
- deps: update test262 submodule for tests (#8434) by @sapphi-red
- deps: update oxc to v0.115.0 (#8430) by @renovate[bot]
- deps: update oxc apps (#8429) by @renovate[bot]
- deps: update npm packages (#8426) by @renovate[bot]
- deps: update rust crate owo-colors to v4.3.0 (#8428) by @renovate[bot]
- deps: update github-actions (#8424) by @renovate[bot]
- deps: update rust crates (#8425) by @renovate[bot]
- deps: update oxc resolver to v11.18.0 (#8406) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.14.2 (#8405) by @renovate[bot]
- ban `expect.assertions` in all fixture tests (#8395) by @sapphi-red
- deps: update oxc apps (#8389) by @renovate[bot]
- ban `expect.assertions` in fixture tests (#8387) by @sapphi-red
- enable lint for `_config.ts` files (#8386) by @sapphi-red
- deps: update dependency oxlint-tsgolint to v0.14.1 (#8385) by @renovate[bot]

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: require a value for the --dir/-d option

4 participants