fix(plugin/copy-module): correct hooks' priority by hyf0 · Pull Request #8423 · rolldown/rolldown

hyf0 · 2026-02-22T14:15:16Z

No description provided.

hyf0 · 2026-02-22T14:15:36Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-02-22T14:42:01Z

Benchmarks Rust

target: 02-22-fix_plugin_chunk-import-map_ensure_render_chunk_meta_run_after_users_plugin(53a1575)
pr: 02-22-fix_plugin_copy-module_correct_hooks_priority(f9cb7ce)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     69.3±1.77ms        ? ?/sec    1.00     68.5±2.14ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03     76.1±2.34ms        ? ?/sec    1.00     74.2±2.09ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    100.1±2.18ms        ? ?/sec    1.00    100.3±1.95ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    112.1±1.87ms        ? ?/sec    1.00    111.4±4.16ms        ? ?/sec
bundle/bundle@threejs                                        1.00     36.5±2.96ms        ? ?/sec    1.00     36.4±2.19ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     40.7±0.83ms        ? ?/sec    1.00     40.6±1.12ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    364.1±4.10ms        ? ?/sec    1.00    362.8±5.73ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    418.6±4.51ms        ? ?/sec    1.00    416.9±5.30ms        ? ?/sec
scan/scan@rome_ts                                            1.01     78.1±1.66ms        ? ?/sec    1.00     77.6±1.62ms        ? ?/sec
scan/scan@threejs                                            1.02     27.8±1.73ms        ? ?/sec    1.00     27.3±0.50ms        ? ?/sec
scan/scan@threejs10x                                         1.00    280.0±4.15ms        ? ?/sec    1.00    279.1±5.27ms        ? ?/sec

graphite-app · 2026-02-24T15:07:22Z

Merge activity

Feb 24, 3:07 PM UTC: hyf0 added this pull request to the Graphite merge queue.
Feb 24, 4:02 PM UTC: The Graphite merge queue couldn't merge this PR because it timed out.
Feb 24, 4:24 PM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 25, 3:57 AM UTC: hyf0 added this pull request to the Graphite merge queue.
Feb 25, 4:07 AM UTC: Merged by the Graphite merge queue.

netlify · 2026-02-25T02:55:33Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`7728a63`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/699e7339cdb64b0008d4254f

Copilot

Pull request overview

Adjusts the builtin copy-module plugin’s hook priority so it runs before user plugins, preventing user hooks from seeing/interfering with placeholder IDs and copy-module resolution.

Changes:

Set CopyModulePlugin’s resolve_id and render_chunk hooks to PluginOrder::Pre.
Prepend CopyModulePlugin in apply_inner_plugins (instead of conditionally appending it after user plugins).
Remove the previous render_chunk_meta Post ordering.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
crates/rolldown_plugin_copy_module/src/lib.rs	Changes hook meta ordering for `resolve_id`/`render_chunk` to run earlier.
crates/rolldown/src/utils/apply_inner_plugins.rs	Moves `CopyModulePlugin` into the builtin “before user plugins” list and removes the old conditional append.

crates/rolldown_plugin_copy_module/src/lib.rs

crates/rolldown/src/utils/apply_inner_plugins.rs

@hyf0

## [1.0.0-rc.6] - 2026-02-26 ### 💥 BREAKING CHANGES - css: remove `css_entry_filenames` , `css_chunk_filenames` and related code (#8402) by @hyf0 - css: drop builtin CSS bundling to explore alternative solutions (#8399) by @hyf0 ### 🚀 Features - rust/data-url: use hash as id for data url modules to prevent long string overhead (#8420) by @hyf0 - validate bundle stays within output dir (#8441) by @sapphi-red - rust: support `PluginOrder::PinPost` (#8417) by @hyf0 - support `ModuleType:Copy` (#8407) by @hyf0 - expose `ESTree` types from `rolldown/utils` (#8400) by @sapphi-red ### 🐛 Bug Fixes - incorrect sourcemap when postBanner/postFooter is used with shebang (#8459) by @Copilot - resolver: disable node_path option to align ESM resolver behavior (#8472) by @sapphi-red - parse `.js` within `"type": "commonjs"` as ESM for now (#8470) by @sapphi-red - case-insensitive filename conflict detection for chunk deduplication (#8458) by @Copilot - prevent inlining CJS exports that are mutated by importers (#8456) by @IWANABETHATGUY - parse `.cjs` / `.cts` / `.js` within `"type": "commonjs"` as CommonJS (#8455) by @sapphi-red - plugin/copy-module: correct hooks' priority (#8423) by @hyf0 - plugin/chunk-import-map: ensure `render_chunk_meta` run after users plugin (#8422) by @hyf0 - rust: correct hooks order of `DataUriPlugin` (#8418) by @hyf0 - `jsx.preserve` should also considering tsconfig json preserve (#8324) by @IWANABETHATGUY - `deferred_scan_data.rs "Should have resolved id: NotFound"` error (#8379) by @sapphi-red - cli: require value for `--dir`/`-d` and `--file`/`-o` (#8378) by @Copilot - dev: avoid mutex deadlock caused by inconsistent lock order (#8370) by @sapphi-red ### 🚜 Refactor - watch: rename TaskStart/TaskEnd to BundleStart/BundleEnd (#8463) by @hyf0 - rust: rename `rolldown_plugin_data_uri` to `rolldown_plugin_data_url` (#8421) by @hyf0 - bindingify-build-hook: extract helper for PluginContextImpl (#8438) by @ShroXd - give source loading a proper name (#8436) by @IWANABETHATGUY - ban holding DashMap refs across awaits (#8362) by @sapphi-red ### 📚 Documentation - add glob pattern usage example to input option (#8469) by @IWANABETHATGUY - remove `https://rolldown.rs` from links in reference docs (#8454) by @sapphi-red - mention execution order issue in `output.codeSplitting` docs (#8452) by @sapphi-red - clarify `output.comments` behavior a bit (#8451) by @sapphi-red - replace npmjs package links with npmx.dev (#8439) by @Boshen - reference: add `Exported from` for values / types exported from subpath exports (#8394) by @sapphi-red - add JSDocs for APIs exposed from subpath exports (#8393) by @sapphi-red - reference: generate reference pages for APIs exposed from subpath exports (#8392) by @sapphi-red - avoid pipe character in codeSplitting example to fix broken rendering (#8391) by @IWANABETHATGUY ### ⚡ Performance - avoid redundant PathBuf allocations in resolve paths (#8435) by @Brooooooklyn - bump to `sugar_path@2` (#8432) by @hyf0 - use flag-based convergence detection in include_statements (#8412) by @Brooooooklyn ### 🧪 Testing - execute `_test.mjs` even if `executeOutput` is false (#8398) by @sapphi-red - add retry to tree-shake/module-side-effects-proxy4 as it is flaky (#8397) by @sapphi-red - avoid `expect.assertions()` as it is not concurrent test friendly (#8383) by @sapphi-red - disable `mockReset` option (#8382) by @sapphi-red - fix flaky failure caused by concurrent resolveId calls (#8381) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency rollup to v4.59.0 [security] (#8471) by @renovate[bot] - ai/design: add design doc about watch mode (#8453) by @hyf0 - deps: update oxc resolver to v11.19.0 (#8461) by @renovate[bot] - ai: introduce progressive spec-driven development pattern (#8446) by @hyf0 - deprecate output.legalComments (#8450) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.15.0 (#8448) by @renovate[bot] - ai: make CLAUDE.md a symlink of AGENTS.md (#8445) by @hyf0 - deps: update rollup submodule for tests to v4.59.0 (#8433) by @sapphi-red - deps: update test262 submodule for tests (#8434) by @sapphi-red - deps: update oxc to v0.115.0 (#8430) by @renovate[bot] - deps: update oxc apps (#8429) by @renovate[bot] - deps: update npm packages (#8426) by @renovate[bot] - deps: update rust crate owo-colors to v4.3.0 (#8428) by @renovate[bot] - deps: update github-actions (#8424) by @renovate[bot] - deps: update rust crates (#8425) by @renovate[bot] - deps: update oxc resolver to v11.18.0 (#8406) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.14.2 (#8405) by @renovate[bot] - ban `expect.assertions` in all fixture tests (#8395) by @sapphi-red - deps: update oxc apps (#8389) by @renovate[bot] - ban `expect.assertions` in fixture tests (#8387) by @sapphi-red - enable lint for `_config.ts` files (#8386) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.14.1 (#8385) by @renovate[bot] Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

hyf0 marked this pull request as ready for review February 22, 2026 14:15

Copilot AI review requested due to automatic review settings February 22, 2026 14:15

github-actions bot assigned hyf0 Feb 22, 2026

hyf0 mentioned this pull request Feb 22, 2026

fix(plugin/chunk-import-map): ensure render_chunk_meta run after users plugin #8422

Merged

Copilot started reviewing on behalf of hyf0 February 22, 2026 14:15 View session

hyf0 force-pushed the 02-22-fix_plugin_copy-module_correct_hooks_priority branch 2 times, most recently from 9c66149 to f9cb7ce Compare February 22, 2026 14:26

hyf0 requested review from shulaoda and removed request for Copilot February 22, 2026 14:27

hyf0 added the graphite: merge-when-ready label Feb 24, 2026

graphite-app bot force-pushed the 02-22-fix_plugin_chunk-import-map_ensure_render_chunk_meta_run_after_users_plugin branch from 53a1575 to fc4d1be Compare February 24, 2026 08:06

graphite-app bot force-pushed the 02-22-fix_plugin_copy-module_correct_hooks_priority branch from f9cb7ce to 832dd1f Compare February 24, 2026 08:07

hyf0 requested a review from sapphi-red February 24, 2026 12:09

sapphi-red approved these changes Feb 24, 2026

View reviewed changes

graphite-app bot changed the base branch from 02-22-fix_plugin_chunk-import-map_ensure_render_chunk_meta_run_after_users_plugin to graphite-base/8423 February 24, 2026 14:48

graphite-app bot pushed a commit that referenced this pull request Feb 24, 2026

fix(plugin/copy-module): correct hooks' priority (#8423)

f7a1e56

Copilot AI review requested due to automatic review settings February 24, 2026 15:19

graphite-app bot force-pushed the 02-22-fix_plugin_copy-module_correct_hooks_priority branch from 832dd1f to f7a1e56 Compare February 24, 2026 15:19

hyf0 review requested due to automatic review settings February 24, 2026 15:19

graphite-app bot changed the base branch from graphite-base/8423 to 02-22-fix_plugin_chunk-import-map_ensure_render_chunk_meta_run_after_users_plugin February 24, 2026 15:20

Base automatically changed from 02-22-fix_plugin_chunk-import-map_ensure_render_chunk_meta_run_after_users_plugin to main February 24, 2026 15:31

graphite-app bot removed the graphite: merge-when-ready label Feb 24, 2026

hyf0 added the graphite: merge-when-ready label Feb 24, 2026

hyf0 added a commit that referenced this pull request Feb 25, 2026

fix(plugin/copy-module): correct hooks' priority (#8423)

58a5c16

Copilot AI review requested due to automatic review settings February 25, 2026 02:55

hyf0 force-pushed the 02-22-fix_plugin_copy-module_correct_hooks_priority branch from f7a1e56 to 58a5c16 Compare February 25, 2026 02:55

Copilot started reviewing on behalf of hyf0 February 25, 2026 02:55 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

crates/rolldown_plugin_copy_module/src/lib.rs Show resolved Hide resolved

crates/rolldown/src/utils/apply_inner_plugins.rs Show resolved Hide resolved

hyf0 removed the graphite: merge-when-ready label Feb 25, 2026

fix(plugin/copy-module): correct hooks' priority (#8423)

7728a63

hyf0 added the graphite: merge-when-ready label Feb 25, 2026

graphite-app bot force-pushed the 02-22-fix_plugin_copy-module_correct_hooks_priority branch from 58a5c16 to 7728a63 Compare February 25, 2026 03:57

graphite-app bot merged commit 7728a63 into main Feb 25, 2026
34 checks passed

graphite-app bot deleted the 02-22-fix_plugin_copy-module_correct_hooks_priority branch February 25, 2026 04:07

graphite-app bot removed the graphite: merge-when-ready label Feb 25, 2026

This was referenced Feb 26, 2026

release: v1.0.0-rc.6 #8473

Closed

release: v1.0.0-rc.6 #8474

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(plugin/copy-module): correct hooks' priority#8423

fix(plugin/copy-module): correct hooks' priority#8423
graphite-app[bot] merged 1 commit intomainfrom
02-22-fix_plugin_copy-module_correct_hooks_priority

hyf0 commented Feb 22, 2026

Uh oh!

hyf0 commented Feb 22, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 22, 2026

Uh oh!

graphite-app bot commented Feb 24, 2026 •

edited

Loading

Uh oh!

netlify bot commented Feb 25, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hyf0 commented Feb 22, 2026

Uh oh!

hyf0 commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Feb 22, 2026

Benchmarks Rust

Uh oh!

graphite-app bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

netlify bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hyf0 commented Feb 22, 2026 •

edited

Loading

graphite-app bot commented Feb 24, 2026 •

edited

Loading

netlify bot commented Feb 25, 2026 •

edited

Loading