feat(css)!: remove css_entry_filenames , css_chunk_filenames and related code#8402
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 20, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes experimental CSS bundling support from Rolldown by deleting the css_entry_filenames and css_chunk_filenames options along with all related CSS processing code. This is a pure code removal focused on eliminating CSS-specific functionality that was not ready for public use.
Changes:
- Removed CSS-specific filename configuration options (
cssEntryFileNames,cssChunkFileNames) from TypeScript and Rust codebases - Deleted CSS module processing infrastructure including
CssView,CssAssetMeta,CssGenerator, andCssRenderer - Updated CSS module handling to error early with an informative message directing users to issue #4271
- Removed
css-module-lexerdependency from Cargo workspace
Reviewed changes
Copilot reviewed 39 out of 40 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rolldown/src/options/output-options.ts | Removed CSS filename option type definitions |
| packages/rolldown/src/options/normalized-output-options.ts | Removed CSS filename option getters |
| packages/rolldown/src/utils/validator.ts | Removed CSS filename validation schemas |
| packages/rolldown/src/utils/bindingify-output-options.ts | Removed CSS option binding logic |
| packages/rolldown/src/binding.d.cts | Removed CSS filename option type declarations from binding interface |
| packages/rolldown/tests/fixtures/verify-options/_config.ts | Removed CSS filename option tests |
| packages/rolldown/tests/fixtures/output/hash-filenames/normal/_config.ts | Updated hash expectations due to filename computation order change |
| packages/rolldown/tests/cli/snapshots/cli-e2e.test.ts.snap | Removed CSS filename CLI options from help output |
| crates/rolldown_testing/_config.schema.json | Removed CSS filename fields from test config schema |
| crates/rolldown_common/src/types/asset_meta.rs | Removed Css variant from InstantiationKind enum |
| crates/rolldown_common/src/module/normal_module.rs | Removed css_view field from NormalModule |
| crates/rolldown_common/src/module/mod.rs | Simplified import_records logic after CSS view removal |
| crates/rolldown_common/src/lib.rs | Removed CSS module re-exports |
| crates/rolldown_common/src/inner_bundler_options/types/normalized_bundler_options.rs | Removed CSS filename option fields |
| crates/rolldown_common/src/inner_bundler_options/mod.rs | Removed CSS filename option declarations |
| crates/rolldown_common/src/css/mod.rs | Deleted CSS module entry point |
| crates/rolldown_common/src/css/css_view.rs | Deleted CSS view implementation |
| crates/rolldown_common/src/css/css_asset_meta.rs | Deleted CSS asset metadata |
| crates/rolldown_common/src/chunk/mod.rs | Removed CSS preliminary filename generation methods |
| crates/rolldown_binding/src/utils/normalize_binding_options.rs | Removed CSS filename option normalization |
| crates/rolldown_binding/src/types/binding_normalized_options.rs | Removed CSS filename getters from binding |
| crates/rolldown_binding/src/options/binding_output_options/mod.rs | Removed CSS filename option fields |
| crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap | Updated hash values due to computation order change |
| crates/rolldown/tests/rolldown/topics/new_url/nested_dirs/artifacts.snap | Updated hash values in generated filenames |
| crates/rolldown/tests/esbuild/loader/loader_file_one_source_two_different_output_paths_js/artifacts.snap | Updated hash values in generated filenames |
| crates/rolldown/src/utils/prepare_build_context.rs | Removed default CSS filename initialization |
| crates/rolldown/src/utils/parse_to_ecma_ast.rs | Changed CSS module handling to unreachable with early error |
| crates/rolldown/src/utils/chunk/finalize_chunks.rs | Removed CSS chunk finalization logic |
| crates/rolldown/src/stages/generate_stage/render_chunk_to_assets.rs | Removed CSS generator invocation |
| crates/rolldown/src/stages/generate_stage/mod.rs | Simplified asset patching after CSS view removal, removed clippy annotation |
| crates/rolldown/src/stages/generate_stage/minify_chunks.rs | Removed CSS case from minification logic |
| crates/rolldown/src/module_loader/runtime_module_task.rs | Removed css_view initialization |
| crates/rolldown/src/module_loader/module_task.rs | Added informative error for CSS modules, removed CSS view creation |
| crates/rolldown/src/lib.rs | Removed CSS module declaration |
| crates/rolldown/src/ecmascript/ecma_module_view_factory.rs | Removed CSS-specific side effects check |
| crates/rolldown/src/css/mod.rs | Deleted CSS module entry point |
| crates/rolldown/src/css/css_generator.rs | Deleted CSS generator implementation |
| crates/rolldown/Cargo.toml | Removed css-module-lexer dependency |
| Cargo.toml | Removed css-module-lexer workspace dependency |
| Cargo.lock | Removed css-module-lexer package and references |
Contributor
Benchmarks Rust
|
c9a5af1 to
ba92e11
Compare
0aa428f to
75c9d70
Compare
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
IWANABETHATGUY
approved these changes
Feb 20, 2026
Member
Author
Merge activity
|
ba92e11 to
157c672
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 20, 2026
…related code (#8402) - Pure code removal, no architecture changes. - Snapshot changed becuase removing `cssFilenames` cause the order of compute filename hash changed
75c9d70 to
64b20a0
Compare
Base automatically changed from
02-20-feat_css_emit_error_when_passing_moduletype_css_to_rolldown
to
main
February 20, 2026 15:39
…related code (#8402) - Pure code removal, no architecture changes. - Snapshot changed becuase removing `cssFilenames` cause the order of compute filename hash changed
64b20a0 to
6c8834b
Compare
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Feb 25, 2026
Closed
Closed
Merged
shulaoda
added a commit
that referenced
this pull request
Feb 26, 2026
## [1.0.0-rc.6] - 2026-02-26 ### 💥 BREAKING CHANGES - css: remove `css_entry_filenames` , `css_chunk_filenames` and related code (#8402) by @hyf0 - css: drop builtin CSS bundling to explore alternative solutions (#8399) by @hyf0 ### 🚀 Features - rust/data-url: use hash as id for data url modules to prevent long string overhead (#8420) by @hyf0 - validate bundle stays within output dir (#8441) by @sapphi-red - rust: support `PluginOrder::PinPost` (#8417) by @hyf0 - support `ModuleType:Copy` (#8407) by @hyf0 - expose `ESTree` types from `rolldown/utils` (#8400) by @sapphi-red ### 🐛 Bug Fixes - incorrect sourcemap when postBanner/postFooter is used with shebang (#8459) by @Copilot - resolver: disable node_path option to align ESM resolver behavior (#8472) by @sapphi-red - parse `.js` within `"type": "commonjs"` as ESM for now (#8470) by @sapphi-red - case-insensitive filename conflict detection for chunk deduplication (#8458) by @Copilot - prevent inlining CJS exports that are mutated by importers (#8456) by @IWANABETHATGUY - parse `.cjs` / `.cts` / `.js` within `"type": "commonjs"` as CommonJS (#8455) by @sapphi-red - plugin/copy-module: correct hooks' priority (#8423) by @hyf0 - plugin/chunk-import-map: ensure `render_chunk_meta` run after users plugin (#8422) by @hyf0 - rust: correct hooks order of `DataUriPlugin` (#8418) by @hyf0 - `jsx.preserve` should also considering tsconfig json preserve (#8324) by @IWANABETHATGUY - `deferred_scan_data.rs "Should have resolved id: NotFound"` error (#8379) by @sapphi-red - cli: require value for `--dir`/`-d` and `--file`/`-o` (#8378) by @Copilot - dev: avoid mutex deadlock caused by inconsistent lock order (#8370) by @sapphi-red ### 🚜 Refactor - watch: rename TaskStart/TaskEnd to BundleStart/BundleEnd (#8463) by @hyf0 - rust: rename `rolldown_plugin_data_uri` to `rolldown_plugin_data_url` (#8421) by @hyf0 - bindingify-build-hook: extract helper for PluginContextImpl (#8438) by @ShroXd - give source loading a proper name (#8436) by @IWANABETHATGUY - ban holding DashMap refs across awaits (#8362) by @sapphi-red ### 📚 Documentation - add glob pattern usage example to input option (#8469) by @IWANABETHATGUY - remove `https://rolldown.rs` from links in reference docs (#8454) by @sapphi-red - mention execution order issue in `output.codeSplitting` docs (#8452) by @sapphi-red - clarify `output.comments` behavior a bit (#8451) by @sapphi-red - replace npmjs package links with npmx.dev (#8439) by @Boshen - reference: add `Exported from` for values / types exported from subpath exports (#8394) by @sapphi-red - add JSDocs for APIs exposed from subpath exports (#8393) by @sapphi-red - reference: generate reference pages for APIs exposed from subpath exports (#8392) by @sapphi-red - avoid pipe character in codeSplitting example to fix broken rendering (#8391) by @IWANABETHATGUY ### ⚡ Performance - avoid redundant PathBuf allocations in resolve paths (#8435) by @Brooooooklyn - bump to `sugar_path@2` (#8432) by @hyf0 - use flag-based convergence detection in include_statements (#8412) by @Brooooooklyn ### 🧪 Testing - execute `_test.mjs` even if `executeOutput` is false (#8398) by @sapphi-red - add retry to tree-shake/module-side-effects-proxy4 as it is flaky (#8397) by @sapphi-red - avoid `expect.assertions()` as it is not concurrent test friendly (#8383) by @sapphi-red - disable `mockReset` option (#8382) by @sapphi-red - fix flaky failure caused by concurrent resolveId calls (#8381) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency rollup to v4.59.0 [security] (#8471) by @renovate[bot] - ai/design: add design doc about watch mode (#8453) by @hyf0 - deps: update oxc resolver to v11.19.0 (#8461) by @renovate[bot] - ai: introduce progressive spec-driven development pattern (#8446) by @hyf0 - deprecate output.legalComments (#8450) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.15.0 (#8448) by @renovate[bot] - ai: make CLAUDE.md a symlink of AGENTS.md (#8445) by @hyf0 - deps: update rollup submodule for tests to v4.59.0 (#8433) by @sapphi-red - deps: update test262 submodule for tests (#8434) by @sapphi-red - deps: update oxc to v0.115.0 (#8430) by @renovate[bot] - deps: update oxc apps (#8429) by @renovate[bot] - deps: update npm packages (#8426) by @renovate[bot] - deps: update rust crate owo-colors to v4.3.0 (#8428) by @renovate[bot] - deps: update github-actions (#8424) by @renovate[bot] - deps: update rust crates (#8425) by @renovate[bot] - deps: update oxc resolver to v11.18.0 (#8406) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.14.2 (#8405) by @renovate[bot] - ban `expect.assertions` in all fixture tests (#8395) by @sapphi-red - deps: update oxc apps (#8389) by @renovate[bot] - ban `expect.assertions` in fixture tests (#8387) by @sapphi-red - enable lint for `_config.ts` files (#8386) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.14.1 (#8385) by @renovate[bot] Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cssFilenamescause the order of compute filename hash changed