chore: enable lint for _config.ts files#8386
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 19, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
b293f23 to
fef3a0a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables linting for _config.ts test fixture files by updating the oxlint configuration and fixing all linting violations across these files. The changes ensure consistent code quality standards are applied to test configuration files, which were previously excluded from linting.
Changes:
- Modified
.oxlintrc.jsonto include_config.tsfiles in linting scope using a negation pattern - Fixed linting violations across all
_config.tsfiles including type import consistency, unused parameter naming, and node protocol usage - Removed unused imports, variables, and debug code (debugger statement)
Reviewed changes
Copilot reviewed 60 out of 61 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .oxlintrc.json | Added negation pattern to include _config.ts files in linting while keeping other fixtures excluded |
| packages/rolldown/tests/fixtures/verify-options/_config.ts | Changed to type-only import for types from 'rolldown' |
| packages/rolldown/tests/fixtures/tsconfig/virtual-module/tsconfig.json | Excluded _config.ts from TypeScript compilation for this fixture |
| packages/rolldown/tests/fixtures/tree-shake/minify/_config.ts | Removed unused vi import from vitest |
| packages/rolldown/tests/fixtures/tree-shake/external-module-side-effects-from-hook/_config.ts | Prefixed unused parameters with underscore |
| packages/rolldown/tests/fixtures/tree-shake/const-folding/_config.ts | Prefixed unused id parameter with underscore |
| packages/rolldown/tests/fixtures/topics/preserve-modules/tree-shake/_config.ts | Prefixed unused output parameter with underscore |
| packages/rolldown/tests/fixtures/topics/preserve-modules/sanitize-filename/_config.ts | New file with proper lint-compliant code |
| packages/rolldown/tests/fixtures/topics/preserve-modules/cjs-inter-op/_config.ts | Changed to type-only import for OutputChunk |
| packages/rolldown/tests/fixtures/topics/preserve-modules/basic/_config.ts | Changed to type-only import for OutputChunk |
| packages/rolldown/tests/fixtures/topics/preserve-entry-signature/emit-file/_config.ts | Removed unused expect import and prefixed unused parameters |
| packages/rolldown/tests/fixtures/plugin/transform/with-filter-nested/_config.ts | Changed to type-only import for RolldownPluginOption |
| packages/rolldown/tests/fixtures/plugin/transform/rewrite-module-type/_config.ts | Removed unused imports and variables, prefixed unused parameters |
| packages/rolldown/tests/fixtures/plugin/transform/composable/_config.ts | Changed to type-only import for Plugin |
| packages/rolldown/tests/fixtures/plugin/resolve-id/return-types/_config.ts | Removed unused Plugin type import |
| packages/rolldown/tests/fixtures/plugin/resolve-id/filter-importer-id/_config.ts | Removed unused calledArgs variable declaration |
| packages/rolldown/tests/fixtures/plugin/resolve-dynamic-import/resolve-id-fallback/_config.ts | Prefixed unused options parameter with underscore |
| packages/rolldown/tests/fixtures/plugin/resolve-dynamic-import/basic/_config.ts | Prefixed unused output parameter with underscore |
| packages/rolldown/tests/fixtures/plugin/render-chunk/basic/_config.ts | Changed to type-only import for RenderedChunk |
| packages/rolldown/tests/fixtures/plugin/prefer-builtin-feature/_config.ts | Prefixed unused ctx parameter and fixed trailing whitespace in snapshots |
| packages/rolldown/tests/fixtures/plugin/plugin-order/_config.ts | Changed to type-only import for Plugin |
| packages/rolldown/tests/fixtures/plugin/outro/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/plugin/outro-with-str/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/plugin/outro-with-obj/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/plugin/nested-and-async-plugin/_config.ts | Added oxlint-disable comment for intentional sparse array and prefixed unused parameter |
| packages/rolldown/tests/fixtures/plugin/load/with-module-type/_config.ts | Removed debugger statement and prefixed unused parameter |
| packages/rolldown/tests/fixtures/plugin/load/guess-module-type/_config.ts | Changed fs import to use node: protocol |
| packages/rolldown/tests/fixtures/plugin/load/filter-importer-id-error/_config.ts | Prefixed unused id parameter with underscore |
| packages/rolldown/tests/fixtures/plugin/load/basic/_config.ts | Prefixed unused parameters with underscore |
| packages/rolldown/tests/fixtures/plugin/intro/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/plugin/intro-with-str/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/plugin/intro-with-obj/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/plugin/hybrid-plugin/_config.ts | Changed to type-only import for RolldownPlugin |
| packages/rolldown/tests/fixtures/plugin/footer/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/plugin/footer-with-str/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/plugin/footer-with-obj/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/plugin/context/load/_config.ts | Prefixed unused output parameter with underscore |
| packages/rolldown/tests/fixtures/plugin/context/get-module-info/_config.ts | Changed to type-only import for GetModuleInfo |
| packages/rolldown/tests/fixtures/plugin/context/emit-file/_config.ts | Added oxlint-disable comment for legitimate unbound-method usage |
| packages/rolldown/tests/fixtures/plugin/context/emit-chunk/_config.ts | Prefixed unused output parameter with underscore |
| packages/rolldown/tests/fixtures/plugin/build-start/wait-for-build-start/_config.ts | Prefixed unused config parameter with underscore |
| packages/rolldown/tests/fixtures/plugin/banner/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/plugin/banner-with-str/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/plugin/banner-with-obj/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/output/paths/generate-bundle-imports/_config.ts | Removed unused RenderedChunk import |
| packages/rolldown/tests/fixtures/output/paths/generate-bundle-imports-function/_config.ts | Removed unused RenderedChunk import |
| packages/rolldown/tests/fixtures/output/hash-filenames/normal/_config.ts | Changed to type-only import for RenderedChunk |
| packages/rolldown/tests/fixtures/output/format/iife/exports/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/output/es-module/if-default-prop-true/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/output/es-module/if-default-prop-false/_config.ts | Removed unused vi import |
| packages/rolldown/tests/fixtures/output/asset-filenames/string/_config.ts | Removed unused getOutputFileNames import |
| packages/rolldown/tests/fixtures/misc/error/render-chunk/_config.ts | Removed unused assert import |
| packages/rolldown/tests/fixtures/misc/error/diagnostics/_config.ts | Changed util import to use node: protocol |
| packages/rolldown/tests/fixtures/issues/6398/_config.ts | Prefixed unused importer parameter with underscore |
| packages/rolldown/tests/fixtures/input/deduplicate/emit-file2/_config.ts | Removed unused getOutputChunkNames import |
| packages/rolldown/tests/fixtures/function/advanced-chunks/relative-path-name/_config.ts | Removed unused path import and dead code |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob/restore-query-extension/_config.ts | Changed path import to use node: protocol and changed to type-only import for RolldownOutput |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob/query/_config.ts | Changed path import to use node: protocol and changed to type-only import for RolldownOutput |
| packages/rolldown/tests/fixtures/builtin-plugin/import-glob/query-object/_config.ts | Changed path import to use node: protocol and changed to type-only import for RolldownOutput |
| packages/rolldown/tests/fixtures/builtin-plugin/bundle-analyzer/_config.ts | Added type import for OutputAsset and improved inline type usage |
| packages/rolldown/tests/fixtures/builtin-plugin/bundle-analyzer-custom-filename/_config.ts | Added type import for OutputAsset and improved inline type usage |
fef3a0a to
440d0ce
Compare
hyf0
approved these changes
Feb 19, 2026
Member
Author
Merge activity
|
Enable lint for `_config.ts` files for #8387.
440d0ce to
252cd42
Compare
This was referenced Feb 25, 2026
Closed
Closed
Merged
shulaoda
added a commit
that referenced
this pull request
Feb 26, 2026
## [1.0.0-rc.6] - 2026-02-26 ### 💥 BREAKING CHANGES - css: remove `css_entry_filenames` , `css_chunk_filenames` and related code (#8402) by @hyf0 - css: drop builtin CSS bundling to explore alternative solutions (#8399) by @hyf0 ### 🚀 Features - rust/data-url: use hash as id for data url modules to prevent long string overhead (#8420) by @hyf0 - validate bundle stays within output dir (#8441) by @sapphi-red - rust: support `PluginOrder::PinPost` (#8417) by @hyf0 - support `ModuleType:Copy` (#8407) by @hyf0 - expose `ESTree` types from `rolldown/utils` (#8400) by @sapphi-red ### 🐛 Bug Fixes - incorrect sourcemap when postBanner/postFooter is used with shebang (#8459) by @Copilot - resolver: disable node_path option to align ESM resolver behavior (#8472) by @sapphi-red - parse `.js` within `"type": "commonjs"` as ESM for now (#8470) by @sapphi-red - case-insensitive filename conflict detection for chunk deduplication (#8458) by @Copilot - prevent inlining CJS exports that are mutated by importers (#8456) by @IWANABETHATGUY - parse `.cjs` / `.cts` / `.js` within `"type": "commonjs"` as CommonJS (#8455) by @sapphi-red - plugin/copy-module: correct hooks' priority (#8423) by @hyf0 - plugin/chunk-import-map: ensure `render_chunk_meta` run after users plugin (#8422) by @hyf0 - rust: correct hooks order of `DataUriPlugin` (#8418) by @hyf0 - `jsx.preserve` should also considering tsconfig json preserve (#8324) by @IWANABETHATGUY - `deferred_scan_data.rs "Should have resolved id: NotFound"` error (#8379) by @sapphi-red - cli: require value for `--dir`/`-d` and `--file`/`-o` (#8378) by @Copilot - dev: avoid mutex deadlock caused by inconsistent lock order (#8370) by @sapphi-red ### 🚜 Refactor - watch: rename TaskStart/TaskEnd to BundleStart/BundleEnd (#8463) by @hyf0 - rust: rename `rolldown_plugin_data_uri` to `rolldown_plugin_data_url` (#8421) by @hyf0 - bindingify-build-hook: extract helper for PluginContextImpl (#8438) by @ShroXd - give source loading a proper name (#8436) by @IWANABETHATGUY - ban holding DashMap refs across awaits (#8362) by @sapphi-red ### 📚 Documentation - add glob pattern usage example to input option (#8469) by @IWANABETHATGUY - remove `https://rolldown.rs` from links in reference docs (#8454) by @sapphi-red - mention execution order issue in `output.codeSplitting` docs (#8452) by @sapphi-red - clarify `output.comments` behavior a bit (#8451) by @sapphi-red - replace npmjs package links with npmx.dev (#8439) by @Boshen - reference: add `Exported from` for values / types exported from subpath exports (#8394) by @sapphi-red - add JSDocs for APIs exposed from subpath exports (#8393) by @sapphi-red - reference: generate reference pages for APIs exposed from subpath exports (#8392) by @sapphi-red - avoid pipe character in codeSplitting example to fix broken rendering (#8391) by @IWANABETHATGUY ### ⚡ Performance - avoid redundant PathBuf allocations in resolve paths (#8435) by @Brooooooklyn - bump to `sugar_path@2` (#8432) by @hyf0 - use flag-based convergence detection in include_statements (#8412) by @Brooooooklyn ### 🧪 Testing - execute `_test.mjs` even if `executeOutput` is false (#8398) by @sapphi-red - add retry to tree-shake/module-side-effects-proxy4 as it is flaky (#8397) by @sapphi-red - avoid `expect.assertions()` as it is not concurrent test friendly (#8383) by @sapphi-red - disable `mockReset` option (#8382) by @sapphi-red - fix flaky failure caused by concurrent resolveId calls (#8381) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency rollup to v4.59.0 [security] (#8471) by @renovate[bot] - ai/design: add design doc about watch mode (#8453) by @hyf0 - deps: update oxc resolver to v11.19.0 (#8461) by @renovate[bot] - ai: introduce progressive spec-driven development pattern (#8446) by @hyf0 - deprecate output.legalComments (#8450) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.15.0 (#8448) by @renovate[bot] - ai: make CLAUDE.md a symlink of AGENTS.md (#8445) by @hyf0 - deps: update rollup submodule for tests to v4.59.0 (#8433) by @sapphi-red - deps: update test262 submodule for tests (#8434) by @sapphi-red - deps: update oxc to v0.115.0 (#8430) by @renovate[bot] - deps: update oxc apps (#8429) by @renovate[bot] - deps: update npm packages (#8426) by @renovate[bot] - deps: update rust crate owo-colors to v4.3.0 (#8428) by @renovate[bot] - deps: update github-actions (#8424) by @renovate[bot] - deps: update rust crates (#8425) by @renovate[bot] - deps: update oxc resolver to v11.18.0 (#8406) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.14.2 (#8405) by @renovate[bot] - ban `expect.assertions` in all fixture tests (#8395) by @sapphi-red - deps: update oxc apps (#8389) by @renovate[bot] - ban `expect.assertions` in fixture tests (#8387) by @sapphi-red - enable lint for `_config.ts` files (#8386) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.14.1 (#8385) by @renovate[bot] Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable lint for
_config.tsfiles for #8387.