feat(rust/data-url): use hash as id for data url modules to prevent long string overhead by hyf0 · Pull Request #8420 · rolldown/rolldown

hyf0 · 2026-02-22T10:34:44Z

3 things:

Use shorter hash as the module to reduce overhead of long data url modules
data url plugin should only load modules that it handled, not general pattern
imports inside of data-url shouldn't be resolveable

hyf0 · 2026-02-22T10:35:01Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR optimizes the data URL plugin by using content-based hashes as module IDs instead of full data URL strings, reducing overhead and improving code readability.

Changes:

Replace full data URL strings as module IDs with shorter hash-based IDs using the pattern \0rolldown/data-url:{hash}
Optimize the load hook to only check the plugin's own resolved modules map instead of checking all modules with is_data_url()
Update the resolved_data_uri map to use ArcStr keys for consistency

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/rolldown_plugin_data_uri/src/lib.rs	Core implementation: generates hash-based IDs for data URLs and optimizes load hook
crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap	Updated snapshot reflecting new hash-based IDs in output filenames
crates/rolldown/tests/rolldown/issues/2300/artifacts.snap	Updated snapshot showing new module ID format and variable naming
crates/rolldown/tests/esbuild/loader/loader_data_url_text_java_script_plus_character/artifacts.snap	Updated snapshot with hash-based region comments
crates/rolldown/tests/esbuild/loader/loader_data_url_text_java_script_cannot_import/artifacts.snap	New or updated snapshot
crates/rolldown/tests/esbuild/loader/loader_data_url_text_java_script/artifacts.snap	Updated snapshot showing hash-based module IDs
crates/rolldown/tests/esbuild/loader/loader_data_url_application_json/artifacts.snap	Updated snapshot with consistent hash-based naming

github-actions · 2026-02-22T10:50:46Z

Benchmarks Rust

target: main(66269b1)
pr: 02-22-feat_rust_data-url_use_hash_as_id_for_data_url_modules_to_prevent_long_string_overhead(d18a000)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     67.4±3.36ms        ? ?/sec    1.00     66.1±2.48ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03     74.1±2.51ms        ? ?/sec    1.00     71.8±3.15ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00     97.5±3.52ms        ? ?/sec    1.00     97.3±2.32ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    108.8±2.84ms        ? ?/sec    1.00    107.6±2.28ms        ? ?/sec
bundle/bundle@threejs                                        1.04     37.4±2.60ms        ? ?/sec    1.00     36.0±0.86ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.05     40.9±1.35ms        ? ?/sec    1.00     39.1±0.92ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    363.0±7.51ms        ? ?/sec    1.00    364.5±9.13ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00   414.2±10.54ms        ? ?/sec    1.00    416.0±8.76ms        ? ?/sec
scan/scan@rome_ts                                            1.00     76.2±2.60ms        ? ?/sec    1.03     78.6±2.12ms        ? ?/sec
scan/scan@threejs                                            1.00     27.5±0.54ms        ? ?/sec    1.00     27.4±0.89ms        ? ?/sec
scan/scan@threejs10x                                         1.00    274.6±5.42ms        ? ?/sec    1.00    275.5±6.61ms        ? ?/sec

.../rolldown/tests/esbuild/loader/loader_data_url_text_java_script_cannot_import/artifacts.snap

crates/rolldown_plugin/src/utils/resolve_id_with_plugins.rs

crates/rolldown_plugin/src/utils/resolve_id_check_external.rs

netlify · 2026-02-24T08:06:19Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`4776b5c`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/699da773238ca100080cfb20

Copilot · 2026-02-24T12:28:09Z

@hyf0 I've opened a new pull request, #8443, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

graphite-app · 2026-02-24T13:21:48Z

Merge activity

Feb 24, 1:21 PM UTC: hyf0 added this pull request to the Graphite merge queue.
Feb 24, 1:38 PM UTC: Merged by the Graphite merge queue.

…ong string overhead (#8420) 3 things: - Use shorter hash as the module to reduce overhead of long data url modules - data url plugin should only `load` modules that it handled, not general pattern - `imports` inside of `data-url` shouldn't be resolveable

@hyf0

## [1.0.0-rc.6] - 2026-02-26 ### 💥 BREAKING CHANGES - css: remove `css_entry_filenames` , `css_chunk_filenames` and related code (#8402) by @hyf0 - css: drop builtin CSS bundling to explore alternative solutions (#8399) by @hyf0 ### 🚀 Features - rust/data-url: use hash as id for data url modules to prevent long string overhead (#8420) by @hyf0 - validate bundle stays within output dir (#8441) by @sapphi-red - rust: support `PluginOrder::PinPost` (#8417) by @hyf0 - support `ModuleType:Copy` (#8407) by @hyf0 - expose `ESTree` types from `rolldown/utils` (#8400) by @sapphi-red ### 🐛 Bug Fixes - incorrect sourcemap when postBanner/postFooter is used with shebang (#8459) by @Copilot - resolver: disable node_path option to align ESM resolver behavior (#8472) by @sapphi-red - parse `.js` within `"type": "commonjs"` as ESM for now (#8470) by @sapphi-red - case-insensitive filename conflict detection for chunk deduplication (#8458) by @Copilot - prevent inlining CJS exports that are mutated by importers (#8456) by @IWANABETHATGUY - parse `.cjs` / `.cts` / `.js` within `"type": "commonjs"` as CommonJS (#8455) by @sapphi-red - plugin/copy-module: correct hooks' priority (#8423) by @hyf0 - plugin/chunk-import-map: ensure `render_chunk_meta` run after users plugin (#8422) by @hyf0 - rust: correct hooks order of `DataUriPlugin` (#8418) by @hyf0 - `jsx.preserve` should also considering tsconfig json preserve (#8324) by @IWANABETHATGUY - `deferred_scan_data.rs "Should have resolved id: NotFound"` error (#8379) by @sapphi-red - cli: require value for `--dir`/`-d` and `--file`/`-o` (#8378) by @Copilot - dev: avoid mutex deadlock caused by inconsistent lock order (#8370) by @sapphi-red ### 🚜 Refactor - watch: rename TaskStart/TaskEnd to BundleStart/BundleEnd (#8463) by @hyf0 - rust: rename `rolldown_plugin_data_uri` to `rolldown_plugin_data_url` (#8421) by @hyf0 - bindingify-build-hook: extract helper for PluginContextImpl (#8438) by @ShroXd - give source loading a proper name (#8436) by @IWANABETHATGUY - ban holding DashMap refs across awaits (#8362) by @sapphi-red ### 📚 Documentation - add glob pattern usage example to input option (#8469) by @IWANABETHATGUY - remove `https://rolldown.rs` from links in reference docs (#8454) by @sapphi-red - mention execution order issue in `output.codeSplitting` docs (#8452) by @sapphi-red - clarify `output.comments` behavior a bit (#8451) by @sapphi-red - replace npmjs package links with npmx.dev (#8439) by @Boshen - reference: add `Exported from` for values / types exported from subpath exports (#8394) by @sapphi-red - add JSDocs for APIs exposed from subpath exports (#8393) by @sapphi-red - reference: generate reference pages for APIs exposed from subpath exports (#8392) by @sapphi-red - avoid pipe character in codeSplitting example to fix broken rendering (#8391) by @IWANABETHATGUY ### ⚡ Performance - avoid redundant PathBuf allocations in resolve paths (#8435) by @Brooooooklyn - bump to `sugar_path@2` (#8432) by @hyf0 - use flag-based convergence detection in include_statements (#8412) by @Brooooooklyn ### 🧪 Testing - execute `_test.mjs` even if `executeOutput` is false (#8398) by @sapphi-red - add retry to tree-shake/module-side-effects-proxy4 as it is flaky (#8397) by @sapphi-red - avoid `expect.assertions()` as it is not concurrent test friendly (#8383) by @sapphi-red - disable `mockReset` option (#8382) by @sapphi-red - fix flaky failure caused by concurrent resolveId calls (#8381) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency rollup to v4.59.0 [security] (#8471) by @renovate[bot] - ai/design: add design doc about watch mode (#8453) by @hyf0 - deps: update oxc resolver to v11.19.0 (#8461) by @renovate[bot] - ai: introduce progressive spec-driven development pattern (#8446) by @hyf0 - deprecate output.legalComments (#8450) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.15.0 (#8448) by @renovate[bot] - ai: make CLAUDE.md a symlink of AGENTS.md (#8445) by @hyf0 - deps: update rollup submodule for tests to v4.59.0 (#8433) by @sapphi-red - deps: update test262 submodule for tests (#8434) by @sapphi-red - deps: update oxc to v0.115.0 (#8430) by @renovate[bot] - deps: update oxc apps (#8429) by @renovate[bot] - deps: update npm packages (#8426) by @renovate[bot] - deps: update rust crate owo-colors to v4.3.0 (#8428) by @renovate[bot] - deps: update github-actions (#8424) by @renovate[bot] - deps: update rust crates (#8425) by @renovate[bot] - deps: update oxc resolver to v11.18.0 (#8406) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.14.2 (#8405) by @renovate[bot] - ban `expect.assertions` in all fixture tests (#8395) by @sapphi-red - deps: update oxc apps (#8389) by @renovate[bot] - ban `expect.assertions` in fixture tests (#8387) by @sapphi-red - enable lint for `_config.ts` files (#8386) by @sapphi-red - deps: update dependency oxlint-tsgolint to v0.14.1 (#8385) by @renovate[bot] Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

github-actions bot assigned hyf0 Feb 22, 2026

hyf0 mentioned this pull request Feb 22, 2026

feat(rust): support PluginOrder::PinPost #8417

Merged

hyf0 mentioned this pull request Feb 22, 2026

fix(rust): correct hooks order of DataUriPlugin #8418

Merged

hyf0 marked this pull request as ready for review February 22, 2026 10:35

Copilot AI review requested due to automatic review settings February 22, 2026 10:35

Copilot started reviewing on behalf of hyf0 February 22, 2026 10:36 View session

Copilot AI reviewed Feb 22, 2026

View reviewed changes

hyf0 requested a review from shulaoda February 22, 2026 10:40

hyf0 force-pushed the 02-22-feat_rust_data-url_use_hash_as_id_for_data_url_modules_to_prevent_long_string_overhead branch from ee81fbb to 6549a05 Compare February 22, 2026 11:09

hyf0 commented Feb 22, 2026

View reviewed changes

.../rolldown/tests/esbuild/loader/loader_data_url_text_java_script_cannot_import/artifacts.snap Show resolved Hide resolved

hyf0 requested a review from sapphi-red February 22, 2026 11:25

This was referenced Feb 22, 2026

refactor(rust): rename rolldown_plugin_data_uri to rolldown_plugin_data_url #8421

Merged

fix(plugin/chunk-import-map): ensure render_chunk_meta run after users plugin #8422

Merged

fix(plugin/copy-module): correct hooks' priority #8423

Merged

sapphi-red reviewed Feb 24, 2026

View reviewed changes

crates/rolldown_plugin/src/utils/resolve_id_with_plugins.rs Show resolved Hide resolved

crates/rolldown_plugin/src/utils/resolve_id_check_external.rs Show resolved Hide resolved

graphite-app bot changed the base branch from 02-22-fix_rust_correct_hooks_order_of_datauriplugin_ to graphite-base/8420 February 24, 2026 07:53

graphite-app bot force-pushed the graphite-base/8420 branch from cf44664 to 66269b1 Compare February 24, 2026 08:05

graphite-app bot force-pushed the 02-22-feat_rust_data-url_use_hash_as_id_for_data_url_modules_to_prevent_long_string_overhead branch from 6549a05 to 503c837 Compare February 24, 2026 08:05

graphite-app bot changed the base branch from graphite-base/8420 to main February 24, 2026 08:06

graphite-app bot force-pushed the 02-22-feat_rust_data-url_use_hash_as_id_for_data_url_modules_to_prevent_long_string_overhead branch from 503c837 to d18a000 Compare February 24, 2026 08:06

hyf0 requested a review from sapphi-red February 24, 2026 12:21

sapphi-red approved these changes Feb 24, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 24, 2026

test(data-url): verify plugins can resolve imports from data URL modules #8443

Draft

hyf0 added the graphite: merge-when-ready label Feb 24, 2026

Copilot AI review requested due to automatic review settings February 24, 2026 13:11

hyf0 force-pushed the 02-22-feat_rust_data-url_use_hash_as_id_for_data_url_modules_to_prevent_long_string_overhead branch from d18a000 to e8c3e87 Compare February 24, 2026 13:11

Copilot started reviewing on behalf of hyf0 February 24, 2026 13:11 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

graphite-app bot force-pushed the 02-22-feat_rust_data-url_use_hash_as_id_for_data_url_modules_to_prevent_long_string_overhead branch from e8c3e87 to 4776b5c Compare February 24, 2026 13:28

graphite-app bot merged commit 4776b5c into main Feb 24, 2026
34 checks passed

graphite-app bot deleted the 02-22-feat_rust_data-url_use_hash_as_id_for_data_url_modules_to_prevent_long_string_overhead branch February 24, 2026 13:38

graphite-app bot removed the graphite: merge-when-ready label Feb 24, 2026

This was referenced Feb 25, 2026

release: v1.0.0-rc.6 #8449

Closed

release: v1.0.0-rc.6 #8473

Closed

release: v1.0.0-rc.6 #8474

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rust/data-url): use hash as id for data url modules to prevent long string overhead#8420

feat(rust/data-url): use hash as id for data url modules to prevent long string overhead#8420
graphite-app[bot] merged 1 commit intomainfrom
02-22-feat_rust_data-url_use_hash_as_id_for_data_url_modules_to_prevent_long_string_overhead

hyf0 commented Feb 22, 2026 •

edited

Loading

Uh oh!

hyf0 commented Feb 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Feb 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Feb 24, 2026 •

edited

Loading

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app bot commented Feb 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hyf0 commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hyf0 commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

graphite-app bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hyf0 commented Feb 22, 2026 •

edited

Loading

hyf0 commented Feb 22, 2026 •

edited

Loading

github-actions bot commented Feb 22, 2026 •

edited

Loading

netlify bot commented Feb 24, 2026 •

edited

Loading

graphite-app bot commented Feb 24, 2026 •

edited

Loading