Skip to content

refactor: ban holding DashMap refs across awaits#8362

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-17-refactor_ban_holding_dashmap_refs_across_awaits
Feb 19, 2026
Merged

refactor: ban holding DashMap refs across awaits#8362
graphite-app[bot] merged 1 commit intomainfrom
02-17-refactor_ban_holding_dashmap_refs_across_awaits

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Feb 17, 2026

close #7311
refs #7289

TODO: try this PR in more places.

Copy link
Member Author

sapphi-red commented Feb 17, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Feb 17, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 206fda7
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69946426064a9900084b11f6

@sapphi-red sapphi-red force-pushed the 02-17-refactor_ban_holding_dashmap_refs_across_awaits branch from b5df068 to 206fda7 Compare February 17, 2026 12:50
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 17, 2026

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@8362

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@8362

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@8362

rolldown

npm i https://pkg.pr.new/rolldown@8362

@rolldown/binding-android-arm64

npm i https://pkg.pr.new/@rolldown/binding-android-arm64@8362

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@8362

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@8362

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@8362

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@8362

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@8362

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@8362

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@8362

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@8362

@rolldown/binding-openharmony-arm64

npm i https://pkg.pr.new/@rolldown/binding-openharmony-arm64@8362

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@8362

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@8362

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@8362

commit: c1dbe5d

@sapphi-red sapphi-red changed the base branch from main to graphite-base/8362 February 18, 2026 10:59
@sapphi-red sapphi-red force-pushed the 02-17-refactor_ban_holding_dashmap_refs_across_awaits branch from 206fda7 to c1dbe5d Compare February 18, 2026 10:59
@sapphi-red sapphi-red changed the base branch from graphite-base/8362 to 02-18-fix_dev_avoid_mutex_deadlock_caused_by_inconsistent_lock_order February 18, 2026 11:00
@sapphi-red sapphi-red marked this pull request as ready for review February 18, 2026 11:43
@sapphi-red sapphi-red requested a review from hyf0 February 18, 2026 11:43
@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: 02-18-fix_dev_avoid_mutex_deadlock_caused_by_inconsistent_lock_order(23afd7b)
  • pr: 02-17-refactor_ban_holding_dashmap_refs_across_awaits(c1dbe5d)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     66.0±1.48ms        ? ?/sec    1.03     68.0±3.25ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     73.3±2.13ms        ? ?/sec    1.02     74.5±1.67ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00     96.4±2.48ms        ? ?/sec    1.01     97.7±2.00ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    109.1±1.80ms        ? ?/sec    1.00    108.0±1.55ms        ? ?/sec
bundle/bundle@threejs                                        1.00     36.0±2.21ms        ? ?/sec    1.00     36.1±1.99ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     40.2±0.60ms        ? ?/sec    1.02     41.1±1.31ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    353.2±6.07ms        ? ?/sec    1.01    358.3±6.81ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    421.8±4.94ms        ? ?/sec    1.00    421.7±7.26ms        ? ?/sec
scan/scan@rome_ts                                            1.00     76.0±1.20ms        ? ?/sec    1.01     77.0±3.23ms        ? ?/sec
scan/scan@threejs                                            1.00     27.0±1.69ms        ? ?/sec    1.00     26.9±0.54ms        ? ?/sec
scan/scan@threejs10x                                         1.00    266.3±2.51ms        ? ?/sec    1.00    267.5±4.70ms        ? ?/sec

Copy link
Member Author

sapphi-red commented Feb 19, 2026

Merge activity

  • Feb 19, 2:13 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 19, 2:13 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Feb 19, 2:27 AM UTC: Merged by the Graphite merge queue.

close #7311
refs #7289

~~TODO: try this PR in more places.~~
@graphite-app graphite-app bot force-pushed the 02-18-fix_dev_avoid_mutex_deadlock_caused_by_inconsistent_lock_order branch from 23afd7b to fc69283 Compare February 19, 2026 02:14
@graphite-app graphite-app bot force-pushed the 02-17-refactor_ban_holding_dashmap_refs_across_awaits branch from c1dbe5d to edaac76 Compare February 19, 2026 02:14
Base automatically changed from 02-18-fix_dev_avoid_mutex_deadlock_caused_by_inconsistent_lock_order to main February 19, 2026 02:25
@graphite-app graphite-app bot merged commit edaac76 into main Feb 19, 2026
31 checks passed
@graphite-app graphite-app bot deleted the 02-17-refactor_ban_holding_dashmap_refs_across_awaits branch February 19, 2026 02:27
shulaoda added a commit that referenced this pull request Feb 26, 2026
## [1.0.0-rc.6] - 2026-02-26

### 💥 BREAKING CHANGES

- css: remove `css_entry_filenames` , `css_chunk_filenames` and related code (#8402) by @hyf0
- css: drop builtin CSS bundling to explore alternative solutions (#8399) by @hyf0

### 🚀 Features

- rust/data-url: use hash as id for data url modules to prevent long string overhead (#8420) by @hyf0
- validate bundle stays within output dir (#8441) by @sapphi-red
- rust: support `PluginOrder::PinPost` (#8417) by @hyf0
- support `ModuleType:Copy` (#8407) by @hyf0
- expose `ESTree` types from `rolldown/utils` (#8400) by @sapphi-red

### 🐛 Bug Fixes

- incorrect sourcemap when postBanner/postFooter is used with shebang (#8459) by @Copilot
- resolver: disable node_path option to align ESM resolver behavior (#8472) by @sapphi-red
- parse `.js` within `"type": "commonjs"` as ESM for now (#8470) by @sapphi-red
- case-insensitive filename conflict detection for chunk deduplication (#8458) by @Copilot
- prevent inlining CJS exports that are mutated by importers (#8456) by @IWANABETHATGUY
- parse `.cjs` / `.cts` / `.js` within `"type": "commonjs"` as CommonJS (#8455) by @sapphi-red
- plugin/copy-module: correct hooks' priority (#8423) by @hyf0
- plugin/chunk-import-map: ensure `render_chunk_meta` run after users plugin (#8422) by @hyf0
- rust: correct hooks order of `DataUriPlugin` (#8418) by @hyf0
- `jsx.preserve` should also considering tsconfig json preserve (#8324) by @IWANABETHATGUY
- `deferred_scan_data.rs "Should have resolved id: NotFound"` error (#8379) by @sapphi-red
- cli: require value for `--dir`/`-d` and `--file`/`-o` (#8378) by @Copilot
- dev: avoid mutex deadlock caused by inconsistent lock order (#8370) by @sapphi-red

### 🚜 Refactor

- watch: rename TaskStart/TaskEnd to BundleStart/BundleEnd (#8463) by @hyf0
- rust: rename `rolldown_plugin_data_uri` to `rolldown_plugin_data_url` (#8421) by @hyf0
- bindingify-build-hook: extract helper for PluginContextImpl (#8438) by @ShroXd
- give source loading a proper name (#8436) by @IWANABETHATGUY
- ban holding DashMap refs across awaits (#8362) by @sapphi-red

### 📚 Documentation

- add glob pattern usage example to input option (#8469) by @IWANABETHATGUY
- remove `https://rolldown.rs` from links in reference docs (#8454) by @sapphi-red
- mention execution order issue in `output.codeSplitting` docs (#8452) by @sapphi-red
- clarify `output.comments` behavior a bit (#8451) by @sapphi-red
- replace npmjs package links with npmx.dev (#8439) by @Boshen
- reference: add `Exported from` for values / types exported from subpath exports (#8394) by @sapphi-red
- add JSDocs for APIs exposed from subpath exports (#8393) by @sapphi-red
- reference: generate reference pages for APIs exposed from subpath exports (#8392) by @sapphi-red
- avoid pipe character in codeSplitting example to fix broken rendering (#8391) by @IWANABETHATGUY

### ⚡ Performance

- avoid redundant PathBuf allocations in resolve paths (#8435) by @Brooooooklyn
- bump to `sugar_path@2` (#8432) by @hyf0
- use flag-based convergence detection in include_statements (#8412) by @Brooooooklyn

### 🧪 Testing

- execute `_test.mjs` even if `executeOutput` is false (#8398) by @sapphi-red
- add retry to tree-shake/module-side-effects-proxy4 as it is flaky (#8397) by @sapphi-red
- avoid `expect.assertions()` as it is not concurrent test friendly (#8383) by @sapphi-red
- disable `mockReset` option (#8382) by @sapphi-red
- fix flaky failure caused by concurrent resolveId calls (#8381) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update dependency rollup to v4.59.0 [security] (#8471) by @renovate[bot]
- ai/design: add design doc about watch mode (#8453) by @hyf0
- deps: update oxc resolver to v11.19.0 (#8461) by @renovate[bot]
- ai: introduce progressive spec-driven development pattern (#8446) by @hyf0
- deprecate output.legalComments (#8450) by @sapphi-red
- deps: update dependency oxlint-tsgolint to v0.15.0 (#8448) by @renovate[bot]
- ai: make CLAUDE.md a symlink of AGENTS.md (#8445) by @hyf0
- deps: update rollup submodule for tests to v4.59.0 (#8433) by @sapphi-red
- deps: update test262 submodule for tests (#8434) by @sapphi-red
- deps: update oxc to v0.115.0 (#8430) by @renovate[bot]
- deps: update oxc apps (#8429) by @renovate[bot]
- deps: update npm packages (#8426) by @renovate[bot]
- deps: update rust crate owo-colors to v4.3.0 (#8428) by @renovate[bot]
- deps: update github-actions (#8424) by @renovate[bot]
- deps: update rust crates (#8425) by @renovate[bot]
- deps: update oxc resolver to v11.18.0 (#8406) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.14.2 (#8405) by @renovate[bot]
- ban `expect.assertions` in all fixture tests (#8395) by @sapphi-red
- deps: update oxc apps (#8389) by @renovate[bot]
- ban `expect.assertions` in fixture tests (#8387) by @sapphi-red
- enable lint for `_config.ts` files (#8386) by @sapphi-red
- deps: update dependency oxlint-tsgolint to v0.14.1 (#8385) by @renovate[bot]

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audit: Review sync NAPI bindings for deadlock safety

2 participants