feat(formatter_graphql): implement oxc_formatter_graphql by leaysgur · Pull Request #23317 · oxc-project/oxc

leaysgur · 2026-06-12T07:35:00Z

Implement oxc_formatter_graphql crate
Use apollo-parser crate from apollo-rs
- https://github.com/apollographql/apollo-rs
- Which follows Oct2021 spec
Prettier uses graphql-js and implements more and more syntax
- v16 for latest = 3.8.4 and v17 for main = 3.9.x

NOTE: So at the point of this PR, diffs can be seen as skipped in prettier_conformance.
Will be addressed in later PR by forking apollo-parser.

leaysgur · 2026-06-12T07:35:15Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-06-12T07:43:02Z

Merging this PR will not alter performance

✅ 57 untouched benchmarks
⏩ 14 skipped benchmarks¹

_{Comparing 06-10-feat_formatter_graphql_implement_oxc_formatter_graphql (81cc62e) with main (e1f89ab)}

14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

graphite-app · 2026-06-29T02:38:13Z

Merge activity

Jun 29, 2:38 AM UTC: graphite-app added this pull request to the Graphite merge queue.
Jun 29, 2:53 AM UTC: Merged by the Graphite merge queue.

- Implement `oxc_formatter_graphql` crate - Use `apollo-parser` crate from `apollo-rs` - https://github.com/apollographql/apollo-rs - Which follows Oct2021 spec - Prettier uses `graphql-js` and implements more and more syntax - v16 for `latest = 3.8.4` and v17 for `main = 3.9.x` NOTE: So at the point of this PR, diffs can be seen as skipped in prettier_conformance. Will be addressed in later PR by forking `apollo-parser`.

…#23318) - Use `oxc_formatter_graphql` from Oxfmt to handle `.gql` and `.graphql` files - At point of this PR, gql-in-js is still handled by Prettier As described in #23317, Prettier supports more syntax than ours, so for now fallback to Prettier when `oxc_formatter_graphql` failed to format. NOTE: This fallback will be removed in later PR.

# Oxlint ### 💥 BREAKING CHANGES - 88f4455 str: [**BREAKING**] `Str` and `Ident` methods take `&GetAllocator` (#23781) (overlookmotel) ### 🚀 Features - f2091b3 ast: Unify old and new `AstBuilder`s (#23875) (overlookmotel) - 1c8f50c linter: Add schema for `eslint/no-restricted-import` (#23642) (Sysix) ### 🐛 Bug Fixes - 7cb85c4 linter/eslint/no-negated-condition: Add autofix for negated conditions (#23825) (Yagiz Nizipli) - f7d1f50 oxlint, oxfmt: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate (#23886) (overlookmotel) - d891990 linter/jsx-a11y/role-supports-aria-props: Ignore nullish prop values (#23865) (Mikhail Baev) - 94b6599 linter: Deduplicate missing plugin errors (#23853) (camc314) - eff3eff linter/oxc/branches-sharing-code: Avoid else-if false positives (#23843) (camc314) - 2a2d3b9 linter/eslint/prefer-destructuring: Skip `AssignmentExpression` autofixes (#23818) (camc314) - ddc24ae linter/eslint/id-length: Respect checkGeneric for mapped type keys (#23802) (bab) - cd89202 linter/react/exhaustive-deps: Skip wrapper expression when analyzing hook initializers (#23793) (camc314) - 20e8285 linter/unicorn/prefer-native-coercion-function: Allow ts type predicates (#23774) (camc314) - d86f60b lsp: Normalize user config path to watch pattern (#23723) (Sysix) - 52032cf linter: Newline-terminate tsgolint errors (#23762) (Mikhail Baev) - 368fda7 linter/eslint/no-warning-comments: Avoid dropping generated regex patterns (#23741) (camc314) - ce44fbd linter/valid-title: Escape disallowed words regex (#23742) (camc314) - 3100d11 linter/prefer-called-exactly-once-with: Avoid out-of-bounds slice panic at end of file (#23625) (Jerry Zhao) - 742be36 refactor/node/handle-callback-err: Reject invalid regex config (#23740) (camc314) - d7be179 linter/eslint/no-restricted-globals: Handle shadowed locals (#23736) (camc314) - b3b1ff8 linter/vitest/expect-expect: Handle global vitest detection correctly (#23734) (camc314) ### ⚡ Performance - 68f9472 linter/jsx-a11y: Skip lowercasing non-aria attribute names (#23906) (Lawrence Lin) - b9312b4 linter/unicorn/prefer-export-from: Use keyed binding lookup (#23893) (Marius Schulz) - cd5204e linter/typescript/no-unsafe-declaration-merging: Use keyed binding lookup (#23894) (Marius Schulz) - e948498 linter/eslint/prefer-named-capture-group: Only dispatch for relevant node types (#23868) (Connor Shea) - 4ac7a8e linter/eslint/max-depth: Derive node types (#23896) (Connor Shea) - daeed09 linter/eslint/no-restricted-globals: Only scan unresolved references (#23890) (camc314) - e808514 linter/jest-vitest: Speed up no-standalone-expect (#23883) (camc314) - 8b165e5 linter/react/exhaustive-deps: Skip non-reactive calls early (#23882) (camc314) - 54005e7 linter/eslint/no-unused-vars: Precompute exported bindings (#23881) (camc314) - 9bc2f8c linter/unicorn/prefer-number-properties: Speed up global checks (#23880) (camc314) - 4ff104f linter: Optimize `require-hook` and `prefer-mock-*` rules to run on specific node types (#23871) (Connor Shea) - cc2213b linter: Run `no-underscore-dangle` only when relevant node types are present (#23867) (Connor Shea) - 3e55c21 linter/promise/always-return: Narrow to function node types (#23878) (Connor Shea) - 7136182 linter/jest-vitest: Speed up no-commented-out-tests (#23864) (camc314) - f138264 linter/eslint/no-script-url: Match javascript: prefix without allocating (#23861) (Lawrence Lin) - 7ef6895 linter/react/no-array-index-key: Delay index symbol lookup (#23857) (camc314) - 26bc171 linter/react/no-array-index-key: Match callback methods directly (#23856) (camc314) - 44fbbda linter/jsx-a11y/interactive-supports-focus: Check cheap conditions first (#23854) (camc314) - 84a5aa3 linter/eslint/no-extend-native: Skip lowercase references early (#23851) (camc314) - 88a74b2 linter/eslint/no-nonoctal-decimal-escape: Scan decimal escapes as bytes (#23850) (camc314) - fca69a8 linter: Skip traversal without this expressions (#23845) (camc314) - 838fd63 linter: Reduce preallocation for per-file diagnostics `Vec` (#23705) (Marius Schulz) - 417b506 linter/typescript/array-type: Remove full source text clone (#23751) (Marius Schulz) ### 📚 Documentation - 57e4469 linter/unicorn: Update prefer-dom-node-text-content rationale (#23933) (Mikhail Baev) - 3d61dea all: Correct capitalization in comments (#23887) (overlookmotel) ### 🛡️ Security - 3cdd18f deps: Update npm packages (#23690) (renovate[bot]) # Oxfmt ### 💥 BREAKING CHANGES - 259e0cd oxfmt,formatter_graphql: [**BREAKING**] Support draft syntax with removing prettier fallback (#23326) (leaysgur) - accbc49 oxfmt: [**BREAKING**] Format `parser:css,less,scss` files + css-in-js by `oxc_formatter_css` (#23321) (leaysgur) ### 🚀 Features - dffa4b3 formatter_css: Implement `oxc_formatter_css` (#23320) (leaysgur) - 01de9ec oxfmt: Format `parser:graphql` files by `oxc_formatter_graphql` (#23318) (leaysgur) - 4e66212 formatter_graphql: Implement oxc_formatter_graphql (#23317) (leaysgur) ### 🐛 Bug Fixes - 67325ae formatter_css: Handle frontmatter language (#23819) (leaysgur) - 3f355e5 formatter_graphql: Improve major prettier diffs (#23419) (leaysgur) - 48e2d78 formatter_css: Improve major prettier diffs (#23327) (leaysgur) - 8c07cad all: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate in tests (#23888) (overlookmotel) - f7d1f50 oxlint, oxfmt: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate (#23886) (overlookmotel) - d86f60b lsp: Normalize user config path to watch pattern (#23723) (Sysix) ### ⚡ Performance - 4ddcba0 formatter_core: Add printable-ASCII fast path to TextWidth (#23913) (Lawrence Lin) ### 📚 Documentation - b4d0dc9 oxfmt,formatter,formatter_css,formatter_core: Update AGENTS.md (#23814) (leaysgur) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: Cameron <cameron.clark@hey.com>

- Implement `oxc_formatter_graphql` crate - Use `apollo-parser` crate from `apollo-rs` - https://github.com/apollographql/apollo-rs - Which follows Oct2021 spec - Prettier uses `graphql-js` and implements more and more syntax - v16 for `latest = 3.8.4` and v17 for `main = 3.9.x` NOTE: So at the point of this PR, diffs can be seen as skipped in prettier_conformance. Will be addressed in later PR by forking `apollo-parser`.

…#23318) - Use `oxc_formatter_graphql` from Oxfmt to handle `.gql` and `.graphql` files - At point of this PR, gql-in-js is still handled by Prettier As described in #23317, Prettier supports more syntax than ours, so for now fallback to Prettier when `oxc_formatter_graphql` failed to format. NOTE: This fallback will be removed in later PR.

# Oxlint ### 💥 BREAKING CHANGES - 88f4455 str: [**BREAKING**] `Str` and `Ident` methods take `&GetAllocator` (#23781) (overlookmotel) ### 🚀 Features - f2091b3 ast: Unify old and new `AstBuilder`s (#23875) (overlookmotel) - 1c8f50c linter: Add schema for `eslint/no-restricted-import` (#23642) (Sysix) ### 🐛 Bug Fixes - 7cb85c4 linter/eslint/no-negated-condition: Add autofix for negated conditions (#23825) (Yagiz Nizipli) - f7d1f50 oxlint, oxfmt: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate (#23886) (overlookmotel) - d891990 linter/jsx-a11y/role-supports-aria-props: Ignore nullish prop values (#23865) (Mikhail Baev) - 94b6599 linter: Deduplicate missing plugin errors (#23853) (camc314) - eff3eff linter/oxc/branches-sharing-code: Avoid else-if false positives (#23843) (camc314) - 2a2d3b9 linter/eslint/prefer-destructuring: Skip `AssignmentExpression` autofixes (#23818) (camc314) - ddc24ae linter/eslint/id-length: Respect checkGeneric for mapped type keys (#23802) (bab) - cd89202 linter/react/exhaustive-deps: Skip wrapper expression when analyzing hook initializers (#23793) (camc314) - 20e8285 linter/unicorn/prefer-native-coercion-function: Allow ts type predicates (#23774) (camc314) - d86f60b lsp: Normalize user config path to watch pattern (#23723) (Sysix) - 52032cf linter: Newline-terminate tsgolint errors (#23762) (Mikhail Baev) - 368fda7 linter/eslint/no-warning-comments: Avoid dropping generated regex patterns (#23741) (camc314) - ce44fbd linter/valid-title: Escape disallowed words regex (#23742) (camc314) - 3100d11 linter/prefer-called-exactly-once-with: Avoid out-of-bounds slice panic at end of file (#23625) (Jerry Zhao) - 742be36 refactor/node/handle-callback-err: Reject invalid regex config (#23740) (camc314) - d7be179 linter/eslint/no-restricted-globals: Handle shadowed locals (#23736) (camc314) - b3b1ff8 linter/vitest/expect-expect: Handle global vitest detection correctly (#23734) (camc314) ### ⚡ Performance - 68f9472 linter/jsx-a11y: Skip lowercasing non-aria attribute names (#23906) (Lawrence Lin) - b9312b4 linter/unicorn/prefer-export-from: Use keyed binding lookup (#23893) (Marius Schulz) - cd5204e linter/typescript/no-unsafe-declaration-merging: Use keyed binding lookup (#23894) (Marius Schulz) - e948498 linter/eslint/prefer-named-capture-group: Only dispatch for relevant node types (#23868) (Connor Shea) - 4ac7a8e linter/eslint/max-depth: Derive node types (#23896) (Connor Shea) - daeed09 linter/eslint/no-restricted-globals: Only scan unresolved references (#23890) (camc314) - e808514 linter/jest-vitest: Speed up no-standalone-expect (#23883) (camc314) - 8b165e5 linter/react/exhaustive-deps: Skip non-reactive calls early (#23882) (camc314) - 54005e7 linter/eslint/no-unused-vars: Precompute exported bindings (#23881) (camc314) - 9bc2f8c linter/unicorn/prefer-number-properties: Speed up global checks (#23880) (camc314) - 4ff104f linter: Optimize `require-hook` and `prefer-mock-*` rules to run on specific node types (#23871) (Connor Shea) - cc2213b linter: Run `no-underscore-dangle` only when relevant node types are present (#23867) (Connor Shea) - 3e55c21 linter/promise/always-return: Narrow to function node types (#23878) (Connor Shea) - 7136182 linter/jest-vitest: Speed up no-commented-out-tests (#23864) (camc314) - f138264 linter/eslint/no-script-url: Match javascript: prefix without allocating (#23861) (Lawrence Lin) - 7ef6895 linter/react/no-array-index-key: Delay index symbol lookup (#23857) (camc314) - 26bc171 linter/react/no-array-index-key: Match callback methods directly (#23856) (camc314) - 44fbbda linter/jsx-a11y/interactive-supports-focus: Check cheap conditions first (#23854) (camc314) - 84a5aa3 linter/eslint/no-extend-native: Skip lowercase references early (#23851) (camc314) - 88a74b2 linter/eslint/no-nonoctal-decimal-escape: Scan decimal escapes as bytes (#23850) (camc314) - fca69a8 linter: Skip traversal without this expressions (#23845) (camc314) - 838fd63 linter: Reduce preallocation for per-file diagnostics `Vec` (#23705) (Marius Schulz) - 417b506 linter/typescript/array-type: Remove full source text clone (#23751) (Marius Schulz) ### 📚 Documentation - 57e4469 linter/unicorn: Update prefer-dom-node-text-content rationale (#23933) (Mikhail Baev) - 3d61dea all: Correct capitalization in comments (#23887) (overlookmotel) ### 🛡️ Security - 3cdd18f deps: Update npm packages (#23690) (renovate[bot]) # Oxfmt ### 💥 BREAKING CHANGES - 259e0cd oxfmt,formatter_graphql: [**BREAKING**] Support draft syntax with removing prettier fallback (#23326) (leaysgur) - accbc49 oxfmt: [**BREAKING**] Format `parser:css,less,scss` files + css-in-js by `oxc_formatter_css` (#23321) (leaysgur) ### 🚀 Features - dffa4b3 formatter_css: Implement `oxc_formatter_css` (#23320) (leaysgur) - 01de9ec oxfmt: Format `parser:graphql` files by `oxc_formatter_graphql` (#23318) (leaysgur) - 4e66212 formatter_graphql: Implement oxc_formatter_graphql (#23317) (leaysgur) ### 🐛 Bug Fixes - 67325ae formatter_css: Handle frontmatter language (#23819) (leaysgur) - 3f355e5 formatter_graphql: Improve major prettier diffs (#23419) (leaysgur) - 48e2d78 formatter_css: Improve major prettier diffs (#23327) (leaysgur) - 8c07cad all: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate in tests (#23888) (overlookmotel) - f7d1f50 oxlint, oxfmt: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate (#23886) (overlookmotel) - d86f60b lsp: Normalize user config path to watch pattern (#23723) (Sysix) ### ⚡ Performance - 4ddcba0 formatter_core: Add printable-ASCII fast path to TextWidth (#23913) (Lawrence Lin) ### 📚 Documentation - b4d0dc9 oxfmt,formatter,formatter_css,formatter_core: Update AGENTS.md (#23814) (leaysgur) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: Cameron <cameron.clark@hey.com>

github-actions Bot added the A-formatter Area - Formatter label Jun 12, 2026

leaysgur force-pushed the 06-10-feat_formatter_graphql_implement_oxc_formatter_graphql branch from a0eb491 to 2d332e2 Compare June 15, 2026 01:28

This was referenced Jun 15, 2026

fix(formatter_graphql): improve major prettier diffs #23419

Merged

test(oxfmt): add gitlab as graphql conformance #23421

Merged

leaysgur force-pushed the 06-10-feat_formatter_graphql_implement_oxc_formatter_graphql branch from 2d332e2 to 08b2a18 Compare June 15, 2026 09:19

leaysgur mentioned this pull request Jun 15, 2026

test(oxfmt): add css + less + scss conformance #23435

Merged

leaysgur force-pushed the 06-10-feat_formatter_graphql_implement_oxc_formatter_graphql branch 2 times, most recently from 4e4c8a8 to 1ee0a04 Compare June 16, 2026 09:33

leaysgur mentioned this pull request Jun 16, 2026

refactor(formatter_graphql): fix up code and comments #23488

Merged

leaysgur force-pushed the 06-10-feat_formatter_graphql_implement_oxc_formatter_graphql branch from 1ee0a04 to f929a16 Compare June 17, 2026 06:27

leaysgur marked this pull request as ready for review June 18, 2026 01:04

leaysgur force-pushed the 06-10-feat_formatter_graphql_implement_oxc_formatter_graphql branch 4 times, most recently from 44a0b4f to 55f2efc Compare June 22, 2026 06:01

leaysgur mentioned this pull request Jun 22, 2026

refactor(formatter_css): fix up code and comments #23704

Merged

leaysgur force-pushed the 06-10-feat_formatter_graphql_implement_oxc_formatter_graphql branch 2 times, most recently from c9ebf46 to 1b2fb9b Compare June 24, 2026 04:21

leaysgur force-pushed the 06-10-feat_formatter_graphql_implement_oxc_formatter_graphql branch from 1b2fb9b to 9968b2c Compare June 25, 2026 00:58

leaysgur mentioned this pull request Jun 25, 2026

refactor(oxfmt): fix up code and comments #23770

Merged

leaysgur force-pushed the 06-10-feat_formatter_graphql_implement_oxc_formatter_graphql branch 2 times, most recently from eee870d to 74f9140 Compare June 25, 2026 15:02

leaysgur mentioned this pull request Jun 25, 2026

refactor(oxfmt,formatter_css): rework css-in-js with substituion #23787

Merged

leaysgur force-pushed the 06-10-feat_formatter_graphql_implement_oxc_formatter_graphql branch from 74f9140 to e09478c Compare June 26, 2026 07:00

leaysgur force-pushed the 06-10-feat_formatter_graphql_implement_oxc_formatter_graphql branch from e09478c to 81cc62e Compare June 29, 2026 02:31

This was referenced Jun 29, 2026

chore(formatter_graphql): use oxc-graphql-parser #23919

Merged

chore(formatter_css): use oxc-css-parser #23920

Merged

graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026

graphite-app Bot force-pushed the 06-10-feat_formatter_graphql_implement_oxc_formatter_graphql branch from 81cc62e to 4e66212 Compare June 29, 2026 02:38

graphite-app Bot merged commit 4e66212 into main Jun 29, 2026
30 checks passed

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026

graphite-app Bot deleted the 06-10-feat_formatter_graphql_implement_oxc_formatter_graphql branch June 29, 2026 02:53

oxc-guard Bot mentioned this pull request Jun 29, 2026

release(apps): oxlint v1.72.0 && oxfmt v0.57.0 #23935

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(formatter_graphql): implement oxc_formatter_graphql#23317

feat(formatter_graphql): implement oxc_formatter_graphql#23317
graphite-app[bot] merged 1 commit into
mainfrom
06-10-feat_formatter_graphql_implement_oxc_formatter_graphql

leaysgur commented Jun 12, 2026 •

edited

Loading

Uh oh!

leaysgur commented Jun 12, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Jun 12, 2026 •

edited

Loading

Uh oh!

graphite-app Bot commented Jun 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

leaysgur commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leaysgur commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

graphite-app Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

leaysgur commented Jun 12, 2026 •

edited

Loading

leaysgur commented Jun 12, 2026 •

edited

Loading

codspeed-hq Bot commented Jun 12, 2026 •

edited

Loading

graphite-app Bot commented Jun 29, 2026 •

edited

Loading