refactor(formatter_css): fix up code and comments by leaysgur · Pull Request #23704 · oxc-project/oxc

leaysgur · 2026-06-22T06:59:00Z

Finally fixed up Fable's work.
(There is no need to replicate Prettier bugs as-is!)

leaysgur · 2026-06-22T06:59:30Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

oxc-guard · 2026-06-22T08:46:27Z

Oxfmt Ecosystem CI

suite	oxfmt@latest	refs/pull/23704/head branch
AmanVarshney01/create-better-t-stack	✅	✅
fastify/fastify-vite	✅	✅
monkeytypegame/monkeytype	❌	✅
eggjs/egg	❌	✅
vercel/turborepo	✅	✅
tale/headplane	❌	✅
dyad-sh/dyad	✅	✅
formatjs/formatjs	❌	✅
vuejs/pinia	❌	✅
huggingface/huggingface.js	✅	✅
Comfy-Org/ComfyUI_frontend	✅	⚠️
actualbudget/actual	❌	✅
cnpm/cnpmcore	❌	✅
fuma-nama/fumadocs	✅	✅
npmx-dev/npmx.dev	✅	✅
getsentry/sentry-javascript	❌	✅
mastodon/mastodon	✅	✅
openclaw/openclaw	❌	✅
lichess-org/lila	✅	❌
vuejs/core	✅	✅
cloudflare/agents	✅	✅
rolldown/rolldown	✅	✅
aidenybai/react-grab	❌	✅
cloudflare/workers-sdk	❌	✅

💥 = panic, ⚠️ = error e.g. parse error (branch column: only new errors), ❌ = diff or exit code mismatch

codspeed-hq · 2026-06-22T09:10:44Z

Merging this PR will improve performance by 8.38%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 9 improved benchmarks
✅ 53 untouched benchmarks
⏩ 9 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Simulation	`linter[kitchen-sink.tsx]`	219.4 ms	180.4 ms	+21.62%
⚡	Simulation	`linter[binder.ts]`	34.2 ms	30.7 ms	+11.47%
⚡	Simulation	`linter[App.tsx]`	108.3 ms	98.4 ms	+10.06%
⚡	Simulation	`linter[react.development.js]`	15.7 ms	14.4 ms	+8.72%
⚡	Simulation	`formatter[errors.ts]`	614.1 µs	570.2 µs	+7.69%
⚡	Simulation	`isolated-declarations[vue-id.ts]`	52.8 ms	49.7 ms	+6.32%
⚡	Simulation	`formatter[handle-comments.js]`	2.9 ms	2.8 ms	+4.18%
⚡	Simulation	`formatter[index.tsx]`	3.9 ms	3.8 ms	+3.29%
⚡	Simulation	`formatter[core.js]`	1.6 ms	1.6 ms	+3.23%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing 06-22-refactor_formatter_css_fix_up_code_and_comments (a8b61c7) with 06-16-refactor_formatter_graphql_fix_up_code_and_comments (6e1d5a8)²}

9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on 06-16-refactor_formatter_graphql_fix_up_code_and_comments (951924a) during the generation of this report, so 5d87457 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

graphite-app · 2026-06-29T02:34:57Z

Merge activity

Jun 29, 2:34 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jun 29, 3:14 AM UTC: graphite-app added this pull request to the Graphite merge queue.
Jun 29, 3:38 AM UTC: Merged by the Graphite merge queue.

Finally fixed up Fable's work. (There is no need to replicate Prettier bugs as-is!)

leaysgur mentioned this pull request Jun 22, 2026

test(oxfmt): add css + less + scss conformance #23435

Merged

leaysgur force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch from 30a0d79 to 1d789ff Compare June 22, 2026 08:45

leaysgur added the run-oxfmt-ecosystem-ci label Jun 22, 2026

oxc-guard Bot removed the run-oxfmt-ecosystem-ci label Jun 22, 2026

leaysgur force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch from 1d789ff to 89c825c Compare June 22, 2026 09:02

leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from ba295c4 to 45ee8ab Compare June 23, 2026 00:49

leaysgur force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch 2 times, most recently from ff3162f to c5f699a Compare June 23, 2026 02:57

leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from 45ee8ab to b5bd51c Compare June 23, 2026 02:57

leaysgur force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch 4 times, most recently from b20716b to 578b3ed Compare June 23, 2026 06:13

leaysgur force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch from 694e05b to 85efda7 Compare June 25, 2026 01:31

leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from b7b7d83 to 69e36b0 Compare June 25, 2026 01:39

leaysgur force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch from 85efda7 to 5d18f9d Compare June 25, 2026 01:39

leaysgur marked this pull request as ready for review June 25, 2026 03:21

leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from 69e36b0 to 23db65e Compare June 25, 2026 15:03

leaysgur force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch from 5d18f9d to 14003ac Compare June 25, 2026 15:03

leaysgur mentioned this pull request Jun 25, 2026

refactor(oxfmt,formatter_css): rework css-in-js with substituion #23787

Merged

leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from 23db65e to 6e1d5a8 Compare June 26, 2026 07:01

leaysgur force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch from 14003ac to 50f3c8e Compare June 26, 2026 07:01

leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from 6e1d5a8 to ed1bf3d Compare June 29, 2026 02:32

leaysgur force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch from 50f3c8e to 77b31ea Compare June 29, 2026 02:32

This was referenced Jun 29, 2026

chore(formatter_graphql): use oxc-graphql-parser #23919

Merged

chore(formatter_css): use oxc-css-parser #23920

Merged

graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026

graphite-app Bot force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from 951924a to 63f0e3c Compare June 29, 2026 03:07

graphite-app Bot force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch from a8b61c7 to c3a80f8 Compare June 29, 2026 03:07

refactor(formatter_css): fix up code and comments (#23704)

78eba8c

Finally fixed up Fable's work. (There is no need to replicate Prettier bugs as-is!)

graphite-app Bot force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from 63f0e3c to cc8db2b Compare June 29, 2026 03:21

graphite-app Bot force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch from c3a80f8 to 78eba8c Compare June 29, 2026 03:22

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026

Base automatically changed from 06-16-refactor_formatter_graphql_fix_up_code_and_comments to main June 29, 2026 03:37

graphite-app Bot merged commit 78eba8c into main Jun 29, 2026
32 checks passed

graphite-app Bot deleted the 06-22-refactor_formatter_css_fix_up_code_and_comments branch June 29, 2026 03:38

camc314 pushed a commit that referenced this pull request Jul 3, 2026

refactor(formatter_css): fix up code and comments (#23704)

94dd3a4

Finally fixed up Fable's work. (There is no need to replicate Prettier bugs as-is!)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(formatter_css): fix up code and comments#23704

refactor(formatter_css): fix up code and comments#23704
graphite-app[bot] merged 1 commit into
mainfrom
06-22-refactor_formatter_css_fix_up_code_and_comments

leaysgur commented Jun 22, 2026 •

edited

Loading

Uh oh!

leaysgur commented Jun 22, 2026 •

edited

Loading

Uh oh!

oxc-guard Bot commented Jun 22, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Jun 22, 2026 •

edited

Loading

Uh oh!

graphite-app Bot commented Jun 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

leaysgur commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leaysgur commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

oxc-guard Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Oxfmt Ecosystem CI

Uh oh!

codspeed-hq Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 8.38%

Performance Changes

Footnotes

Uh oh!

graphite-app Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

leaysgur commented Jun 22, 2026 •

edited

Loading

leaysgur commented Jun 22, 2026 •

edited

Loading

oxc-guard Bot commented Jun 22, 2026 •

edited

Loading

codspeed-hq Bot commented Jun 22, 2026 •

edited

Loading

graphite-app Bot commented Jun 29, 2026 •

edited

Loading