Skip to content

refactor(oxfmt): fix up code and comments#23770

Merged
graphite-app[bot] merged 1 commit into
mainfrom
06-24-refactor_oxfmt_fix_up_code_and_comments
Jun 29, 2026
Merged

refactor(oxfmt): fix up code and comments#23770
graphite-app[bot] merged 1 commit into
mainfrom
06-24-refactor_oxfmt_fix_up_code_and_comments

Conversation

@leaysgur

@leaysgur leaysgur commented Jun 25, 2026

Copy link
Copy Markdown
Member

There's still room for refactoring, but this will serve as a starting point for now.

leaysgur commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-cli Area - CLI A-formatter Area - Formatter labels Jun 25, 2026
@leaysgur leaysgur force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch from e26d29f to 59fcc8e Compare June 25, 2026 01:05
@leaysgur leaysgur force-pushed the 06-24-refactor_oxfmt_fix_up_code_and_comments branch 2 times, most recently from b819ae5 to d483085 Compare June 25, 2026 01:26
@leaysgur leaysgur force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch 2 times, most recently from 694e05b to 85efda7 Compare June 25, 2026 01:31
@leaysgur leaysgur force-pushed the 06-24-refactor_oxfmt_fix_up_code_and_comments branch from d483085 to 5224270 Compare June 25, 2026 01:31
@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 19 skipped benchmarks1


Comparing 06-24-refactor_oxfmt_fix_up_code_and_comments (fbe0875) with 06-22-refactor_formatter_css_fix_up_code_and_comments (14003ac)2

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on 06-22-refactor_formatter_css_fix_up_code_and_comments (50f3c8e) during the generation of this report, so f67effb was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@leaysgur leaysgur force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch from 85efda7 to 5d18f9d Compare June 25, 2026 01:39
@leaysgur leaysgur force-pushed the 06-24-refactor_oxfmt_fix_up_code_and_comments branch 2 times, most recently from 244fce4 to 4b990da Compare June 25, 2026 15:03
@leaysgur leaysgur force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch from 5d18f9d to 14003ac Compare June 25, 2026 15:03
@graphite-app

graphite-app Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Merge activity

@graphite-app graphite-app Bot force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch from a8b61c7 to c3a80f8 Compare June 29, 2026 03:07
@graphite-app graphite-app Bot force-pushed the 06-24-refactor_oxfmt_fix_up_code_and_comments branch from 0bf6a7e to 230e639 Compare June 29, 2026 03:08
There's still room for refactoring, but this will serve as a starting point for now.
@graphite-app graphite-app Bot force-pushed the 06-22-refactor_formatter_css_fix_up_code_and_comments branch from c3a80f8 to 78eba8c Compare June 29, 2026 03:22
@graphite-app graphite-app Bot force-pushed the 06-24-refactor_oxfmt_fix_up_code_and_comments branch from 230e639 to 6fe3e45 Compare June 29, 2026 03:22
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026
Base automatically changed from 06-22-refactor_formatter_css_fix_up_code_and_comments to main June 29, 2026 03:38
@graphite-app graphite-app Bot merged commit 6fe3e45 into main Jun 29, 2026
31 checks passed
@graphite-app graphite-app Bot deleted the 06-24-refactor_oxfmt_fix_up_code_and_comments branch June 29, 2026 03:39
camc314 pushed a commit that referenced this pull request Jul 3, 2026
There's still room for refactoring, but this will serve as a starting point for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant