Skip to content

feat(oxfmt,formatter_graphql)!: support draft syntax with removing prettier fallback#23326

Merged
graphite-app[bot] merged 1 commit into
mainfrom
06-12-feat_oxfmt_formatter_graphql_support_draft_syntax_with_removing_prettier_fallback
Jun 29, 2026
Merged

feat(oxfmt,formatter_graphql)!: support draft syntax with removing prettier fallback#23326
graphite-app[bot] merged 1 commit into
mainfrom
06-12-feat_oxfmt_formatter_graphql_support_draft_syntax_with_removing_prettier_fallback

Conversation

@leaysgur

@leaysgur leaysgur commented Jun 12, 2026

Copy link
Copy Markdown
Member
  • Fork apollo-rs to be compatible with Prettier(latest for now)
  • By doing this, Prettier fallback is no longer needed
  • And now all prettier_conformance are passed, no parse error skip

Warning

TODO: Move fork under oxc-project org and replace refs

leaysgur commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-cli Area - CLI A-formatter Area - Formatter labels Jun 12, 2026
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from f016429 to ef3b50d Compare June 12, 2026 07:42
@leaysgur leaysgur force-pushed the 06-12-feat_oxfmt_formatter_graphql_support_draft_syntax_with_removing_prettier_fallback branch from 98c0786 to 53d8f8e Compare June 12, 2026 07:42
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 8.36%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 9 improved benchmarks
✅ 53 untouched benchmarks
⏩ 9 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation linter[kitchen-sink.tsx] 219.4 ms 180.4 ms +21.63%
Simulation linter[binder.ts] 34.1 ms 30.7 ms +11.13%
Simulation linter[App.tsx] 108.4 ms 98.3 ms +10.24%
Simulation linter[react.development.js] 15.7 ms 14.4 ms +8.58%
Simulation formatter[errors.ts] 613.8 µs 570.6 µs +7.57%
Simulation isolated-declarations[vue-id.ts] 52.8 ms 49.7 ms +6.29%
Simulation formatter[handle-comments.js] 2.9 ms 2.8 ms +4.15%
Simulation formatter[index.tsx] 3.9 ms 3.8 ms +3.49%
Simulation formatter[core.js] 1.6 ms 1.6 ms +3.27%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing 06-12-feat_oxfmt_formatter_graphql_support_draft_syntax_with_removing_prettier_fallback (fb98f27) with 06-12-refactor_oxfmt_use_unified_embedded_ir_results (95061b3)2

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on 06-12-refactor_oxfmt_use_unified_embedded_ir_results (e94df89) during the generation of this report, so a23682f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from ef3b50d to e20eabf Compare June 12, 2026 07:44
@leaysgur leaysgur force-pushed the 06-12-feat_oxfmt_formatter_graphql_support_draft_syntax_with_removing_prettier_fallback branch 2 times, most recently from 7e40a5e to 8dd5ca2 Compare June 12, 2026 07:47
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch 2 times, most recently from 58af702 to ff23826 Compare June 12, 2026 07:58
@leaysgur leaysgur force-pushed the 06-12-feat_oxfmt_formatter_graphql_support_draft_syntax_with_removing_prettier_fallback branch from 8dd5ca2 to fe917bc Compare June 12, 2026 07:58
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch from ff23826 to d924eb7 Compare June 12, 2026 08:25
@leaysgur leaysgur force-pushed the 06-12-feat_oxfmt_formatter_graphql_support_draft_syntax_with_removing_prettier_fallback branch 2 times, most recently from b5a75a5 to 5dc2cda Compare June 12, 2026 08:45
@leaysgur leaysgur force-pushed the 06-12-refactor_oxfmt_use_unified_embedded_ir_results branch 2 times, most recently from 81b320c to a204713 Compare June 15, 2026 01:29
@leaysgur leaysgur force-pushed the 06-12-feat_oxfmt_formatter_graphql_support_draft_syntax_with_removing_prettier_fallback branch from 5dc2cda to 8fc36b1 Compare June 15, 2026 01:29
@leaysgur leaysgur force-pushed the graphite-base/23326 branch from e92460d to 4b04022 Compare June 25, 2026 00:59
@leaysgur leaysgur changed the base branch from graphite-base/23326 to 06-12-refactor_oxfmt_use_unified_embedded_ir_results June 25, 2026 00:59
@leaysgur leaysgur changed the base branch from 06-12-refactor_oxfmt_use_unified_embedded_ir_results to graphite-base/23326 June 25, 2026 01:05
@leaysgur leaysgur force-pushed the graphite-base/23326 branch from 4b04022 to b869fd5 Compare June 25, 2026 01:05
@leaysgur leaysgur force-pushed the 06-12-feat_oxfmt_formatter_graphql_support_draft_syntax_with_removing_prettier_fallback branch from 3eca242 to 1ac4249 Compare June 25, 2026 01:05
@leaysgur leaysgur changed the base branch from graphite-base/23326 to 06-12-refactor_oxfmt_use_unified_embedded_ir_results June 25, 2026 01:05
@leaysgur leaysgur changed the base branch from 06-12-refactor_oxfmt_use_unified_embedded_ir_results to graphite-base/23326 June 25, 2026 01:26
@leaysgur leaysgur force-pushed the graphite-base/23326 branch from b869fd5 to 271809c Compare June 25, 2026 01:26
@leaysgur leaysgur force-pushed the 06-12-feat_oxfmt_formatter_graphql_support_draft_syntax_with_removing_prettier_fallback branch from 1ac4249 to 1f5bd90 Compare June 25, 2026 01:26
@leaysgur leaysgur changed the base branch from graphite-base/23326 to 06-12-refactor_oxfmt_use_unified_embedded_ir_results June 25, 2026 01:26
@leaysgur leaysgur changed the base branch from 06-12-refactor_oxfmt_use_unified_embedded_ir_results to graphite-base/23326 June 25, 2026 01:30
@leaysgur leaysgur force-pushed the graphite-base/23326 branch from 271809c to 84a8300 Compare June 25, 2026 01:31
@leaysgur leaysgur force-pushed the 06-12-feat_oxfmt_formatter_graphql_support_draft_syntax_with_removing_prettier_fallback branch from 1f5bd90 to 0c30bed Compare June 25, 2026 01:31
@leaysgur leaysgur changed the base branch from graphite-base/23326 to 06-12-refactor_oxfmt_use_unified_embedded_ir_results June 25, 2026 01:31
@leaysgur leaysgur changed the base branch from 06-12-refactor_oxfmt_use_unified_embedded_ir_results to graphite-base/23326 June 25, 2026 01:39
@leaysgur leaysgur force-pushed the graphite-base/23326 branch from 84a8300 to f3d779b Compare June 25, 2026 01:39
@leaysgur leaysgur force-pushed the 06-12-feat_oxfmt_formatter_graphql_support_draft_syntax_with_removing_prettier_fallback branch from 0c30bed to 76507a5 Compare June 25, 2026 01:39
@leaysgur leaysgur changed the base branch from graphite-base/23326 to 06-12-refactor_oxfmt_use_unified_embedded_ir_results June 25, 2026 01:39
@graphite-app

graphite-app Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Merge activity

…ettier fallback (#23326)

- Fork `apollo-rs` to be compatible with Prettier(`latest` for now)
  - https://github.com/leaysgur/apollo-rs
- By doing this, Prettier fallback is no longer needed
- And now all prettier_conformance are passed, no parse error skip

> [!WARNING]
> TODO: Move fork under `oxc-project` org and replace refs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant