Skip to content

refactor(formatter_graphql): fix up code and comments#23488

Merged
graphite-app[bot] merged 1 commit into
mainfrom
06-16-refactor_formatter_graphql_fix_up_code_and_comments
Jun 29, 2026
Merged

refactor(formatter_graphql): fix up code and comments#23488
graphite-app[bot] merged 1 commit into
mainfrom
06-16-refactor_formatter_graphql_fix_up_code_and_comments

Conversation

@leaysgur

@leaysgur leaysgur commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Finally fixed up Fable's work.

This was referenced Jun 16, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@leaysgur Graphite App

leaysgur commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur mentioned this pull request Jun 16, 2026
Merged
@leaysgur leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from 6277e14 to da19e1e Compare June 17, 2026 06:28
@leaysgur leaysgur force-pushed the 06-15-test_oxfmt_add_scss_conformance branch from e7d92b7 to a06b354 Compare June 17, 2026 06:28
@codspeed-hq

codspeed-hq Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks1

Comparing 06-16-refactor_formatter_graphql_fix_up_code_and_comments (951924a) with main (e1f89ab)2

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on 06-15-test_oxfmt_add_scss_conformance (21faac9) during the generation of this report, so main (e1f89ab) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@leaysgur leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from da19e1e to 336b495 Compare June 17, 2026 06:40
@oxc-guard

oxc-guard Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Oxfmt Ecosystem CI

suite oxfmt@latest refs/pull/23488/head branch
monkeytypegame/monkeytype ❌ ✅
vercel/turborepo ✅ ✅
fuma-nama/fumadocs ✅ ✅
eggjs/egg ❌ ✅
vuejs/pinia ❌ ✅
AmanVarshney01/create-better-t-stack ✅ ✅
tale/headplane ❌ ✅
dyad-sh/dyad ✅ ✅
cnpm/cnpmcore ❌ ✅
cloudflare/workers-sdk ❌ ✅
formatjs/formatjs ❌ ✅
openclaw/openclaw ❌ ✅
actualbudget/actual ❌ ✅
getsentry/sentry-javascript ❌ ✅
Comfy-Org/ComfyUI_frontend ✅ ⚠️
vuejs/core ✅ ✅
npmx-dev/npmx.dev ✅ ✅
fastify/fastify-vite ✅ ✅
cloudflare/agents ✅ ✅
huggingface/huggingface.js ✅ ✅
aidenybai/react-grab ❌ ✅
mastodon/mastodon ✅ ✅
lichess-org/lila ✅ ❌
rolldown/rolldown ✅ ✅

💥 = panic, ⚠️ = error e.g. parse error (branch column: only new errors), ❌ = diff or exit code mismatch

@leaysgur leaysgur marked this pull request as ready for review June 18, 2026 01:27
@leaysgur

leaysgur commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

NOTE: Both ecosystem-ci diffs are coming from CSS formatter, not from GraphQL formatter.

Current ecosystem-ci repos contain only a few GraphQL files and some gql-in-js files.

@leaysgur leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from 336b495 to d949dde Compare June 18, 2026 01:55
@leaysgur leaysgur force-pushed the 06-15-test_oxfmt_add_scss_conformance branch from a06b354 to 9480d31 Compare June 18, 2026 01:55
@github-actions github-actions Bot added A-cli Area - CLI A-formatter Area - Formatter labels Jun 18, 2026
@leaysgur leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from d949dde to 137d05f Compare June 18, 2026 05:56
@leaysgur leaysgur force-pushed the 06-15-test_oxfmt_add_scss_conformance branch from 9480d31 to fe4c9ea Compare June 18, 2026 05:56
@leaysgur leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from db243ef to b7b7d83 Compare June 25, 2026 01:31
@leaysgur leaysgur force-pushed the 06-15-test_oxfmt_add_scss_conformance branch 2 times, most recently from ab9107b to e32b1b6 Compare June 25, 2026 01:39
@leaysgur leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from b7b7d83 to 69e36b0 Compare June 25, 2026 01:39
@leaysgur leaysgur force-pushed the 06-15-test_oxfmt_add_scss_conformance branch from e32b1b6 to efd6431 Compare June 25, 2026 15:03
@leaysgur leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from 69e36b0 to 23db65e Compare June 25, 2026 15:03
@leaysgur leaysgur mentioned this pull request Jun 25, 2026
Merged
@leaysgur leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from 23db65e to 6e1d5a8 Compare June 26, 2026 07:01
@leaysgur leaysgur force-pushed the 06-15-test_oxfmt_add_scss_conformance branch from efd6431 to 43a18b9 Compare June 26, 2026 07:01
This was referenced Jun 26, 2026
Merged
Merged
Merged
Merged
Merged
@leaysgur leaysgur force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from 6e1d5a8 to ed1bf3d Compare June 29, 2026 02:32
@leaysgur leaysgur force-pushed the 06-15-test_oxfmt_add_scss_conformance branch from 43a18b9 to 21faac9 Compare June 29, 2026 02:32
This was referenced Jun 29, 2026
Merged
Merged
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026
@graphite-app

graphite-app Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@graphite-app graphite-app Bot force-pushed the 06-15-test_oxfmt_add_scss_conformance branch from 942399e to d06f4b5 Compare June 29, 2026 03:06
@graphite-app graphite-app Bot force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from 951924a to 63f0e3c Compare June 29, 2026 03:07
@graphite-app graphite-app Bot force-pushed the 06-15-test_oxfmt_add_scss_conformance branch from d06f4b5 to af77116 Compare June 29, 2026 03:21
@graphite-app graphite-app Bot force-pushed the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch from 63f0e3c to cc8db2b Compare June 29, 2026 03:21
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026
Base automatically changed from 06-15-test_oxfmt_add_scss_conformance to main June 29, 2026 03:36
@graphite-app graphite-app Bot merged commit cc8db2b into main Jun 29, 2026
32 checks passed
@graphite-app graphite-app Bot deleted the 06-16-refactor_formatter_graphql_fix_up_code_and_comments branch June 29, 2026 03:37
camc314 pushed a commit that referenced this pull request Jul 3, 2026
@leaysgur @camc314
refactor(formatter_graphql): fix up code and comments (#23488)
1db2443 
Finally fixed up Fable's work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-cli Area - CLI A-formatter Area - Formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leaysgur @fisker