Skip to content

refactor(oxfmt,formatter_css): rework css-in-js with substituion#23787

Merged
graphite-app[bot] merged 1 commit into
mainfrom
06-26-refactor_oxfmt_formatter_css_rework_css-in-js_with_substituion
Jun 29, 2026
Merged

refactor(oxfmt,formatter_css): rework css-in-js with substituion#23787
graphite-app[bot] merged 1 commit into
mainfrom
06-26-refactor_oxfmt_formatter_css_rework_css-in-js_with_substituion

Conversation

@leaysgur

@leaysgur leaysgur commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

As we have forked the CSS parser, we can control how JS substitutions ${} inside css-in-js are represented and how they interact.

We are no longer bound by Prettier’s conventions, allowing us to implement the code more efficiently.

This was referenced Jun 25, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@leaysgur Graphite App

leaysgur commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-cli Area - CLI A-formatter Area - Formatter labels Jun 25, 2026
@oxc-guard

oxc-guard Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Oxfmt Ecosystem CI

suite oxfmt@latest refs/pull/23787/head branch
openclaw/openclaw ❌ ✅
AmanVarshney01/create-better-t-stack ✅ ✅
formatjs/formatjs ❌ ✅
Comfy-Org/ComfyUI_frontend ✅ ⚠️
cnpm/cnpmcore ❌ ✅
fuma-nama/fumadocs ✅ ✅
getsentry/sentry-javascript ❌ ✅
eggjs/egg ❌ ✅
actualbudget/actual ❌ ✅
fastify/fastify-vite ✅ ✅
vercel/turborepo ✅ ✅
vuejs/core ✅ ✅
mastodon/mastodon ✅ ✅
vuejs/pinia ❌ ✅
monkeytypegame/monkeytype ❌ ✅
huggingface/huggingface.js ✅ ✅
cloudflare/workers-sdk ❌ ✅
dyad-sh/dyad ✅ ✅
tale/headplane ❌ ✅
cloudflare/agents ✅ ✅
npmx-dev/npmx.dev ✅ ✅
lichess-org/lila ✅ ❌
aidenybai/react-grab ❌ ✅
rolldown/rolldown ✅ ✅

💥 = panic, ⚠️ = error e.g. parse error (branch column: only new errors), ❌ = diff or exit code mismatch

@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 57 untouched benchmarks
⏩ 14 skipped benchmarks1

Comparing 06-26-refactor_oxfmt_formatter_css_rework_css-in-js_with_substituion (6a3a7d6) with main (6fe3e45)

Open in CodSpeed

Footnotes

  1. 14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@leaysgur leaysgur marked this pull request as ready for review June 26, 2026 03:38
@leaysgur leaysgur force-pushed the 06-24-refactor_oxfmt_fix_up_code_and_comments branch from 4b990da to fbe0875 Compare June 26, 2026 07:01
@leaysgur leaysgur force-pushed the 06-26-refactor_oxfmt_formatter_css_rework_css-in-js_with_substituion branch from 6220e9e to 0219559 Compare June 26, 2026 07:01
This was referenced Jun 26, 2026
Merged
Merged
Merged
This was referenced Jun 26, 2026
Merged
Merged
@leaysgur leaysgur changed the base branch from 06-24-refactor_oxfmt_fix_up_code_and_comments to graphite-base/23787 June 29, 2026 02:32
@leaysgur leaysgur force-pushed the 06-26-refactor_oxfmt_formatter_css_rework_css-in-js_with_substituion branch from 0219559 to d973180 Compare June 29, 2026 02:32
@leaysgur leaysgur force-pushed the graphite-base/23787 branch from fbe0875 to deb94d8 Compare June 29, 2026 02:32
@leaysgur leaysgur changed the base branch from graphite-base/23787 to 06-24-refactor_oxfmt_fix_up_code_and_comments June 29, 2026 02:33
This was referenced Jun 29, 2026
Merged
Merged
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026
@graphite-app

graphite-app Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

  • Jun 29, 2:35 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 29, 3:25 AM UTC: graphite-app added this pull request to the Graphite merge queue.
  • Jun 29, 3:41 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Jun 29, 3:49 AM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Jun 29, 3:49 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 29, 3:53 AM UTC: graphite-app added this pull request to the Graphite merge queue.
  • Jun 29, 3:58 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app Bot force-pushed the 06-24-refactor_oxfmt_fix_up_code_and_comments branch from 0bf6a7e to 230e639 Compare June 29, 2026 03:08
@graphite-app graphite-app Bot force-pushed the 06-26-refactor_oxfmt_formatter_css_rework_css-in-js_with_substituion branch from 509e2ce to 60026e3 Compare June 29, 2026 03:08
@graphite-app graphite-app Bot changed the base branch from 06-24-refactor_oxfmt_fix_up_code_and_comments to graphite-base/23787 June 29, 2026 03:22
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026
@graphite-app graphite-app Bot changed the base branch from graphite-base/23787 to main June 29, 2026 03:40
@leaysgur leaysgur force-pushed the 06-26-refactor_oxfmt_formatter_css_rework_css-in-js_with_substituion branch from 60026e3 to 6a3a7d6 Compare June 29, 2026 03:48
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026
@leaysgur
refactor(oxfmt,formatter_css): rework css-in-js with substituion (#23787
692c73a 
)

As we have forked the CSS parser, we can control how JS substitutions `${}` inside css-in-js are represented and how they interact.

We are no longer bound by Prettier’s conventions, allowing us to implement the code more efficiently.
@graphite-app graphite-app Bot force-pushed the 06-26-refactor_oxfmt_formatter_css_rework_css-in-js_with_substituion branch from 6a3a7d6 to 692c73a Compare June 29, 2026 03:54
@graphite-app graphite-app Bot merged commit 692c73a into main Jun 29, 2026
30 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026
@graphite-app graphite-app Bot deleted the 06-26-refactor_oxfmt_formatter_css_rework_css-in-js_with_substituion branch June 29, 2026 03:58
camc314 pushed a commit that referenced this pull request Jul 3, 2026
@leaysgur @camc314
refactor(oxfmt,formatter_css): rework css-in-js with substituion (#23787
ad5c0d7 
)

As we have forked the CSS parser, we can control how JS substitutions `${}` inside css-in-js are represented and how they interact.

We are no longer bound by Prettier’s conventions, allowing us to implement the code more efficiently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-cli Area - CLI A-formatter Area - Formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leaysgur