Skip to content

refactor(oxfmt,formatter): clean up tailwind sorter usage#23809

Merged
graphite-app[bot] merged 1 commit into
mainfrom
06-26-refactor_oxfmt_formatter_clean_up_tailwind_sorter_usage
Jun 29, 2026
Merged

refactor(oxfmt,formatter): clean up tailwind sorter usage#23809
graphite-app[bot] merged 1 commit into
mainfrom
06-26-refactor_oxfmt_formatter_clean_up_tailwind_sorter_usage

Conversation

@leaysgur

@leaysgur leaysgur commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Tailwind sorting is handled by JS, while the Rust side only collects class names.
Therefore, not all options are used on the Rust side (in the case of CSS, a bool is sufficient).

Because of this, unnecessary options are not passed to the Rust side.
(Previously, they were being passed even though they were not used.)

This was referenced Jun 26, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions Bot added A-cli Area - CLI A-formatter Area - Formatter labels Jun 26, 2026
This was referenced Jun 26, 2026
Merged
Merged
Merged
Merged
Merged
Merged
@leaysgur Graphite App

leaysgur commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur mentioned this pull request Jun 26, 2026
Merged
@codspeed-hq

codspeed-hq Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 19 skipped benchmarks1

Comparing 06-26-refactor_oxfmt_formatter_clean_up_tailwind_sorter_usage (1fa5775) with main (78eba8c)2

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on 06-26-refactor_formatter_clarify_jsdoc_embedded_formatting (e2b6b3b) during the generation of this report, so main (78eba8c) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@leaysgur leaysgur force-pushed the 06-26-refactor_oxfmt_formatter_clean_up_tailwind_sorter_usage branch 2 times, most recently from ef4ba35 to 9c1b714 Compare June 26, 2026 09:03
This was referenced Jun 26, 2026
Merged
Merged
@leaysgur leaysgur force-pushed the 06-26-refactor_formatter_clarify_jsdoc_embedded_formatting branch from 60bf9fe to d3f3837 Compare June 29, 2026 02:32
@leaysgur leaysgur force-pushed the 06-26-refactor_oxfmt_formatter_clean_up_tailwind_sorter_usage branch from 9c1b714 to bbe46c4 Compare June 29, 2026 02:33
This was referenced Jun 29, 2026
Merged
Merged
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026
@graphite-app graphite-app Bot force-pushed the 06-26-refactor_formatter_clarify_jsdoc_embedded_formatting branch from fa23271 to 859924f Compare June 29, 2026 03:10
@graphite-app graphite-app Bot force-pushed the 06-26-refactor_oxfmt_formatter_clean_up_tailwind_sorter_usage branch from fa4b339 to b672aef Compare June 29, 2026 03:11
@graphite-app

graphite-app Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026
@leaysgur leaysgur force-pushed the 06-26-refactor_formatter_clarify_jsdoc_embedded_formatting branch from 859924f to e2b6b3b Compare June 29, 2026 03:48
@leaysgur leaysgur force-pushed the 06-26-refactor_oxfmt_formatter_clean_up_tailwind_sorter_usage branch from b672aef to 1fa5775 Compare June 29, 2026 03:48
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026
@graphite-app graphite-app Bot force-pushed the 06-26-refactor_formatter_clarify_jsdoc_embedded_formatting branch from e2b6b3b to 86adbd1 Compare June 29, 2026 03:59
@graphite-app graphite-app Bot force-pushed the 06-26-refactor_oxfmt_formatter_clean_up_tailwind_sorter_usage branch from 1fa5775 to 68bc720 Compare June 29, 2026 03:59
@leaysgur
refactor(oxfmt,formatter): clean up tailwind sorter usage (#23809)
4e03018 
Tailwind sorting is handled by JS, while the Rust side only collects class names.
Therefore, not all options are used on the Rust side (in the case of CSS, a `bool` is sufficient).

Because of this, unnecessary options are not passed to the Rust side.
(Previously, they were being passed even though they were not used.)
@graphite-app graphite-app Bot force-pushed the 06-26-refactor_formatter_clarify_jsdoc_embedded_formatting branch from 86adbd1 to 96b48a3 Compare June 29, 2026 04:07
@graphite-app graphite-app Bot force-pushed the 06-26-refactor_oxfmt_formatter_clean_up_tailwind_sorter_usage branch from 68bc720 to 4e03018 Compare June 29, 2026 04:07
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 29, 2026
Base automatically changed from 06-26-refactor_formatter_clarify_jsdoc_embedded_formatting to main June 29, 2026 04:13
@graphite-app graphite-app Bot merged commit 4e03018 into main Jun 29, 2026
31 checks passed
@graphite-app graphite-app Bot deleted the 06-26-refactor_oxfmt_formatter_clean_up_tailwind_sorter_usage branch June 29, 2026 04:13
camc314 pushed a commit that referenced this pull request Jul 3, 2026
@leaysgur @camc314
refactor(oxfmt,formatter): clean up tailwind sorter usage (#23809)
fc890fc 
Tailwind sorting is handled by JS, while the Rust side only collects class names.
Therefore, not all options are used on the Rust side (in the case of CSS, a `bool` is sufficient).

Because of this, unnecessary options are not passed to the Rust side.
(Previously, they were being passed even though they were not used.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-cli Area - CLI A-formatter Area - Formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leaysgur